DM-Devel Archive mirror
 help / color / mirror / Atom feed
From: Martin Wilck <mwilck@suse.com>
To: Benjamin Marzinski <bmarzins@redhat.com>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>,
	 dm-devel@lists.linux.dev, Peter Rajnoha <prajnoha@redhat.com>
Subject: Re: [PATCH v2 08/11] 11-dm-mpath.rules: replace DM_NOSCAN by .DM_NOSCAN
Date: Tue, 09 Apr 2024 15:55:56 +0200	[thread overview]
Message-ID: <3235505f5f6f5e744cfa2ad4c19c64bacc3731b5.camel@suse.com> (raw)
In-Reply-To: <ZhQ7yrm3jfG4v4zc@bmarzins-01.fast.eng.rdu2.dc.redhat.com>

On Mon, 2024-04-08 at 14:47 -0400, Benjamin Marzinski wrote:
> >  
> > +# device-mapper rules v2 compatibility for 13-dm-disk.rules
> > +ENV{DM_UDEV_RULES_VSN}!="3", ENV{DM_NOSCAN}="$env{.DM_NOSCAN}"
> > +
> 
> You missed a DM_UDEV_RULES_VSN change here.

Thanks!

Martin


  reply	other threads:[~2024-04-09 13:55 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-04 17:38 [PATCH v2 00/11] multipath udev rules changes for dm rules V3 Martin Wilck
2024-04-04 17:38 ` [PATCH v2 01/11] 11-dm-mpath.rules: explain logic for device becoming ready while suspended Martin Wilck
2024-04-08 18:01   ` Benjamin Marzinski
2024-04-04 17:38 ` [PATCH v2 02/11] 11-dm-mpath.rules: don't import DM_NOSCAN from udev db Martin Wilck
2024-04-08 18:01   ` Benjamin Marzinski
2024-04-04 17:38 ` [PATCH v2 03/11] 11-dm-mpath.rules: don't import ID_FS_VERSION " Martin Wilck
2024-04-04 17:38 ` [PATCH v2 04/11] 11-dm-mpath.rules: adapt MPATH_DEVICE_READY=0 logic to 10-dm.rules update Martin Wilck
2024-04-08 18:13   ` Benjamin Marzinski
2024-04-04 17:38 ` [PATCH v2 05/11] 11-dm-mpath.rules: adapt coldplug event handling ro " Martin Wilck
2024-04-08 18:33   ` Benjamin Marzinski
2024-04-04 17:38 ` [PATCH v2 06/11] 11-dm-mpath.rules: don't import properties with new 13-dm-disk.rules Martin Wilck
2024-04-08 18:34   ` Benjamin Marzinski
2024-04-04 17:38 ` [PATCH v2 07/11] 11-dm-mpath.rules: replace DM_SUSPENDED by .DM_SUSPENDED Martin Wilck
2024-04-08 18:40   ` Benjamin Marzinski
2024-04-04 17:38 ` [PATCH v2 08/11] 11-dm-mpath.rules: replace DM_NOSCAN by .DM_NOSCAN Martin Wilck
2024-04-08 18:47   ` Benjamin Marzinski
2024-04-09 13:55     ` Martin Wilck [this message]
2024-04-04 17:38 ` [PATCH v2 09/11] 11-dm-mpath.rules: simplify PATH_FAILED case Martin Wilck
2024-04-04 17:38 ` [PATCH v2 10/11] 11-dm-mpath.rules: make label names more intuitive Martin Wilck
2024-04-04 17:38 ` [PATCH v2 11/11] kpartx.rules: ignore DM_SUSPENDED Martin Wilck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3235505f5f6f5e744cfa2ad4c19c64bacc3731b5.camel@suse.com \
    --to=mwilck@suse.com \
    --cc=bmarzins@redhat.com \
    --cc=christophe.varoqui@opensvc.com \
    --cc=dm-devel@lists.linux.dev \
    --cc=prajnoha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).