From: Benjamin Marzinski <bmarzins@redhat.com>
To: Martin Wilck <martin.wilck@suse.com>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>,
dm-devel@lists.linux.dev, Peter Rajnoha <prajnoha@redhat.com>,
Martin Wilck <mwilck@suse.com>
Subject: Re: [PATCH v2 06/11] 11-dm-mpath.rules: don't import properties with new 13-dm-disk.rules
Date: Mon, 8 Apr 2024 14:34:26 -0400 [thread overview]
Message-ID: <ZhQ4svAaQzPOoAV9@bmarzins-01.fast.eng.rdu2.dc.redhat.com> (raw)
In-Reply-To: <20240404173814.3143-7-mwilck@suse.com>
On Thu, Apr 04, 2024 at 07:38:09PM +0200, Martin Wilck wrote:
> With the late changes to 13-dm-disk.rules, we don't need to import any
> blkid-generated properties from the udev database, because they will
> be imported later.
>
> Except for ID_FS_TYPE, this actually holds since lvm2 commit 94f77a4 ("udev:
> import previous results of blkid when in suspended state"), included in lvm2
> 2.03.19, but we have no simple way to detect the version of the lvm2 rules.
>
> Signed-off-by: Martin Wilck <mwilck@suse.com>
Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
> ---
> multipath/11-dm-mpath.rules.in | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/multipath/11-dm-mpath.rules.in b/multipath/11-dm-mpath.rules.in
> index 5f547ca..95126bf 100644
> --- a/multipath/11-dm-mpath.rules.in
> +++ b/multipath/11-dm-mpath.rules.in
> @@ -126,6 +126,10 @@ LABEL="scan_import"
> # have never been properly set. Don't import them.
> ENV{DM_UDEV_PRIMARY_SOURCE_FLAG}!="1", GOTO="import_end"
>
> +# DM rules v3 will import missing properties on 13-dm-disk.rules.
> +# No need to do it here.
> +ENV{DM_UDEV_RULES_VSN}!="1|2", GOTO="import_end"
> +
> # Don't import the properties from db if we will run blkid later.
> ENV{DM_NOSCAN}!="1", ENV{DM_UDEV_DISABLE_OTHER_RULES_FLAG}!="1", GOTO="import_end"
>
> --
> 2.44.0
next prev parent reply other threads:[~2024-04-08 18:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 17:38 [PATCH v2 00/11] multipath udev rules changes for dm rules V3 Martin Wilck
2024-04-04 17:38 ` [PATCH v2 01/11] 11-dm-mpath.rules: explain logic for device becoming ready while suspended Martin Wilck
2024-04-08 18:01 ` Benjamin Marzinski
2024-04-04 17:38 ` [PATCH v2 02/11] 11-dm-mpath.rules: don't import DM_NOSCAN from udev db Martin Wilck
2024-04-08 18:01 ` Benjamin Marzinski
2024-04-04 17:38 ` [PATCH v2 03/11] 11-dm-mpath.rules: don't import ID_FS_VERSION " Martin Wilck
2024-04-04 17:38 ` [PATCH v2 04/11] 11-dm-mpath.rules: adapt MPATH_DEVICE_READY=0 logic to 10-dm.rules update Martin Wilck
2024-04-08 18:13 ` Benjamin Marzinski
2024-04-04 17:38 ` [PATCH v2 05/11] 11-dm-mpath.rules: adapt coldplug event handling ro " Martin Wilck
2024-04-08 18:33 ` Benjamin Marzinski
2024-04-04 17:38 ` [PATCH v2 06/11] 11-dm-mpath.rules: don't import properties with new 13-dm-disk.rules Martin Wilck
2024-04-08 18:34 ` Benjamin Marzinski [this message]
2024-04-04 17:38 ` [PATCH v2 07/11] 11-dm-mpath.rules: replace DM_SUSPENDED by .DM_SUSPENDED Martin Wilck
2024-04-08 18:40 ` Benjamin Marzinski
2024-04-04 17:38 ` [PATCH v2 08/11] 11-dm-mpath.rules: replace DM_NOSCAN by .DM_NOSCAN Martin Wilck
2024-04-08 18:47 ` Benjamin Marzinski
2024-04-09 13:55 ` Martin Wilck
2024-04-04 17:38 ` [PATCH v2 09/11] 11-dm-mpath.rules: simplify PATH_FAILED case Martin Wilck
2024-04-04 17:38 ` [PATCH v2 10/11] 11-dm-mpath.rules: make label names more intuitive Martin Wilck
2024-04-04 17:38 ` [PATCH v2 11/11] kpartx.rules: ignore DM_SUSPENDED Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhQ4svAaQzPOoAV9@bmarzins-01.fast.eng.rdu2.dc.redhat.com \
--to=bmarzins@redhat.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@lists.linux.dev \
--cc=martin.wilck@suse.com \
--cc=mwilck@suse.com \
--cc=prajnoha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).