From: Kent Overstreet <kent.overstreet@linux.dev>
To: Kuan-Wei Chiu <visitorckw@gmail.com>
Cc: colyli@suse.de, msakai@redhat.com, peterz@infradead.org,
mingo@redhat.com, acme@kernel.org, namhyung@kernel.org,
akpm@linux-foundation.org, bfoster@redhat.com,
mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com,
jserv@ccns.ncku.edu.tw, linux-bcache@vger.kernel.org,
dm-devel@lists.linux.dev, linux-bcachefs@vger.kernel.org,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/13] treewide: Refactor heap related implementation
Date: Tue, 19 Mar 2024 18:12:17 -0400 [thread overview]
Message-ID: <4t6kkvswhacphbjloh3fps7twqp5d3wgxv7yrkvthb5u3uzaoe@6pf7mnvsv3rm> (raw)
In-Reply-To: <20240319180005.246930-1-visitorckw@gmail.com>
On Wed, Mar 20, 2024 at 01:59:52AM +0800, Kuan-Wei Chiu wrote:
> Hello,
>
> This patch series focuses on several adjustments related to heap
> implementation. Firstly, a type-safe interface has been added to the
> min_heap, along with the introduction of several new functions to
> enhance its functionality. Additionally, the heap implementation for
> bcache and bcachefs has been replaced with the generic min_heap
> implementation from include/linux. Furthermore, several typos have been
> corrected.
>
> Previous discussion with Kent Overstreet:
> https://lkml.kernel.org/ioyfizrzq7w7mjrqcadtzsfgpuntowtjdw5pgn4qhvsdp4mqqg@nrlek5vmisbu
Hey, thanks for doing this. Can you post a git repo link? I'll point my
CI at it.
>
> Regards,
> Kuan-Wei
>
> Kuan-Wei Chiu (13):
> perf/core: Fix several typos
> bcache: Fix typo
> bcachefs: Fix typo
> lib min_heap: Add type safe interface
> lib min_heap: Add min_heap_init()
> lib min_heap: Add min_heap_peek()
> lib min_heap: Add min_heap_full()
> lib min_heap: Add args for min_heap_callbacks
> lib min_heap: Update min_heap_push() and min_heap_pop() to return bool
> values
> bcache: Remove heap-related macros and switch to generic min_heap
> lib min_heap: Add min_heap_del()
> lib min_heap: Add min_heap_sift_up()
> bcachefs: Remove heap-related macros and switch to generic min_heap
>
> drivers/md/bcache/alloc.c | 66 ++++++++----
> drivers/md/bcache/bcache.h | 2 +-
> drivers/md/bcache/bset.c | 73 ++++++++-----
> drivers/md/bcache/bset.h | 38 ++++---
> drivers/md/bcache/btree.c | 27 ++++-
> drivers/md/bcache/extents.c | 44 ++++----
> drivers/md/bcache/movinggc.c | 40 ++++++--
> drivers/md/bcache/super.c | 16 +++
> drivers/md/bcache/sysfs.c | 3 +
> drivers/md/bcache/util.c | 2 +-
> drivers/md/bcache/util.h | 81 +--------------
> drivers/md/dm-vdo/repair.c | 29 +++---
> drivers/md/dm-vdo/slab-depot.c | 21 ++--
> fs/bcachefs/clock.c | 53 +++++++---
> fs/bcachefs/clock_types.h | 2 +-
> fs/bcachefs/ec.c | 99 +++++++++++-------
> fs/bcachefs/ec_types.h | 2 +-
> fs/bcachefs/util.c | 2 +-
> fs/bcachefs/util.h | 127 ++---------------------
> include/linux/min_heap.h | 180 ++++++++++++++++++++++++++-------
> kernel/events/core.c | 53 +++++-----
> lib/test_min_heap.c | 75 +++++++-------
> 22 files changed, 565 insertions(+), 470 deletions(-)
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-03-19 22:12 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 17:59 [PATCH 00/13] treewide: Refactor heap related implementation Kuan-Wei Chiu
2024-03-19 17:59 ` [PATCH 01/13] perf/core: Fix several typos Kuan-Wei Chiu
2024-03-19 19:31 ` Ian Rogers
2024-03-19 17:59 ` [PATCH 02/13] bcache: Fix typo Kuan-Wei Chiu
2024-03-19 20:13 ` Ian Rogers
2024-03-19 17:59 ` [PATCH 03/13] bcachefs: " Kuan-Wei Chiu
2024-03-19 20:13 ` Ian Rogers
2024-03-19 17:59 ` [PATCH 04/13] lib min_heap: Add type safe interface Kuan-Wei Chiu
2024-03-19 19:49 ` Ian Rogers
2024-03-19 17:59 ` [PATCH 05/13] lib min_heap: Add min_heap_init() Kuan-Wei Chiu
2024-03-19 19:51 ` Ian Rogers
2024-03-20 2:56 ` Kuan-Wei Chiu
2024-03-19 17:59 ` [PATCH 06/13] lib min_heap: Add min_heap_peek() Kuan-Wei Chiu
2024-03-19 19:55 ` Ian Rogers
2024-03-19 17:59 ` [PATCH 07/13] lib min_heap: Add min_heap_full() Kuan-Wei Chiu
2024-03-19 19:55 ` Ian Rogers
2024-03-19 18:00 ` [PATCH 08/13] lib min_heap: Add args for min_heap_callbacks Kuan-Wei Chiu
2024-03-19 20:05 ` Ian Rogers
2024-03-20 2:49 ` Kuan-Wei Chiu
2024-03-20 4:43 ` Ian Rogers
2024-03-19 18:00 ` [PATCH 09/13] lib min_heap: Update min_heap_push() and min_heap_pop() to return bool values Kuan-Wei Chiu
2024-03-19 19:57 ` Ian Rogers
2024-03-19 18:00 ` [PATCH 10/13] bcache: Remove heap-related macros and switch to generic min_heap Kuan-Wei Chiu
2024-03-19 18:00 ` [PATCH 11/13] lib min_heap: Add min_heap_del() Kuan-Wei Chiu
2024-03-19 19:59 ` Ian Rogers
2024-03-19 18:00 ` [PATCH 12/13] lib min_heap: Add min_heap_sift_up() Kuan-Wei Chiu
2024-03-19 20:12 ` Ian Rogers
2024-03-20 2:51 ` Kuan-Wei Chiu
2024-03-19 18:00 ` [PATCH 13/13] bcachefs: Remove heap-related macros and switch to generic min_heap Kuan-Wei Chiu
2024-03-19 20:03 ` Ian Rogers
2024-03-20 2:55 ` Kuan-Wei Chiu
2024-03-19 22:12 ` Kent Overstreet [this message]
2024-03-20 3:01 ` [PATCH 00/13] treewide: Refactor heap related implementation Kuan-Wei Chiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4t6kkvswhacphbjloh3fps7twqp5d3wgxv7yrkvthb5u3uzaoe@6pf7mnvsv3rm \
--to=kent.overstreet@linux.dev \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bfoster@redhat.com \
--cc=colyli@suse.de \
--cc=dm-devel@lists.linux.dev \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=jserv@ccns.ncku.edu.tw \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=msakai@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=visitorckw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).