From: Ian Rogers <irogers@google.com>
To: Kuan-Wei Chiu <visitorckw@gmail.com>
Cc: colyli@suse.de, kent.overstreet@linux.dev, msakai@redhat.com,
peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
namhyung@kernel.org, akpm@linux-foundation.org,
bfoster@redhat.com, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
adrian.hunter@intel.com, jserv@ccns.ncku.edu.tw,
linux-bcache@vger.kernel.org, dm-devel@lists.linux.dev,
linux-bcachefs@vger.kernel.org,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/13] lib min_heap: Add min_heap_sift_up()
Date: Tue, 19 Mar 2024 13:12:18 -0700 [thread overview]
Message-ID: <CAP-5=fVcBAxt8Mw72=NCJPRJfjDaJcqk4rjbadgouAEAHz_q1A@mail.gmail.com> (raw)
In-Reply-To: <20240319180005.246930-13-visitorckw@gmail.com>
On Tue, Mar 19, 2024 at 11:01 AM Kuan-Wei Chiu <visitorckw@gmail.com> wrote:
>
> Add min_heap_sift_up() to sift up the element at index 'idx' in the
> heap.
Normally sift up is used to implement the min heap but isn't part of
the API, eg. there is a sift up in min_heap_push. Should min_heapify
be renamed to min_heap_sift_down to align with this name?
Thanks,
Ian
> Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
> ---
> include/linux/min_heap.h | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/include/linux/min_heap.h b/include/linux/min_heap.h
> index ce085137fce7..586965977104 100644
> --- a/include/linux/min_heap.h
> +++ b/include/linux/min_heap.h
> @@ -199,6 +199,26 @@ bool __min_heap_push(struct __min_heap *heap, const void *element, size_t elem_s
> #define min_heap_push(_heap, _element, _func, _args) \
> __min_heap_push(&(_heap)->heap, _element, __minheap_obj_size(_heap), _func, _args)
>
> +/* Sift up ith element from the heap, O(log2(nr)). */
> +static __always_inline
> +void __min_heap_sift_up(struct __min_heap *heap, size_t elem_size, size_t idx,
> + const struct min_heap_callbacks *func, void *args)
> +{
> + void *data = heap->data;
> + size_t parent;
> +
> + while (idx) {
> + parent = (idx - 1) / 2;
> + if (func->less(data + parent * elem_size, data + idx * elem_size, args))
> + break;
> + func->swp(data + parent * elem_size, data + idx * elem_size, args);
> + idx = parent;
> + }
> +}
> +
> +#define min_heap_sift_up(_heap, _idx, _func, _args) \
> + __min_heap_sift_up(&(_heap)->heap, __minheap_obj_size(_heap), _idx, _func, _args)
> +
> /* Remove ith element from the heap, O(log2(nr)). */
> static __always_inline
> bool __min_heap_del(struct __min_heap *heap, size_t elem_size, size_t idx,
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-03-19 20:12 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 17:59 [PATCH 00/13] treewide: Refactor heap related implementation Kuan-Wei Chiu
2024-03-19 17:59 ` [PATCH 01/13] perf/core: Fix several typos Kuan-Wei Chiu
2024-03-19 19:31 ` Ian Rogers
2024-03-19 17:59 ` [PATCH 02/13] bcache: Fix typo Kuan-Wei Chiu
2024-03-19 20:13 ` Ian Rogers
2024-03-19 17:59 ` [PATCH 03/13] bcachefs: " Kuan-Wei Chiu
2024-03-19 20:13 ` Ian Rogers
2024-03-19 17:59 ` [PATCH 04/13] lib min_heap: Add type safe interface Kuan-Wei Chiu
2024-03-19 19:49 ` Ian Rogers
2024-03-19 17:59 ` [PATCH 05/13] lib min_heap: Add min_heap_init() Kuan-Wei Chiu
2024-03-19 19:51 ` Ian Rogers
2024-03-20 2:56 ` Kuan-Wei Chiu
2024-03-19 17:59 ` [PATCH 06/13] lib min_heap: Add min_heap_peek() Kuan-Wei Chiu
2024-03-19 19:55 ` Ian Rogers
2024-03-19 17:59 ` [PATCH 07/13] lib min_heap: Add min_heap_full() Kuan-Wei Chiu
2024-03-19 19:55 ` Ian Rogers
2024-03-19 18:00 ` [PATCH 08/13] lib min_heap: Add args for min_heap_callbacks Kuan-Wei Chiu
2024-03-19 20:05 ` Ian Rogers
2024-03-20 2:49 ` Kuan-Wei Chiu
2024-03-20 4:43 ` Ian Rogers
2024-03-19 18:00 ` [PATCH 09/13] lib min_heap: Update min_heap_push() and min_heap_pop() to return bool values Kuan-Wei Chiu
2024-03-19 19:57 ` Ian Rogers
2024-03-19 18:00 ` [PATCH 10/13] bcache: Remove heap-related macros and switch to generic min_heap Kuan-Wei Chiu
2024-03-19 18:00 ` [PATCH 11/13] lib min_heap: Add min_heap_del() Kuan-Wei Chiu
2024-03-19 19:59 ` Ian Rogers
2024-03-19 18:00 ` [PATCH 12/13] lib min_heap: Add min_heap_sift_up() Kuan-Wei Chiu
2024-03-19 20:12 ` Ian Rogers [this message]
2024-03-20 2:51 ` Kuan-Wei Chiu
2024-03-19 18:00 ` [PATCH 13/13] bcachefs: Remove heap-related macros and switch to generic min_heap Kuan-Wei Chiu
2024-03-19 20:03 ` Ian Rogers
2024-03-20 2:55 ` Kuan-Wei Chiu
2024-03-19 22:12 ` [PATCH 00/13] treewide: Refactor heap related implementation Kent Overstreet
2024-03-20 3:01 ` Kuan-Wei Chiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP-5=fVcBAxt8Mw72=NCJPRJfjDaJcqk4rjbadgouAEAHz_q1A@mail.gmail.com' \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bfoster@redhat.com \
--cc=colyli@suse.de \
--cc=dm-devel@lists.linux.dev \
--cc=jolsa@kernel.org \
--cc=jserv@ccns.ncku.edu.tw \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=msakai@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=visitorckw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).