From: Matthew Wilcox <willy@infradead.org>
To: James Zhu <jamesz@amd.com>
Cc: "Michał Winiarski" <michal.winiarski@intel.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
"Christian König" <christian.koenig@amd.com>,
"Emil Velikov" <emil.l.velikov@gmail.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Pekka Paalanen" <pekka.paalanen@collabora.com>,
"James Zhu" <James.Zhu@amd.com>,
"Oded Gabbay" <ogabbay@kernel.org>
Subject: Re: [PATCH v6 1/4] drm: Use XArray instead of IDR for minors
Date: Tue, 29 Aug 2023 19:37:16 +0100 [thread overview]
Message-ID: <ZO463CUKB3QIHDAu@casper.infradead.org> (raw)
In-Reply-To: <f18bb070-9767-3b5c-8a40-3c95d5740e1d@amd.com>
On Tue, Aug 29, 2023 at 02:35:34PM -0400, James Zhu wrote:
>
> On 2023-08-29 14:33, Matthew Wilcox wrote:
> > On Tue, Aug 29, 2023 at 01:34:22PM -0400, James Zhu wrote:
> > > > > > @@ -1067,7 +1055,7 @@ static void drm_core_exit(void)
> > > > > > unregister_chrdev(DRM_MAJOR, "drm");
> > > > > > debugfs_remove(drm_debugfs_root);
> > > > > > drm_sysfs_destroy();
> > > > > > - idr_destroy(&drm_minors_idr);
> > > > > [JZ] Should we call xa_destroy instead here?
> > > > We could, if we expect the xarray to potentially not be empty.
> > > > From what I understand - all minors should be released at this point.
> > > [JZ] In practice, adding destroy here will be better.
> > Why do you say that?
> [JZ] In case, the future, INIT adds something, need DESTROY to free
> completely.
That isn't going to happen.
next prev parent reply other threads:[~2023-08-29 18:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 21:14 [PATCH v6 0/4] drm: Use full allocated minor range for DRM Michał Winiarski
2023-07-24 21:14 ` [PATCH v6 1/4] drm: Use XArray instead of IDR for minors Michał Winiarski
2023-08-25 16:59 ` James Zhu
2023-08-28 21:08 ` Michał Winiarski
2023-08-29 17:34 ` James Zhu
2023-08-29 18:33 ` Matthew Wilcox
2023-08-29 18:35 ` James Zhu
2023-08-29 18:37 ` Matthew Wilcox [this message]
2023-07-24 21:14 ` [PATCH v6 2/4] accel: " Michał Winiarski
2023-07-24 21:14 ` [PATCH v6 3/4] drm: Expand max DRM device number to full MINORBITS Michał Winiarski
2023-07-24 22:29 ` James Zhu
2023-07-26 18:15 ` Simon Ser
2023-07-27 12:01 ` Christian König
2023-07-28 14:22 ` Simon Ser
2023-08-08 13:55 ` Christian König
2023-08-08 15:04 ` James Zhu
2023-08-23 10:53 ` Simon Ser
2023-08-23 10:58 ` Simon Ser
2023-08-23 14:06 ` James Zhu
2023-07-24 21:14 ` [PATCH v6 4/4] drm: Introduce force_extended_minors modparam Michał Winiarski
2023-08-30 16:31 ` [PATCH v6 0/4] drm: Use full allocated minor range for DRM James Zhu
2024-05-03 1:22 ` Eric Pilmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZO463CUKB3QIHDAu@casper.infradead.org \
--to=willy@infradead.org \
--cc=James.Zhu@amd.com \
--cc=airlied@linux.ie \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jamesz@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.winiarski@intel.com \
--cc=mripard@kernel.org \
--cc=ogabbay@kernel.org \
--cc=pekka.paalanen@collabora.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).