From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>, Armin Wolf <w_armin@gmx.de>
Cc: mlj@danelec.com, rafael.j.wysocki@intel.com, lenb@kernel.org,
jdelvare@suse.com, linux@roeck-us.net, linux@weissschuh.net,
ilpo.jarvinen@linux.intel.com, linux-acpi@vger.kernel.org,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH RESEND v5] ACPI: fan: Add hwmon support
Date: Mon, 22 Apr 2024 18:15:13 +0200 [thread overview]
Message-ID: <CAJZ5v0joULbyKQJ4suqKj7_UZwaA63M+N4AaWSm7vOdM4OZBEA@mail.gmail.com> (raw)
In-Reply-To: <ZiYTJOmwDVaws3lh@surfacebook.localdomain>
On Mon, Apr 22, 2024 at 9:36 AM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> Mon, Apr 22, 2024 at 08:08:35AM +0200, Armin Wolf kirjoitti:
> > Currently, the driver does only support a custom sysfs
> > interface to allow userspace to read the fan speed.
> > Add support for the standard hwmon interface so users
> > can read the fan speed with standard tools like "sensors".
> >
> > Tested with a custom ACPI SSDT.
>
> ...
>
> > +/*
> > + * fan_hwmon.c - hwmon interface for the ACPI Fan driver
>
> No file name in the file, it makes an unneeded burden if file is going to be
> renamed.
>
> > + *
> > + * Copyright (C) 2024 Armin Wolf <W_Armin@gmx.de>
> > + */
>
> ...
>
> > +#include <linux/acpi.h>
> > +#include <linux/hwmon.h>
>
> Please, follow IWYU pronciple, e.g., missing err.h here.
>
> > +#include <linux/limits.h>
> > +#include <linux/units.h>
>
> ...
>
> > +/* Returned when the ACPI fan does not support speed reporting */
> > +#define FAN_SPEED_UNAVAILABLE 0xffffffff
> > +#define FAN_POWER_UNAVAILABLE 0xffffffff
>
> Shouldn't these be rather as ~0 of the respective types or _MAX (from limits.h)
> or something like that?
>
> ...
>
> > +static struct acpi_fan_fps *acpi_fan_get_current_fps(struct acpi_fan *fan, u64 control)
> > +{
> > + int i;
>
> unsigned
>
> > + for (i = 0; i < fan->fps_count; i++) {
> > + if (fan->fps[i].control == control)
> > + return &fan->fps[i];
> > + }
> > +
> > + return NULL;
> > +}
>
> ...
>
> > +static umode_t acpi_fan_is_visible(const void *drvdata, enum hwmon_sensor_types type, u32 attr,
> > + int channel)
> > +{
> > + const struct acpi_fan *fan = drvdata;
> > + int i;
>
> unsigned
>
> > + switch (type) {
> > + case hwmon_fan:
> > + switch (attr) {
> > + case hwmon_fan_input:
> > + return 0444;
> > + case hwmon_fan_target:
> > + /* When in fine grain control mode, not every fan control value
> > + * has an associated fan performance state.
> > + */
> > + if (fan->fif.fine_grain_ctrl)
> > + return 0;
> > +
> > + return 0444;
> > + default:
>
> > + break;
> > + }
> > + break;
>
> Instead of two breaks, just return 0 from 'default' case.
I agree here, but for a different reason.
If all of the other cases return from the function, the default one
should return either unless there is a specific reason not to. IIUC,
there's no such reason in this case.
> > + case hwmon_power:
> > + switch (attr) {
> > + case hwmon_power_input:
> > + /* When in fine grain control mode, not every fan control value
> > + * has an associated fan performance state.
> > + */
>
> /*
> * Use correct style for multi-line
> * comment blocks. As in this example.
> */
Yes, please.
Thanks!
next prev parent reply other threads:[~2024-04-22 16:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 6:08 [PATCH RESEND v5] ACPI: fan: Add hwmon support Armin Wolf
2024-04-22 7:35 ` Andy Shevchenko
2024-04-22 16:15 ` Rafael J. Wysocki [this message]
2024-04-22 8:00 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0joULbyKQJ4suqKj7_UZwaA63M+N4AaWSm7vOdM4OZBEA@mail.gmail.com \
--to=rafael@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linux@weissschuh.net \
--cc=mlj@danelec.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=w_armin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).