From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Armin Wolf <W_Armin@gmx.de>
Cc: mlj@danelec.com, rafael.j.wysocki@intel.com, lenb@kernel.org,
jdelvare@suse.com, linux@roeck-us.net, linux@weissschuh.net,
ilpo.jarvinen@linux.intel.com, linux-acpi@vger.kernel.org,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH RESEND v5] ACPI: fan: Add hwmon support
Date: Mon, 22 Apr 2024 10:35:00 +0300 [thread overview]
Message-ID: <ZiYTJOmwDVaws3lh@surfacebook.localdomain> (raw)
In-Reply-To: <20240422060835.71708-1-W_Armin@gmx.de>
Mon, Apr 22, 2024 at 08:08:35AM +0200, Armin Wolf kirjoitti:
> Currently, the driver does only support a custom sysfs
> interface to allow userspace to read the fan speed.
> Add support for the standard hwmon interface so users
> can read the fan speed with standard tools like "sensors".
>
> Tested with a custom ACPI SSDT.
...
> +/*
> + * fan_hwmon.c - hwmon interface for the ACPI Fan driver
No file name in the file, it makes an unneeded burden if file is going to be
renamed.
> + *
> + * Copyright (C) 2024 Armin Wolf <W_Armin@gmx.de>
> + */
...
> +#include <linux/acpi.h>
> +#include <linux/hwmon.h>
Please, follow IWYU pronciple, e.g., missing err.h here.
> +#include <linux/limits.h>
> +#include <linux/units.h>
...
> +/* Returned when the ACPI fan does not support speed reporting */
> +#define FAN_SPEED_UNAVAILABLE 0xffffffff
> +#define FAN_POWER_UNAVAILABLE 0xffffffff
Shouldn't these be rather as ~0 of the respective types or _MAX (from limits.h)
or something like that?
...
> +static struct acpi_fan_fps *acpi_fan_get_current_fps(struct acpi_fan *fan, u64 control)
> +{
> + int i;
unsigned
> + for (i = 0; i < fan->fps_count; i++) {
> + if (fan->fps[i].control == control)
> + return &fan->fps[i];
> + }
> +
> + return NULL;
> +}
...
> +static umode_t acpi_fan_is_visible(const void *drvdata, enum hwmon_sensor_types type, u32 attr,
> + int channel)
> +{
> + const struct acpi_fan *fan = drvdata;
> + int i;
unsigned
> + switch (type) {
> + case hwmon_fan:
> + switch (attr) {
> + case hwmon_fan_input:
> + return 0444;
> + case hwmon_fan_target:
> + /* When in fine grain control mode, not every fan control value
> + * has an associated fan performance state.
> + */
> + if (fan->fif.fine_grain_ctrl)
> + return 0;
> +
> + return 0444;
> + default:
> + break;
> + }
> + break;
Instead of two breaks, just return 0 from 'default' case.
> + case hwmon_power:
> + switch (attr) {
> + case hwmon_power_input:
> + /* When in fine grain control mode, not every fan control value
> + * has an associated fan performance state.
> + */
/*
* Use correct style for multi-line
* comment blocks. As in this example.
*/
> + if (fan->fif.fine_grain_ctrl)
> + return 0;
> +
> + /* When all fan performance states contain no valid power data,
> + * when the associated attribute should not be created.
> + */
> + for (i = 0; i < fan->fps_count; i++) {
> + if (fan->fps[i].power != FAN_POWER_UNAVAILABLE)
> + return 0444;
> + }
> +
> + return 0;
> + default:
> + break;
> + }
> + break;
Ditto.
> + default:
> + break;
> + }
> +
> + return 0;
Return from the default.
With the above we got rid of 2 LoCs for free.
> +}
...
> + switch (type) {
> + case hwmon_fan:
> + switch (attr) {
> + case hwmon_fan_input:
> + if (fst.speed == FAN_SPEED_UNAVAILABLE)
> + return -ENODATA;
> +
> + if (fst.speed > LONG_MAX)
> + return -EOVERFLOW;
> +
> + *val = fst.speed;
> + return 0;
> + case hwmon_fan_target:
> + fps = acpi_fan_get_current_fps(fan, fst.control);
> + if (!fps)
> + return -ENODATA;
> +
> + if (fps->speed > LONG_MAX)
> + return -EOVERFLOW;
> +
> + *val = fps->speed;
> + return 0;
> + default:
> + break;
> + }
> + break;
As per above.
> + case hwmon_power:
> + switch (attr) {
> + case hwmon_power_input:
> + fps = acpi_fan_get_current_fps(fan, fst.control);
> + if (!fps)
> + return -ENODATA;
> +
> + if (fps->power == FAN_POWER_UNAVAILABLE)
> + return -ENODATA;
> +
> + if (fps->power > LONG_MAX / MICROWATT_PER_MILLIWATT)
> + return -EOVERFLOW;
> +
> + *val = fps->power * MICROWATT_PER_MILLIWATT;
> + return 0;
> + default:
> + break;
> + }
> + break;
Ditto.
> + default:
> + break;
> + }
> +
> + return -EOPNOTSUPP;
Ditto.
Again, 2 LoCs less here.
> +}
...
> +int devm_acpi_fan_create_hwmon(struct acpi_device *device)
> +{
> + struct acpi_fan *fan = acpi_driver_data(device);
> + struct device *hdev;
> +
> + hdev = devm_hwmon_device_register_with_info(&device->dev, "acpi_fan", fan,
> + &acpi_fan_chip_info, NULL);
> +
Redundant blank line.
> + return PTR_ERR_OR_ZERO(hdev);
> +}
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-04-22 7:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 6:08 [PATCH RESEND v5] ACPI: fan: Add hwmon support Armin Wolf
2024-04-22 7:35 ` Andy Shevchenko [this message]
2024-04-22 16:15 ` Rafael J. Wysocki
2024-04-22 8:00 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZiYTJOmwDVaws3lh@surfacebook.localdomain \
--to=andy.shevchenko@gmail.com \
--cc=W_Armin@gmx.de \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linux@weissschuh.net \
--cc=mlj@danelec.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).