From: Mauro Carvalho Chehab <mchehab@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Niklas Schnelle <schnelle@linux.ibm.com>,
Arnd Bergmann <arnd@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
John Garry <john.garry@huawei.com>,
Nick Hu <nickhu@andestech.com>, Greentime Hu <green.hu@gmail.com>,
Vincent Chen <deanbo422@gmail.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>, Guo Ren <guoren@kernel.org>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Ian Abbott <abbotti@mev.co.uk>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Karsten Keil <isdn@linux-pingi.de>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Sathya Prakash <sathya.prakash@broadcom.com>,
Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
Michael Grzeschik <m.grzeschik@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Kalle Valo <kvalo@kernel.org>, Jouni Malinen <j@w1.fi>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Hannes Reinecke <hare@suse.com>,
Kashyap Desai <kashyap.desai@broadcom.com>,
Sumit Saxena <sumit.saxena@broadcom.com>,
Shivasharan S <shivasharan.srikanteshwara@broadcom.com>,
Nilesh Javali <njavali@marvell.com>,
GR-QLogic-Storage-Upstream@marvell.com,
Mark Brown <broonie@kernel.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>,
Forest Bond <forest@alittletooquiet.net>,
Jiri Slaby <jirislaby@kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-pci@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-csky@vger.kernel.org, linux-ide@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-input@vger.kernel.org,
netdev@vger.kernel.org, linux-media@vger.kernel.org,
MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
intel-wired-lan@lists.osuosl.org, linux-wireless@vger.kernel.org,
megaraidlinux.pdl@broadcom.com, linux-spi@vger.kernel.org,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-serial@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-watchdog@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [RFC 01/32] Kconfig: introduce and depend on LEGACY_PCI
Date: Tue, 28 Dec 2021 10:15:16 +0100 [thread overview]
Message-ID: <20211228101435.3a55b983@coco.lan> (raw)
In-Reply-To: <YcrJAwsKIxxX18pW@kroah.com>
Em Tue, 28 Dec 2021 09:21:23 +0100
Greg Kroah-Hartman <gregkh@linuxfoundation.org> escreveu:
> On Mon, Dec 27, 2021 at 05:42:46PM +0100, Niklas Schnelle wrote:
> > --- a/drivers/pci/Kconfig
> > +++ b/drivers/pci/Kconfig
> > @@ -23,6 +23,17 @@ menuconfig PCI
> >
> > if PCI
> >
> > +config LEGACY_PCI
> > + bool "Enable support for legacy PCI devices"
> > + depends on HAVE_PCI
> > + help
> > + This option enables support for legacy PCI devices. This includes
> > + PCI devices attached directly or via a bridge on a PCI Express bus.
> > + It also includes compatibility features on PCI Express devices which
> > + make use of legacy I/O spaces.
This Kconfig doesn't seem what it is needed there, as this should be an
arch-dependent feature, and not something that the poor user should be
aware if a given architecture supports it or not. Also, the above will keep
causing warnings or errors with randconfigs.
Also, the "depends on HAVE_CPI" is bogus, as PCI already depends on
HAVE_PCI:
menuconfig PCI
bool "PCI support"
depends on HAVE_PCI
help
This option enables support for the PCI local bus, including
support for PCI-X and the foundations for PCI Express support.
Say 'Y' here unless you know what you are doing.
So, instead, I would expect that a new HAVE_xxx option would be
added at arch/*/Kconfig, like:
config X86
...
select HAVE_PCI_DIRECT_IO
It would also make sense to document it at Documentation/features/.
>
> All you really care about is the "legacy" I/O spaces here, this isn't
> tied to PCI specifically at all, right?
>
> So why not just have a OLD_STYLE_IO config option or something like
> that, to show that it's the i/o functions we care about here, not PCI at
> all?
>
> And maybe not call it "old" or "legacy" as time constantly goes forward,
> just describe it as it is, "DIRECT_IO"?
Agreed. HAVE_PCI_DIRECT_IO (or something similar) seems a more appropriate
name for it.
Thanks,
Mauro
next prev parent reply other threads:[~2021-12-28 9:15 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-27 16:42 [RFC 00/32] Kconfig: Introduce HAS_IOPORT and LEGACY_PCI options Niklas Schnelle
2021-12-27 16:42 ` [RFC 01/32] Kconfig: introduce and depend on LEGACY_PCI Niklas Schnelle
2021-12-27 17:48 ` Guenter Roeck
2021-12-28 2:09 ` Mauro Carvalho Chehab
2021-12-28 8:21 ` Greg Kroah-Hartman
2021-12-28 9:15 ` Mauro Carvalho Chehab [this message]
2021-12-28 10:58 ` Niklas Schnelle
2021-12-28 12:01 ` Greg Kroah-Hartman
2021-12-28 12:54 ` Mauro Carvalho Chehab
2021-12-28 15:06 ` Niklas Schnelle
2021-12-28 17:12 ` Mauro Carvalho Chehab
2021-12-29 11:45 ` Niklas Schnelle
2021-12-29 12:12 ` Mauro Carvalho Chehab
2021-12-29 16:03 ` Bjorn Helgaas
2021-12-29 16:55 ` Niklas Schnelle
2022-01-05 17:42 ` John Garry
2022-01-05 19:47 ` Bjorn Helgaas
2022-01-06 17:41 ` John Garry
2022-01-06 18:14 ` Bjorn Helgaas
2022-01-07 17:16 ` John Garry
2022-01-10 9:34 ` Niklas Schnelle
2021-12-27 16:42 ` [RFC 02/32] Kconfig: introduce HAS_IOPORT option and select it as necessary Niklas Schnelle
2021-12-28 10:08 ` Geert Uytterhoeven
2021-12-29 1:20 ` Michael Schmitz
2021-12-29 3:41 ` Arnd Bergmann
2021-12-29 4:15 ` Michael Schmitz
2021-12-30 1:48 ` Arnd Bergmann
2021-12-30 3:44 ` Michael Schmitz
2021-12-31 11:28 ` Niklas Schnelle
2021-12-31 16:04 ` Arnd Bergmann
2021-12-31 21:55 ` Michael Schmitz
2021-12-28 16:32 ` Mauro Carvalho Chehab
2021-12-27 16:42 ` [RFC 03/32] ACPI: Kconfig: add HAS_IOPORT dependencies Niklas Schnelle
2021-12-27 16:47 ` Rafael J. Wysocki
2021-12-27 17:02 ` Niklas Schnelle
2021-12-27 17:12 ` Rafael J. Wysocki
2021-12-27 17:15 ` Rafael J. Wysocki
2021-12-27 17:43 ` Niklas Schnelle
2021-12-28 15:20 ` Rafael J. Wysocki
2021-12-28 16:31 ` Niklas Schnelle
2021-12-27 16:42 ` [RFC 04/32] parport: PC style parport depends on HAS_IOPORT Niklas Schnelle
2021-12-28 10:14 ` Geert Uytterhoeven
2021-12-28 14:21 ` Niklas Schnelle
2021-12-29 2:58 ` Arnd Bergmann
2021-12-27 16:42 ` [RFC 05/32] char: impi, tpm: depend " Niklas Schnelle
2021-12-28 10:17 ` Geert Uytterhoeven
2021-12-28 12:13 ` Niklas Schnelle
2021-12-27 16:42 ` [RFC 06/32] speakup: Kconfig: add HAS_IOPORT dependencies Niklas Schnelle
2021-12-27 17:52 ` Samuel Thibault
2021-12-27 16:42 ` [RFC 07/32] Input: gameport: add ISA and " Niklas Schnelle
2021-12-27 16:42 ` [RFC 08/32] comedi: Kconfig: add " Niklas Schnelle
2021-12-27 16:42 ` [RFC 09/32] sound: " Niklas Schnelle
2021-12-27 16:42 ` [RFC 10/32] i2c: " Niklas Schnelle
2021-12-28 10:21 ` Geert Uytterhoeven
2021-12-28 12:13 ` Niklas Schnelle
2021-12-27 16:42 ` [RFC 11/32] Input: " Niklas Schnelle
2021-12-28 10:23 ` Geert Uytterhoeven
2021-12-27 16:42 ` [RFC 12/32] iio: adc: " Niklas Schnelle
2021-12-28 10:32 ` Geert Uytterhoeven
2021-12-28 12:50 ` Niklas Schnelle
2021-12-28 17:01 ` Jonathan Cameron
2022-01-30 15:05 ` Jonathan Cameron
2021-12-27 16:42 ` [RFC 13/32] hwmon: " Niklas Schnelle
2021-12-27 18:07 ` Guenter Roeck
2021-12-27 16:42 ` [RFC 14/32] leds: " Niklas Schnelle
2021-12-27 16:43 ` [RFC 15/32] media: " Niklas Schnelle
2021-12-27 16:43 ` [RFC 16/32] misc: handle " Niklas Schnelle
2021-12-28 8:15 ` Greg Kroah-Hartman
2021-12-27 16:43 ` [RFC 17/32] net: Kconfig: add " Niklas Schnelle
2021-12-27 17:28 ` Marc Kleine-Budde
2021-12-27 16:43 ` [RFC 18/32] pcmcia: " Niklas Schnelle
2021-12-27 18:41 ` Dominik Brodowski
2021-12-27 16:43 ` [RFC 19/32] platform: " Niklas Schnelle
2021-12-27 16:43 ` [RFC 20/32] pnp: " Niklas Schnelle
2021-12-27 16:43 ` [RFC 21/32] power: " Niklas Schnelle
2021-12-27 16:43 ` [RFC 22/32] video: handle " Niklas Schnelle
2021-12-27 16:43 ` [RFC 23/32] rtc: Kconfig: add " Niklas Schnelle
2021-12-27 16:43 ` [RFC 24/32] scsi: " Niklas Schnelle
2021-12-28 10:40 ` Geert Uytterhoeven
2021-12-27 16:43 ` [RFC 25/32] watchdog: " Niklas Schnelle
2021-12-27 18:03 ` Guenter Roeck
2021-12-28 9:58 ` Niklas Schnelle
2021-12-27 16:43 ` [RFC 26/32] drm: handle " Niklas Schnelle
2022-01-03 6:11 ` Gerd Hoffmann
2021-12-27 16:43 ` [RFC 27/32] PCI/sysfs: make I/O resource depend on HAS_IOPORT Niklas Schnelle
2021-12-27 22:04 ` Bjorn Helgaas
2021-12-27 16:43 ` [RFC 28/32] PCI: make quirk using inw() " Niklas Schnelle
2021-12-27 22:33 ` Bjorn Helgaas
2021-12-28 15:25 ` Niklas Schnelle
2021-12-28 16:35 ` Bjorn Helgaas
2021-12-28 16:52 ` Niklas Schnelle
2021-12-28 17:28 ` Bjorn Helgaas
2021-12-27 16:43 ` [RFC 29/32] firmware: dmi-sysfs: handle HAS_IOPORT dependencies Niklas Schnelle
2021-12-27 16:43 ` [RFC 30/32] /dev/port: don't compile file operations without CONFIG_DEVPORT Niklas Schnelle
2021-12-28 8:17 ` Greg Kroah-Hartman
2021-12-29 10:25 ` Niklas Schnelle
2021-12-29 10:38 ` Greg Kroah-Hartman
2021-12-30 16:19 ` Arnd Bergmann
2021-12-27 16:43 ` [RFC 31/32] usb: handle HAS_IOPORT dependencies Niklas Schnelle
2021-12-27 20:36 ` Alan Stern
2021-12-31 11:06 ` Niklas Schnelle
2021-12-31 17:15 ` Alan Stern
2022-01-03 11:35 ` Niklas Schnelle
2022-01-03 16:15 ` Alan Stern
2021-12-27 16:43 ` [RFC 32/32] asm-generic/io.h: drop inb() etc for HAS_IOPORT=n Niklas Schnelle
2022-01-06 17:45 ` [RFC 00/32] Kconfig: Introduce HAS_IOPORT and LEGACY_PCI options John Garry
2022-01-07 7:21 ` Niklas Schnelle
2022-01-07 16:57 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211228101435.3a55b983@coco.lan \
--to=mchehab@kernel.org \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=abbotti@mev.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=anthony.l.nguyen@intel.com \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@kernel.org \
--cc=bhelgaas@google.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=davem@davemloft.net \
--cc=deanbo422@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=forest@alittletooquiet.net \
--cc=green.hu@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=guoren@kernel.org \
--cc=hare@suse.com \
--cc=hsweeten@visionengravers.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=isdn@linux-pingi.de \
--cc=j@w1.fi \
--cc=jdelvare@suse.com \
--cc=jejb@linux.ibm.com \
--cc=jesse.brandeburg@intel.com \
--cc=jirislaby@kernel.org \
--cc=john.garry@huawei.com \
--cc=kashyap.desai@broadcom.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=m.grzeschik@pengutronix.de \
--cc=martin.petersen@oracle.com \
--cc=megaraidlinux.pdl@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=nickhu@andestech.com \
--cc=njavali@marvell.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=perex@perex.cz \
--cc=sathya.prakash@broadcom.com \
--cc=schnelle@linux.ibm.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=suganath-prabu.subramani@broadcom.com \
--cc=sumit.saxena@broadcom.com \
--cc=teddy.wang@siliconmotion.com \
--cc=tiwai@suse.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).