From: "Arnd Bergmann" <arnd@arndb.de>
To: "Yan Zhao" <yan.y.zhao@intel.com>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
guoren <guoren@kernel.org>, "Brian Cain" <bcain@quicinc.com>,
"Jonas Bonn" <jonas@southpole.se>,
"Stefan Kristiansson" <stefan.kristiansson@saunalahti.fi>,
"Stafford Horne" <shorne@gmail.com>,
Linux-Arch <linux-arch@vger.kernel.org>,
linux-kernel@vger.kernel.org,
"linux-csky@vger.kernel.org" <linux-csky@vger.kernel.org>,
linux-hexagon@vger.kernel.org,
"linux-openrisc@vger.kernel.org" <linux-openrisc@vger.kernel.org>
Subject: Re: [PATCH 0/4] apply page shift to PFN instead of VA in pfn_to_virt
Date: Fri, 02 Feb 2024 08:04:34 +0100 [thread overview]
Message-ID: <33a5d3a9-3154-4dad-afae-18b16e6cf61e@app.fastmail.com> (raw)
In-Reply-To: <Zbw/PpNkCQCbXPdP@yzhao56-desk.sh.intel.com>
On Fri, Feb 2, 2024, at 02:02, Yan Zhao wrote:
> On Thu, Feb 01, 2024 at 06:46:46AM +0100, Arnd Bergmann wrote:
>>
>> I think it's fair to assume we won't need asm-generic/page.h any
>> more, as we likely won't be adding new NOMMU architectures.
>> I can have a look myself at removing any such unused headers in
>> include/asm-generic/, it's probably not the only one.
>>
>> Can you just send a patch to remove the unused pfn_to_virt()
>> functions?
> Ok. I'll do it!
> BTW: do you think it's also good to keep this fixing series though we'll
> remove the unused function later?
> So if people want to revert the removal some day, they can get right one.
>
> Or maybe I'm just paranoid, and explanation about the fix in the commit
> message of patch for function removal is enough.
>
> What's your preference? :)
I would just remove it, there is no point in having both
pfn_to_kaddr() and pfn_to_virt() when they do the exact
same thing aside from this bug.
Just do a single patch for all architectures, no need to
have three or four identical ones when I'm going to merge
them all through the same tree anyway.
Just make sure you explain in the changelog what the bug was
and how you noticed it, in case anyone is ever tempted to
bring the function back.
Arnd
next prev parent reply other threads:[~2024-02-02 7:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 5:51 [PATCH 0/4] apply page shift to PFN instead of VA in pfn_to_virt Yan Zhao
2024-01-31 5:57 ` [PATCH 1/4] asm-generic/page.h: " Yan Zhao
2024-02-23 11:26 ` Guo Ren
2024-02-29 13:34 ` Linus Walleij
2024-02-29 23:01 ` Yan Zhao
2024-01-31 5:59 ` [PATCH 2/4] csky: " Yan Zhao
2024-02-23 11:26 ` Guo Ren
2024-01-31 6:00 ` [PATCH 3/4] Hexagon: " Yan Zhao
2024-01-31 6:01 ` [PATCH 4/4] openrisc: " Yan Zhao
2024-01-31 7:37 ` [PATCH 0/4] " Linus Walleij
2024-01-31 11:48 ` Arnd Bergmann
2024-02-01 0:01 ` Yan Zhao
2024-02-01 5:46 ` Arnd Bergmann
2024-02-01 10:46 ` Geert Uytterhoeven
2024-02-02 7:27 ` Arnd Bergmann
2024-02-02 1:02 ` Yan Zhao
2024-02-02 7:04 ` Arnd Bergmann [this message]
2024-02-02 14:09 ` Yan Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33a5d3a9-3154-4dad-afae-18b16e6cf61e@app.fastmail.com \
--to=arnd@arndb.de \
--cc=bcain@quicinc.com \
--cc=guoren@kernel.org \
--cc=jonas@southpole.se \
--cc=linus.walleij@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-openrisc@vger.kernel.org \
--cc=shorne@gmail.com \
--cc=stefan.kristiansson@saunalahti.fi \
--cc=yan.y.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).