From: Guo Ren <guoren@kernel.org>
To: Yan Zhao <yan.y.zhao@intel.com>
Cc: arnd@arndb.de, linus.walleij@linaro.org, bcain@quicinc.com,
jonas@southpole.se, stefan.kristiansson@saunalahti.fi,
shorne@gmail.com, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org,
linux-hexagon@vger.kernel.org, linux-openrisc@vger.kernel.org
Subject: Re: [PATCH 1/4] asm-generic/page.h: apply page shift to PFN instead of VA in pfn_to_virt
Date: Fri, 23 Feb 2024 19:26:09 +0800 [thread overview]
Message-ID: <CAJF2gTTEaTnUCJhyU-bw=em_fo9ZW6bK=eaahUVsHcXuwaM8rw@mail.gmail.com> (raw)
In-Reply-To: <20240131055740.2579-1-yan.y.zhao@intel.com>
On Wed, Jan 31, 2024 at 2:27 PM Yan Zhao <yan.y.zhao@intel.com> wrote:
>
> Apply the page shift to PFN to get physical address for final VA.
> The macro __va should take physical address instead of PFN as input.
>
> Fixes: 2d78057f0dd4 ("asm-generic/page.h: Make pfn accessors static inlines")
> Signed-off-by: Yan Zhao <yan.y.zhao@intel.com>
> ---
> include/asm-generic/page.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/asm-generic/page.h b/include/asm-generic/page.h
> index 9773582fd96e..4f1265207b9a 100644
> --- a/include/asm-generic/page.h
> +++ b/include/asm-generic/page.h
> @@ -81,7 +81,7 @@ static inline unsigned long virt_to_pfn(const void *kaddr)
> #define virt_to_pfn virt_to_pfn
> static inline void *pfn_to_virt(unsigned long pfn)
> {
> - return __va(pfn) << PAGE_SHIFT;
> + return __va(pfn << PAGE_SHIFT);
Oh, that's a terrible bug; Thx for fixing it.
Reviewed-by: Guo Ren <guoren@kernel.org>
> }
> #define pfn_to_virt pfn_to_virt
>
> --
> 2.17.1
>
--
Best Regards
Guo Ren
next prev parent reply other threads:[~2024-02-23 11:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 5:51 [PATCH 0/4] apply page shift to PFN instead of VA in pfn_to_virt Yan Zhao
2024-01-31 5:57 ` [PATCH 1/4] asm-generic/page.h: " Yan Zhao
2024-02-23 11:26 ` Guo Ren [this message]
2024-02-29 13:34 ` Linus Walleij
2024-02-29 23:01 ` Yan Zhao
2024-01-31 5:59 ` [PATCH 2/4] csky: " Yan Zhao
2024-02-23 11:26 ` Guo Ren
2024-01-31 6:00 ` [PATCH 3/4] Hexagon: " Yan Zhao
2024-01-31 6:01 ` [PATCH 4/4] openrisc: " Yan Zhao
2024-01-31 7:37 ` [PATCH 0/4] " Linus Walleij
2024-01-31 11:48 ` Arnd Bergmann
2024-02-01 0:01 ` Yan Zhao
2024-02-01 5:46 ` Arnd Bergmann
2024-02-01 10:46 ` Geert Uytterhoeven
2024-02-02 7:27 ` Arnd Bergmann
2024-02-02 1:02 ` Yan Zhao
2024-02-02 7:04 ` Arnd Bergmann
2024-02-02 14:09 ` Yan Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJF2gTTEaTnUCJhyU-bw=em_fo9ZW6bK=eaahUVsHcXuwaM8rw@mail.gmail.com' \
--to=guoren@kernel.org \
--cc=arnd@arndb.de \
--cc=bcain@quicinc.com \
--cc=jonas@southpole.se \
--cc=linus.walleij@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-openrisc@vger.kernel.org \
--cc=shorne@gmail.com \
--cc=stefan.kristiansson@saunalahti.fi \
--cc=yan.y.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).