Re: [PATCH v1 1/1] Support YUV422 for DPTX.

From: "LIANKUN YANG (杨连坤)" <Liankun.Yang@mediatek.com>
To: "Mac Shen (沈俊)" <Mac.Shen@mediatek.com>,
	"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
	"Jitao Shi (石记涛)" <jitao.shi@mediatek.com>,
	"daniel@ffwll.ch" <daniel@ffwll.ch>,
	"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
	"airlied@gmail.com" <airlied@gmail.com>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"angelogioacchino.delregno@collabora.com"
	<angelogioacchino.delregno@collabora.com>
Cc: "dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/1] Support YUV422 for DPTX.
Date: Mon, 13 May 2024 13:50:37 +0000	[thread overview]
Message-ID: <86238b30a01b4790837d5b56e1970ccc3af72c9f.camel@mediatek.com> (raw)
In-Reply-To: <8d624845-7450-485c-8000-0194bcf56458@collabora.com>

On Fri, 2024-05-10 at 12:05 +0200, AngeloGioacchino Del Regno wrote:
> Il 10/05/24 04:15, Liankun Yang ha scritto:
> > Adjust the training sequence.Detects the actual link condition
> > and calculates the bandwidth where the relevant resolution resides.
> > 
> > The bandwidth is recalculated and modes that exceed the bandwidth
> > are
> > filtered.
> > 
> > Example Modify bandwidth filtering requirements.
> > 
> > Signed-off-by: Liankun Yang <liankun.yang@mediatek.com>
> > ---
> >   drivers/gpu/drm/mediatek/mtk_dp.c | 81 ++++++++++++++++++------
> > -------
> >   1 file changed, 46 insertions(+), 35 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c
> > b/drivers/gpu/drm/mediatek/mtk_dp.c
> > index 2136a596efa1..3e645bd6fe27 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_dp.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_dp.c
> > @@ -66,6 +66,13 @@ enum {
> >   	MTK_DP_CAL_MAX,
> >   };
> >   
> > +enum mtk_dp_color_format {
> > +	MTK_DP_COLOR_FORMAT_RGB = 0,
> > +	MTK_DP_COLOR_FORMAT_YUV422 = 0x1,
> > +	MTK_DP_COLOR_FORMAT_YUV444 = 0x2,
> > +	MTK_DP_COLOR_FORMAT_YUV420 = 0x3,
> > +};
> 
> This is giving the same values as drm_dp.h, hence unneeded.

Because using the same values as drm_dp.h is wrong,I will use other
methods to deal with the problem in next version.

> 
> > +
> >   struct mtk_dp_train_info {
> >   	bool sink_ssc;
> >   	bool cable_plugged_in;
> > @@ -84,7 +91,7 @@ struct mtk_dp_audio_cfg {
> >   };
> >   
> >   struct mtk_dp_info {
> > -	enum dp_pixelformat format;
> > +	enum mtk_dp_color_format format;
> >   	struct videomode vm;
> >   	struct mtk_dp_audio_cfg audio_cur_cfg;
> >   };
> > @@ -457,7 +464,7 @@ static void mtk_dp_set_msa(struct mtk_dp
> > *mtk_dp)
> 
> ..snip..
> 
> > @@ -1888,9 +1896,28 @@ static irqreturn_t
> > mtk_dp_hpd_event_thread(int hpd, void *dev)
> >   			memset(&mtk_dp->info.audio_cur_cfg, 0,
> >   			       sizeof(mtk_dp->info.audio_cur_cfg));
> >   
> > +			mtk_dp->enabled = false;
> > +			/* power off aux */
> > +			mtk_dp_update_bits(mtk_dp,
> > MTK_DP_TOP_PWR_STATE,
> > +			       DP_PWR_STATE_BANDGAP_TPLL,
> > +			       DP_PWR_STATE_MASK);
> > +
> 
> This commit is not even based on upstream, so you haven't even tested
> it upstream.
> 
> Don't send untested commits.
> There's nothing to review here.
> 
> Regards,
> Angelo
> 

I will do it based on upstream in next version.

Thank you very mush for your comments.

Best Regards,
Liankun Yang

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel