From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Liankun Yang <liankun.yang@mediatek.com>,
chunkuang.hu@kernel.org, p.zabel@pengutronix.de,
airlied@gmail.com, daniel@ffwll.ch, matthias.bgg@gmail.com,
jitao.shi@mediatek.com, mac.shen@mediatek.com
Cc: dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] Support YUV422 for DPTX.
Date: Fri, 10 May 2024 12:05:49 +0200 [thread overview]
Message-ID: <8d624845-7450-485c-8000-0194bcf56458@collabora.com> (raw)
In-Reply-To: <20240510021810.19302-1-liankun.yang@mediatek.com>
Il 10/05/24 04:15, Liankun Yang ha scritto:
> Adjust the training sequence.Detects the actual link condition
> and calculates the bandwidth where the relevant resolution resides.
>
> The bandwidth is recalculated and modes that exceed the bandwidth are
> filtered.
>
> Example Modify bandwidth filtering requirements.
>
> Signed-off-by: Liankun Yang <liankun.yang@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dp.c | 81 ++++++++++++++++++-------------
> 1 file changed, 46 insertions(+), 35 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/drivers/gpu/drm/mediatek/mtk_dp.c
> index 2136a596efa1..3e645bd6fe27 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dp.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dp.c
> @@ -66,6 +66,13 @@ enum {
> MTK_DP_CAL_MAX,
> };
>
> +enum mtk_dp_color_format {
> + MTK_DP_COLOR_FORMAT_RGB = 0,
> + MTK_DP_COLOR_FORMAT_YUV422 = 0x1,
> + MTK_DP_COLOR_FORMAT_YUV444 = 0x2,
> + MTK_DP_COLOR_FORMAT_YUV420 = 0x3,
> +};
This is giving the same values as drm_dp.h, hence unneeded.
> +
> struct mtk_dp_train_info {
> bool sink_ssc;
> bool cable_plugged_in;
> @@ -84,7 +91,7 @@ struct mtk_dp_audio_cfg {
> };
>
> struct mtk_dp_info {
> - enum dp_pixelformat format;
> + enum mtk_dp_color_format format;
> struct videomode vm;
> struct mtk_dp_audio_cfg audio_cur_cfg;
> };
> @@ -457,7 +464,7 @@ static void mtk_dp_set_msa(struct mtk_dp *mtk_dp)
..snip..
> @@ -1888,9 +1896,28 @@ static irqreturn_t mtk_dp_hpd_event_thread(int hpd, void *dev)
> memset(&mtk_dp->info.audio_cur_cfg, 0,
> sizeof(mtk_dp->info.audio_cur_cfg));
>
> + mtk_dp->enabled = false;
> + /* power off aux */
> + mtk_dp_update_bits(mtk_dp, MTK_DP_TOP_PWR_STATE,
> + DP_PWR_STATE_BANDGAP_TPLL,
> + DP_PWR_STATE_MASK);
> +
This commit is not even based on upstream, so you haven't even tested it upstream.
Don't send untested commits.
There's nothing to review here.
Regards,
Angelo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-05-10 10:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 2:15 [PATCH v1 1/1] Support YUV422 for DPTX Liankun Yang
2024-05-10 10:05 ` AngeloGioacchino Del Regno [this message]
2024-05-13 13:50 ` LIANKUN YANG (杨连坤)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d624845-7450-485c-8000-0194bcf56458@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=airlied@gmail.com \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jitao.shi@mediatek.com \
--cc=liankun.yang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mac.shen@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).