From: Johan Hovold <johan@kernel.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Mark Brown <broonie@kernel.org>,
Johan Hovold <johan+linaro@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: qcom: gdsc: treat optional supplies as optional
Date: Tue, 26 Mar 2024 08:20:43 +0100 [thread overview]
Message-ID: <ZgJ3S8I4EH4RV5YQ@hovoldconsulting.com> (raw)
In-Reply-To: <bf2c507d-2320-425e-8bc2-8a2858281559@linaro.org>
On Mon, Mar 25, 2024 at 08:21:24PM +0100, Konrad Dybcio wrote:
> On 25.03.2024 3:10 PM, Dmitry Baryshkov wrote:
> > On Mon, 25 Mar 2024 at 16:01, Mark Brown <broonie@kernel.org> wrote:
> >>
> >> On Mon, Mar 25, 2024 at 09:19:57AM +0100, Johan Hovold wrote:
> >>> Since commit deebc79b28d6 ("clk: qcom: gpucc-sc8280xp: Add external
> >>> supply for GX gdsc") the GDSC supply must be treated as optional to
> >>> avoid warnings like:
> >>>
> >>> gpu_cc-sc8280xp 3d90000.clock-controller: supply vdd-gfx not found, using dummy regulator
> >>>
> >>> on SC8280XP.
> >>
> >> Can this device actually run with the supply physically disconnected?
> >
> > On SC8280XP this is supplied via power-domain instead of the supply.
>
> I think Dmitry is asking about this bit:
AFAICT, Dmitry did not ask anything.
> if (ret != -ENODEV)
> return ret;
>
> which is basically repeating the difference that _optional makes
Not sure what you meant by this either. This is how the regulator
subsystem works.
Johan
next prev parent reply other threads:[~2024-03-26 7:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 8:19 [PATCH] clk: qcom: gdsc: treat optional supplies as optional Johan Hovold
2024-03-25 14:01 ` Mark Brown
2024-03-25 14:10 ` Dmitry Baryshkov
2024-03-25 19:21 ` Konrad Dybcio
2024-03-26 7:20 ` Johan Hovold [this message]
2024-03-26 7:16 ` Johan Hovold
2024-03-26 11:24 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2024-03-25 8:58 Johan Hovold
2024-03-25 14:02 ` Bjorn Andersson
2024-04-04 21:22 ` Bjorn Andersson
2024-04-22 10:31 ` Linux regression tracking (Thorsten Leemhuis)
2024-04-22 18:31 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgJ3S8I4EH4RV5YQ@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).