From: Bjorn Andersson <andersson@kernel.org>
To: Johan Hovold <johan+linaro@kernel.org>
Cc: Konrad Dybcio <konrad.dybcio@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: qcom: gdsc: treat optional supplies as optional
Date: Mon, 25 Mar 2024 09:02:53 -0500 [thread overview]
Message-ID: <jdnylcw35fofffszbtwd4pq3tltowmbzhugxeiuthjqnpnrjkw@bjfpfgrhk4p2> (raw)
In-Reply-To: <20240325085835.26158-1-johan+linaro@kernel.org>
On Mon, Mar 25, 2024 at 09:58:35AM +0100, Johan Hovold wrote:
> Since commit deebc79b28d6 ("clk: qcom: gpucc-sc8280xp: Add external
> supply for GX gdsc") the GDSC supply must be treated as optional to
> avoid warnings like:
>
> gpu_cc-sc8280xp 3d90000.clock-controller: supply vdd-gfx not found, using dummy regulator
>
> on SC8280XP.
>
> Fortunately, the driver is already prepared to handle this by checking
> that the regulator pointer is non-NULL before use.
>
> This also avoids triggering a potential deadlock on SC8280XP even if the
> underlying issue still remains for the derivative platforms like SA8295P
> that actually use the supply.
>
> Fixes: deebc79b28d6 ("clk: qcom: gpucc-sc8280xp: Add external supply for GX gdsc")
> Link: https://lore.kernel.org/lkml/Zf25Sv2x9WaCFuIH@hovoldconsulting.com/
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Thanks for fixing this, it never made it off my todo list...
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
Regards,
Bjorn
> ---
> drivers/clk/qcom/gdsc.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/clk/qcom/gdsc.c b/drivers/clk/qcom/gdsc.c
> index e7a4068b9f39..df9618ab7eea 100644
> --- a/drivers/clk/qcom/gdsc.c
> +++ b/drivers/clk/qcom/gdsc.c
> @@ -487,9 +487,14 @@ int gdsc_register(struct gdsc_desc *desc,
> if (!scs[i] || !scs[i]->supply)
> continue;
>
> - scs[i]->rsupply = devm_regulator_get(dev, scs[i]->supply);
> - if (IS_ERR(scs[i]->rsupply))
> - return PTR_ERR(scs[i]->rsupply);
> + scs[i]->rsupply = devm_regulator_get_optional(dev, scs[i]->supply);
> + if (IS_ERR(scs[i]->rsupply)) {
> + ret = PTR_ERR(scs[i]->rsupply);
> + if (ret != -ENODEV)
> + return ret;
> +
> + scs[i]->rsupply = NULL;
> + }
> }
>
> data->num_domains = num;
> --
> 2.43.0
>
next prev parent reply other threads:[~2024-03-25 14:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 8:58 [PATCH] clk: qcom: gdsc: treat optional supplies as optional Johan Hovold
2024-03-25 14:02 ` Bjorn Andersson [this message]
2024-04-04 21:22 ` Bjorn Andersson
2024-04-22 10:31 ` Linux regression tracking (Thorsten Leemhuis)
2024-04-22 18:31 ` Bjorn Andersson
-- strict thread matches above, loose matches on Subject: below --
2024-03-25 8:19 Johan Hovold
2024-03-25 14:01 ` Mark Brown
2024-03-25 14:10 ` Dmitry Baryshkov
2024-03-25 19:21 ` Konrad Dybcio
2024-03-26 7:20 ` Johan Hovold
2024-03-26 7:16 ` Johan Hovold
2024-03-26 11:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jdnylcw35fofffszbtwd4pq3tltowmbzhugxeiuthjqnpnrjkw@bjfpfgrhk4p2 \
--to=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).