From: Bjorn Helgaas <helgaas@kernel.org>
To: Niklas Schnelle <schnelle@linux.ibm.com>
Cc: Arnd Bergmann <arnd@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
John Garry <john.garry@huawei.com>,
Nick Hu <nickhu@andestech.com>, Greentime Hu <green.hu@gmail.com>,
Vincent Chen <deanbo422@gmail.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>, Guo Ren <guoren@kernel.org>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-pci@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-csky@vger.kernel.org
Subject: Re: [RFC 28/32] PCI: make quirk using inw() depend on HAS_IOPORT
Date: Tue, 28 Dec 2021 10:35:41 -0600 [thread overview]
Message-ID: <20211228163541.GA1599602@bhelgaas> (raw)
In-Reply-To: <6b719d661f9ba7a23776b00a2f250d14cb21bafa.camel@linux.ibm.com>
On Tue, Dec 28, 2021 at 04:25:25PM +0100, Niklas Schnelle wrote:
> On Mon, 2021-12-27 at 16:33 -0600, Bjorn Helgaas wrote:
> > On Mon, Dec 27, 2021 at 05:43:13PM +0100, Niklas Schnelle wrote:
> > If we keep it in drivers/pci, please update the subject line to make
> > it more specific and match the convention, e.g.,
> >
> > PCI: Compile quirk_tigerpoint_bm_sts() only when HAS_IOPORT set
>
> Ah yeah I was going back and forth between matching this within the
> series vs matching the subsystem. I guess going with the subsystem is
> mote important long term.
Haha, yes, a little ambiguity there. I do think the subsystem is more
important because the identity of the series is mostly lost after it's
applied. Thanks for thinking about it!
> > BTW, git complains about some whitespace errors in other patches:
> >
> > Applying: char: impi, tpm: depend on HAS_IOPORT
> > .git/rebase-apply/patch:92: trailing whitespace.
> > If you have a TPM security chip from Atmel say Yes and it
> > .git/rebase-apply/patch:93: trailing whitespace.
> > will be accessible from within Linux. To compile this driver
> > warning: 2 lines add whitespace errors.
> > Applying: video: handle HAS_IOPORT dependencies
> > .git/rebase-apply/patch:23: trailing whitespace.
> >
> > warning: 1 line adds whitespace errors.
>
> That is very strange. I did run checkpatch before. There are a few
> warnings not to touch obsolete code unnecessarily and a check about
> using udelay() (pre-existing) plus two missing blank lines in pci-
> quirks.h that I ignored because it matches the sorounding style.
>
> I did notice that lore fails to render the subject lines for some of
> the patches. But I just tried fetching the patches with b4 on top of
> v5.16-rc7 and the resulting tree passes "./scripts/checkpatch.pl --git
> v5.16-rc7..HEAD" and has an empty diff to my branch. What tool did you
> use to check?
"git am" is what complained. Here's what I did:
$ git checkout -b wip/niklas v5.16-rc1
Switched to a new branch 'wip/niklas'
10:30:06 ~/linux (wip/niklas)$ b4 am -om/ 20211227164317.4146918-1-schnelle@linux.ibm.com
Looking up https://lore.kernel.org/r/20211227164317.4146918-1-schnelle%40linux.ibm.com
Grabbing thread from lore.kernel.org/all/20211227164317.4146918-1-schnelle%40linux.ibm.com/t.mbox.gz
Analyzing 70 messages in the thread
Checking attestation on all messages, may take a moment...
---
✓ [PATCH RFC 1/32] Kconfig: introduce and depend on LEGACY_PCI
✓ [PATCH RFC 2/32] Kconfig: introduce HAS_IOPORT option and select it as necessary
✓ [PATCH RFC 3/32] ACPI: Kconfig: add HAS_IOPORT dependencies
✓ [PATCH RFC 4/32] parport: PC style parport depends on HAS_IOPORT
✓ [PATCH RFC 5/32] char: impi, tpm: depend on HAS_IOPORT
✓ [PATCH RFC 6/32] speakup: Kconfig: add HAS_IOPORT dependencies
+ Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
✓ [PATCH RFC 7/32] Input: gameport: add ISA and HAS_IOPORT dependencies
✓ [PATCH RFC 8/32] comedi: Kconfig: add HAS_IOPORT dependencies
✓ [PATCH RFC 9/32] sound: Kconfig: add HAS_IOPORT dependencies
✓ [PATCH RFC 10/32] i2c: Kconfig: add HAS_IOPORT dependencies
✓ [PATCH RFC 11/32] Input: Kconfig: add HAS_IOPORT dependencies
✓ [PATCH RFC 12/32] iio: adc: Kconfig: add HAS_IOPORT dependencies
✓ [PATCH RFC 13/32] hwmon: Kconfig: add HAS_IOPORT dependencies
✓ [PATCH RFC 14/32] leds: Kconfig: add HAS_IOPORT dependencies
✓ [PATCH RFC 15/32] media: Kconfig: add HAS_IOPORT dependencies
✓ [PATCH RFC 16/32] misc: handle HAS_IOPORT dependencies
✓ [PATCH RFC 17/32] net: Kconfig: add HAS_IOPORT dependencies
+ Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
✓ [PATCH RFC 18/32] pcmcia: Kconfig: add HAS_IOPORT dependencies
+ Acked-by: Dominik Brodowski <linux@dominikbrodowski.net>
✓ [PATCH RFC 19/32] platform: Kconfig: add HAS_IOPORT dependencies
✓ [PATCH RFC 20/32] pnp: Kconfig: add HAS_IOPORT dependencies
✓ [PATCH RFC 21/32] power: Kconfig: add HAS_IOPORT dependencies
✓ [PATCH RFC 22/32] video: handle HAS_IOPORT dependencies
✓ [PATCH RFC 23/32] rtc: Kconfig: add HAS_IOPORT dependencies
✓ [PATCH RFC 24/32] scsi: Kconfig: add HAS_IOPORT dependencies
✓ [PATCH RFC 25/32] watchdog: Kconfig: add HAS_IOPORT dependencies
✓ [PATCH RFC 26/32] drm: handle HAS_IOPORT dependencies
✓ [PATCH RFC 27/32] PCI/sysfs: make I/O resource depend on HAS_IOPORT
✓ [PATCH RFC 28/32] PCI: make quirk using inw() depend on HAS_IOPORT
✓ [PATCH RFC 29/32] firmware: dmi-sysfs: handle HAS_IOPORT dependencies
✓ [PATCH RFC 30/32] /dev/port: don't compile file operations without CONFIG_DEVPORT
✓ [PATCH RFC 31/32] usb: handle HAS_IOPORT dependencies
✓ [PATCH RFC 32/32] asm-generic/io.h: drop inb() etc for HAS_IOPORT=n
---
✓ Signed: DKIM/ibm.com (From: schnelle@linux.ibm.com)
---
Total patches: 32
---
Cover: m/20211227_schnelle_kconfig_introduce_has_ioport_and_legacy_pci_options.cover
Link: https://lore.kernel.org/r/20211227164317.4146918-1-schnelle@linux.ibm.com
Base: not specified
git am m/20211227_schnelle_kconfig_introduce_has_ioport_and_legacy_pci_options.mbx
10:30:32 ~/linux (wip/niklas)$ git am m/20211227_schnelle_kconfig_introduce_has_ioport_and_legacy_pci_options.mbx
Applying: Kconfig: introduce and depend on LEGACY_PCI
Applying: Kconfig: introduce HAS_IOPORT option and select it as necessary
Applying: ACPI: Kconfig: add HAS_IOPORT dependencies
Applying: parport: PC style parport depends on HAS_IOPORT
Applying: char: impi, tpm: depend on HAS_IOPORT
.git/rebase-apply/patch:92: trailing whitespace.
If you have a TPM security chip from Atmel say Yes and it
.git/rebase-apply/patch:93: trailing whitespace.
will be accessible from within Linux. To compile this driver
warning: 2 lines add whitespace errors.
Applying: speakup: Kconfig: add HAS_IOPORT dependencies
Applying: Input: gameport: add ISA and HAS_IOPORT dependencies
Applying: comedi: Kconfig: add HAS_IOPORT dependencies
Applying: sound: Kconfig: add HAS_IOPORT dependencies
Applying: i2c: Kconfig: add HAS_IOPORT dependencies
Applying: Input: Kconfig: add HAS_IOPORT dependencies
Applying: iio: adc: Kconfig: add HAS_IOPORT dependencies
Applying: hwmon: Kconfig: add HAS_IOPORT dependencies
Applying: leds: Kconfig: add HAS_IOPORT dependencies
Applying: media: Kconfig: add HAS_IOPORT dependencies
Applying: misc: handle HAS_IOPORT dependencies
Applying: net: Kconfig: add HAS_IOPORT dependencies
Applying: pcmcia: Kconfig: add HAS_IOPORT dependencies
Applying: platform: Kconfig: add HAS_IOPORT dependencies
Applying: pnp: Kconfig: add HAS_IOPORT dependencies
Applying: power: Kconfig: add HAS_IOPORT dependencies
Applying: video: handle HAS_IOPORT dependencies
.git/rebase-apply/patch:23: trailing whitespace.
warning: 1 line adds whitespace errors.
Applying: rtc: Kconfig: add HAS_IOPORT dependencies
Applying: scsi: Kconfig: add HAS_IOPORT dependencies
Applying: watchdog: Kconfig: add HAS_IOPORT dependencies
Applying: drm: handle HAS_IOPORT dependencies
Applying: PCI/sysfs: make I/O resource depend on HAS_IOPORT
Applying: PCI: make quirk using inw() depend on HAS_IOPORT
Applying: firmware: dmi-sysfs: handle HAS_IOPORT dependencies
Applying: /dev/port: don't compile file operations without CONFIG_DEVPORT
Applying: usb: handle HAS_IOPORT dependencies
Applying: asm-generic/io.h: drop inb() etc for HAS_IOPORT=n
10:30:55 ~/linux (wip/niklas)$
next prev parent reply other threads:[~2021-12-28 16:35 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-27 16:42 [RFC 00/32] Kconfig: Introduce HAS_IOPORT and LEGACY_PCI options Niklas Schnelle
2021-12-27 16:42 ` [RFC 01/32] Kconfig: introduce and depend on LEGACY_PCI Niklas Schnelle
2021-12-27 17:48 ` Guenter Roeck
2021-12-28 2:09 ` Mauro Carvalho Chehab
2021-12-28 8:21 ` Greg Kroah-Hartman
2021-12-28 9:15 ` Mauro Carvalho Chehab
2021-12-28 10:58 ` Niklas Schnelle
2021-12-28 12:01 ` Greg Kroah-Hartman
2021-12-28 12:54 ` Mauro Carvalho Chehab
2021-12-28 15:06 ` Niklas Schnelle
2021-12-28 17:12 ` Mauro Carvalho Chehab
2021-12-29 11:45 ` Niklas Schnelle
2021-12-29 12:12 ` Mauro Carvalho Chehab
2021-12-29 16:03 ` Bjorn Helgaas
2021-12-29 16:55 ` Niklas Schnelle
2022-01-05 17:42 ` John Garry
2022-01-05 19:47 ` Bjorn Helgaas
2022-01-06 17:41 ` John Garry
2022-01-06 18:14 ` Bjorn Helgaas
2022-01-07 17:16 ` John Garry
2022-01-10 9:34 ` Niklas Schnelle
2021-12-27 16:42 ` [RFC 02/32] Kconfig: introduce HAS_IOPORT option and select it as necessary Niklas Schnelle
2021-12-28 10:08 ` Geert Uytterhoeven
2021-12-29 1:20 ` Michael Schmitz
2021-12-29 3:41 ` Arnd Bergmann
2021-12-29 4:15 ` Michael Schmitz
2021-12-30 1:48 ` Arnd Bergmann
2021-12-30 3:44 ` Michael Schmitz
2021-12-31 11:28 ` Niklas Schnelle
2021-12-31 16:04 ` Arnd Bergmann
2021-12-31 21:55 ` Michael Schmitz
2021-12-28 16:32 ` Mauro Carvalho Chehab
2021-12-27 16:42 ` [RFC 03/32] ACPI: Kconfig: add HAS_IOPORT dependencies Niklas Schnelle
2021-12-27 16:47 ` Rafael J. Wysocki
2021-12-27 17:02 ` Niklas Schnelle
2021-12-27 17:12 ` Rafael J. Wysocki
2021-12-27 17:15 ` Rafael J. Wysocki
2021-12-27 17:43 ` Niklas Schnelle
2021-12-28 15:20 ` Rafael J. Wysocki
2021-12-28 16:31 ` Niklas Schnelle
2021-12-27 16:42 ` [RFC 04/32] parport: PC style parport depends on HAS_IOPORT Niklas Schnelle
2021-12-28 10:14 ` Geert Uytterhoeven
2021-12-28 14:21 ` Niklas Schnelle
2021-12-29 2:58 ` Arnd Bergmann
2021-12-27 16:42 ` [RFC 05/32] char: impi, tpm: depend " Niklas Schnelle
2021-12-28 10:17 ` Geert Uytterhoeven
2021-12-28 12:13 ` Niklas Schnelle
2021-12-27 16:42 ` [RFC 06/32] speakup: Kconfig: add HAS_IOPORT dependencies Niklas Schnelle
2021-12-27 17:52 ` Samuel Thibault
2021-12-27 16:42 ` [RFC 07/32] Input: gameport: add ISA and " Niklas Schnelle
2021-12-27 16:42 ` [RFC 08/32] comedi: Kconfig: add " Niklas Schnelle
2021-12-27 16:42 ` [RFC 09/32] sound: " Niklas Schnelle
2021-12-27 16:42 ` [RFC 10/32] i2c: " Niklas Schnelle
2021-12-28 10:21 ` Geert Uytterhoeven
2021-12-28 12:13 ` Niklas Schnelle
2021-12-27 16:42 ` [RFC 11/32] Input: " Niklas Schnelle
2021-12-28 10:23 ` Geert Uytterhoeven
2021-12-27 16:42 ` [RFC 12/32] iio: adc: " Niklas Schnelle
2021-12-28 10:32 ` Geert Uytterhoeven
2021-12-28 12:50 ` Niklas Schnelle
2021-12-28 17:01 ` Jonathan Cameron
2022-01-30 15:05 ` Jonathan Cameron
2021-12-27 16:42 ` [RFC 13/32] hwmon: " Niklas Schnelle
2021-12-27 18:07 ` Guenter Roeck
2021-12-27 16:42 ` [RFC 14/32] leds: " Niklas Schnelle
2021-12-27 16:43 ` [RFC 15/32] media: " Niklas Schnelle
2021-12-27 16:43 ` [RFC 16/32] misc: handle " Niklas Schnelle
2021-12-28 8:15 ` Greg Kroah-Hartman
2021-12-27 16:43 ` [RFC 17/32] net: Kconfig: add " Niklas Schnelle
2021-12-27 17:28 ` Marc Kleine-Budde
2021-12-27 16:43 ` [RFC 18/32] pcmcia: " Niklas Schnelle
2021-12-27 18:41 ` Dominik Brodowski
2021-12-27 16:43 ` [RFC 19/32] platform: " Niklas Schnelle
2021-12-27 16:43 ` [RFC 20/32] pnp: " Niklas Schnelle
2021-12-27 16:43 ` [RFC 21/32] power: " Niklas Schnelle
2021-12-27 16:43 ` [RFC 22/32] video: handle " Niklas Schnelle
2021-12-27 16:43 ` [RFC 23/32] rtc: Kconfig: add " Niklas Schnelle
2021-12-27 16:43 ` [RFC 24/32] scsi: " Niklas Schnelle
2021-12-28 10:40 ` Geert Uytterhoeven
2021-12-27 16:43 ` [RFC 25/32] watchdog: " Niklas Schnelle
2021-12-27 18:03 ` Guenter Roeck
2021-12-28 9:58 ` Niklas Schnelle
2021-12-27 16:43 ` [RFC 26/32] drm: handle " Niklas Schnelle
2022-01-03 6:11 ` Gerd Hoffmann
2021-12-27 16:43 ` [RFC 27/32] PCI/sysfs: make I/O resource depend on HAS_IOPORT Niklas Schnelle
2021-12-27 22:04 ` Bjorn Helgaas
2021-12-27 16:43 ` [RFC 28/32] PCI: make quirk using inw() " Niklas Schnelle
2021-12-27 22:33 ` Bjorn Helgaas
2021-12-28 15:25 ` Niklas Schnelle
2021-12-28 16:35 ` Bjorn Helgaas [this message]
2021-12-28 16:52 ` Niklas Schnelle
2021-12-28 17:28 ` Bjorn Helgaas
2021-12-27 16:43 ` [RFC 29/32] firmware: dmi-sysfs: handle HAS_IOPORT dependencies Niklas Schnelle
2021-12-27 16:43 ` [RFC 30/32] /dev/port: don't compile file operations without CONFIG_DEVPORT Niklas Schnelle
2021-12-28 8:17 ` Greg Kroah-Hartman
2021-12-29 10:25 ` Niklas Schnelle
2021-12-29 10:38 ` Greg Kroah-Hartman
2021-12-30 16:19 ` Arnd Bergmann
2021-12-27 16:43 ` [RFC 31/32] usb: handle HAS_IOPORT dependencies Niklas Schnelle
2021-12-27 20:36 ` Alan Stern
2021-12-31 11:06 ` Niklas Schnelle
2021-12-31 17:15 ` Alan Stern
2022-01-03 11:35 ` Niklas Schnelle
2022-01-03 16:15 ` Alan Stern
2021-12-27 16:43 ` [RFC 32/32] asm-generic/io.h: drop inb() etc for HAS_IOPORT=n Niklas Schnelle
2022-01-06 17:45 ` [RFC 00/32] Kconfig: Introduce HAS_IOPORT and LEGACY_PCI options John Garry
2022-01-07 7:21 ` Niklas Schnelle
2022-01-07 16:57 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211228163541.GA1599602@bhelgaas \
--to=helgaas@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@kernel.org \
--cc=bhelgaas@google.com \
--cc=deanbo422@gmail.com \
--cc=green.hu@gmail.com \
--cc=guoren@kernel.org \
--cc=john.garry@huawei.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=nickhu@andestech.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).