From: "Rob Herring (Arm)" <robh@kernel.org>
To: Bjorn Andersson <andersson@kernel.org>
Cc: linux-kernel@vger.kernel.org, quic_nankam@quicinc.com,
linux-arm-msm@vger.kernel.org, quic_abhinavk@quicinc.com,
konrad.dybcio@linaro.org,
Prahlad Valluru <quic_vvalluru@quicinc.com>,
conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: qcs6490-rb3gen2: enable hdmi bridge
Date: Wed, 08 May 2024 09:31:24 -0500 [thread overview]
Message-ID: <171517823376.1753082.4070659246393696781.robh@kernel.org> (raw)
In-Reply-To: <jr3ble6sxr5mr6cvm6ldvpyk5j4rucj3xy6vbha6ttoecte3d7@llu6qf6oasuc>
On Mon, 06 May 2024 18:14:10 -0500, Bjorn Andersson wrote:
> On Fri, Apr 26, 2024 at 07:54:42PM GMT, Prahlad Valluru wrote:
> > From: Venkata Prahlad Valluru <quic_vvalluru@quicinc.com>
> >
>
> Please don't thread new versions off existing version. b4 helps you with
> getting these things right, please check go/upstream for more details.
>
> > Enable lt9611uxc bridge for qcs6490 rb3 gen2 platform.
> >
>
> Even if it's clear what this is, I would prefer if you described the
> hardware a little bit in your commit message.
> "Rb3Gen2 has a HDMI connector, connected to DSI via a LT on i2cX.... reset and
> irq pins comes from x and y. Describe this."
>
> > Signed-off-by: Prahlad Valluru <quic_vvalluru@quicinc.com>
> > ---
> > v2: Addressed dtschema errors
> > - Fixed lt9611-irq
> > - vdd-supply error to be ignored, as it is connected to
> > input supply directly, on rb3gen2
The choice is either fix the dts or fix the binding.
> > ---
> > arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 86 ++++++++++++++++++++
> > 1 file changed, 86 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> > index a085ff5b5fb2..c14d4a4bb3ce 100644
> > --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> > +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> > @@ -51,6 +51,18 @@
> > };
> > };
> > };
> > +
>
> There's a stray tab here, please run checkpatch --strict on your
> patches.
>
> > + hdmi-connector {
> > + compatible = "hdmi-connector";
> > + label = "HDMI";
> > + type = "a";
> > +
> > + port {
> > + hdmi_con: endpoint {
> > + remote-endpoint = <<9611_out>;
> > + };
> > + };
> > + };
> >
> > reserved-memory {
> > xbl_mem: xbl@80700000 {
> > @@ -530,6 +542,45 @@
> [..]
> > @@ -602,6 +653,21 @@
> > status = "okay";
> > };
> >
> > +&mdss_dsi {
>
> We want to keep nodes sorted (by address if applicable, otherwise
> alphabetically on node names and on labels). "mdss_dsi" < "mdss_edp".
>
> So please move this up where it belongs.
>
> > + vdda-supply = <&vreg_l6b_1p2>;
> > + status = "okay";
> > +};
> > +
> > +&mdss_dsi0_out {
> > + remote-endpoint = <<9611_a>;
> > + data-lanes = <0 1 2 3>;
> > +};
> > +
> > +&mdss_dsi_phy {
> > + vdds-supply = <&vreg_l10c_0p88>;
> > + status = "okay";
> > +};
> > +
> > &qupv3_id_0 {
> > status = "okay";
> > };
> > @@ -711,3 +777,23 @@
> > function = "gpio";
> > bias-disable;
> > };
> > +
> > +&pm7250b_gpios {
> > + lt9611_rst_pin: lt9611-rst-state {
> > + pins = "gpio2";
> > + function = "normal";
> > +
> > + output-high;
> > + input-disable;
> > + power-source = <0>;
> > + };
> > +};
> > +
> > +&tlmm {
> > + lt9611_irq_pin: lt9611-irq-state {
> > + pins = "gpio24";
> > + function = "gpio";
> > + drive-strength = <8>;
>
> I'd expect a 2 here, so please document why this is 8.
>
> Regards,
> Bjorn
>
> > + bias-disable;
> > + };
> > +};
> > --
> > 2.17.1
> >
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y qcom/qcs6490-rb3gen2.dtb' for jr3ble6sxr5mr6cvm6ldvpyk5j4rucj3xy6vbha6ttoecte3d7@llu6qf6oasuc:
arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: hdmi-bridge@2b: 'vdd-supply' is a required property
from schema $id: http://devicetree.org/schemas/display/bridge/lontium,lt9611.yaml#
next prev parent reply other threads:[~2024-05-08 14:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 7:13 [PATCH] arm64: dts: qcom: qcs6490-rb3gen2: enable hdmi bridge Venkata Prahlad Valluru
2024-04-25 14:51 ` Rob Herring
2024-04-26 14:24 ` [PATCH v2] " Prahlad Valluru
2024-05-06 19:54 ` Abhinav Kumar
2024-05-06 23:14 ` Bjorn Andersson
2024-05-07 16:30 ` [PATCH v3] " Venkata Prahlad Valluru
2024-05-07 16:35 ` Krzysztof Kozlowski
2024-05-07 19:20 ` Abhinav Kumar
2024-05-08 7:38 ` Krzysztof Kozlowski
2024-05-08 8:13 ` Dmitry Baryshkov
2024-05-09 8:31 ` Krzysztof Kozlowski
2024-05-08 10:26 ` Prahlad Valluru
2024-05-07 18:43 ` Abhinav Kumar
2024-05-08 10:22 ` [PATCH v2] " Prahlad Valluru
2024-05-08 10:47 ` Dmitry Baryshkov
2024-05-08 14:31 ` Rob Herring (Arm) [this message]
2024-05-15 15:04 ` Prahlad Valluru
2024-05-15 15:28 ` Dmitry Baryshkov
2024-05-28 14:11 ` Prahlad Valluru
2024-05-28 14:19 ` [PATCH v4] " Venkata Prahlad Valluru
2024-05-28 15:00 ` Dmitry Baryshkov
2024-05-28 16:24 ` Prahlad Valluru
2024-05-28 16:33 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171517823376.1753082.4070659246393696781.robh@kernel.org \
--to=robh@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_nankam@quicinc.com \
--cc=quic_vvalluru@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).