From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Abhinav Kumar <quic_abhinavk@quicinc.com>,
Venkata Prahlad Valluru <quic_vvalluru@quicinc.com>,
andersson@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, konrad.dybcio@linaro.org,
krzysztof.kozlowski+dt@linaro.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_nankam@quicinc.com, robh@kernel.org
Subject: Re: [PATCH v3] arm64: dts: qcom: qcs6490-rb3gen2: enable hdmi bridge
Date: Wed, 8 May 2024 11:13:02 +0300 [thread overview]
Message-ID: <CAA8EJpqG7k2+eEyndzrGgF4YqSOhD-kKfaj93PLhitcku1B6tw@mail.gmail.com> (raw)
In-Reply-To: <2f810036-1832-42ef-b896-e9470f469029@linaro.org>
On Wed, 8 May 2024 at 10:38, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 07/05/2024 21:20, Abhinav Kumar wrote:
> >
> >
> > On 5/7/2024 9:35 AM, Krzysztof Kozlowski wrote:
> >> On 07/05/2024 18:30, Venkata Prahlad Valluru wrote:
> >>> Rb3Gen2 has a lt9611uxc DSI-to-HDMI bridge on i2c0, with
> >>> reset gpio from pm7250b gpio2 and irq gpio from tlmm gpio24.
> >>> Bridge supplies are Vdd connected to input supply directly
> >>> and vcc to L11c. Enable HDMI output, bridge and corresponding
> >>> DSI output.
> >>>
> >>> Signed-off-by: Venkata Prahlad Valluru <quic_vvalluru@quicinc.com>
> >>> ---
> >>> v3: - Updated commit text
> >>> - Arranged nodes in alphabetical order
> >>> - Fixed signoff
> >>> - Fixed drive strength for lt9611_irq_pin
> >>> - Removed 'label' from hdmi-connector, which is optional
> >>
> >> Please respond to each Bjorn comment and explain how did you implement it...
> >>
> >
> > Yes, agreed. Even though it seems like you mostly just agreed to mine
> > and Bjorn's suggestions and decided to implement all those in v3 , it
> > would have been better to explicitly ack them or tell why you agreed or
> > what went wrong that you had not done it in v2 itself to close the loop.
>
> The problem is that one or more were ignored... By responding to each of
> them, I hope they will be finally read and understood instead of
> repeating the same mistake three times.
I found a mistake that was repeated two times. This leaves me
wondering which mistake was repeated three times.
--
With best wishes
Dmitry
next prev parent reply other threads:[~2024-05-08 8:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 7:13 [PATCH] arm64: dts: qcom: qcs6490-rb3gen2: enable hdmi bridge Venkata Prahlad Valluru
2024-04-25 14:51 ` Rob Herring
2024-04-26 14:24 ` [PATCH v2] " Prahlad Valluru
2024-05-06 19:54 ` Abhinav Kumar
2024-05-06 23:14 ` Bjorn Andersson
2024-05-07 16:30 ` [PATCH v3] " Venkata Prahlad Valluru
2024-05-07 16:35 ` Krzysztof Kozlowski
2024-05-07 19:20 ` Abhinav Kumar
2024-05-08 7:38 ` Krzysztof Kozlowski
2024-05-08 8:13 ` Dmitry Baryshkov [this message]
2024-05-09 8:31 ` Krzysztof Kozlowski
2024-05-08 10:26 ` Prahlad Valluru
2024-05-07 18:43 ` Abhinav Kumar
2024-05-08 10:22 ` [PATCH v2] " Prahlad Valluru
2024-05-08 10:47 ` Dmitry Baryshkov
2024-05-08 14:31 ` Rob Herring (Arm)
2024-05-15 15:04 ` Prahlad Valluru
2024-05-15 15:28 ` Dmitry Baryshkov
2024-05-28 14:11 ` Prahlad Valluru
2024-05-28 14:19 ` [PATCH v4] " Venkata Prahlad Valluru
2024-05-28 15:00 ` Dmitry Baryshkov
2024-05-28 16:24 ` Prahlad Valluru
2024-05-28 16:33 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA8EJpqG7k2+eEyndzrGgF4YqSOhD-kKfaj93PLhitcku1B6tw@mail.gmail.com \
--to=dmitry.baryshkov@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_nankam@quicinc.com \
--cc=quic_vvalluru@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).