From: Matthew Wilcox <willy@infradead.org>
To: Mike Marshall <hubcap@omnibond.com>
Cc: David Howells <dhowells@redhat.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [RFC PATCH v2] implement orangefs_readahead
Date: Fri, 16 Apr 2021 16:14:05 +0100 [thread overview]
Message-ID: <20210416151405.GK2531743@casper.infradead.org> (raw)
In-Reply-To: <CAOg9mSSxZUwZ0-OdCfb7gLgETkCJOd-9PCrpqWwzqXffwMSejA@mail.gmail.com>
On Fri, Apr 16, 2021 at 10:36:52AM -0400, Mike Marshall wrote:
> So... I think all your stuff is working well from my perspective
> and that I need to figure out why my orangefs_readahead patch
> is causing the regressions I listed. My readahead implementation (via your
> readahead_expand) is really fast, but it is bare-bones... I'm probably
> leaving out some important stuff... I see other filesystem's
> readahead implementations doing stuff like avoiding doing readahead
> on pages that have yet to be written back for example.
You do?! Actual readahead implementations, or people still implementing
the old ->readpages() method? The ->readahead() method is _only_ called
for pages which are freshly allocated, Locked and !Uptodate. If you ever
see a page which is Dirty or Writeback, something has gone very wrong.
Could you tell me which filesystem you saw that bogosity in?
> The top two commits at https://github.com/hubcapsc/linux/tree/readahead_v3
> is the current state of my readahead implementation.
>
> Please do add
> Tested-by: Mike Marshall <hubcap@omnibond.com>
>
> -Mike
>
> On Tue, Apr 13, 2021 at 11:08 AM David Howells <dhowells@redhat.com> wrote:
> >
> > Mike Marshall <hubcap@omnibond.com> wrote:
> >
> > > Hi David... I've been gone on a motorcycle adventure,
> > > sorry for the delay... here's my public branch...
> > >
> > > https://github.com/hubcapsc/linux/tree/readahead_v3
> >
> > That seems to have all of my fscache-iter branch in it. I thought you'd said
> > you'd dropped them because they were causing problems.
> >
> > Anyway, I've distilled the basic netfs lib patches, including the readahead
> > expansion patch and ITER_XARRAY patch here:
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=netfs-lib
> >
> > if that's of use to you?
> >
> > If you're using any of these patches, would it be possible to get a Tested-by
> > for them that I can add?
> >
> > David
> >
next prev parent reply other threads:[~2021-04-16 15:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-31 22:25 [RFC PATCH] implement orangefs_readahead Mike Marshall
2021-02-01 13:08 ` Matthew Wilcox
2021-02-02 3:32 ` Mike Marshall
2021-03-13 15:31 ` [RFC PATCH v2] " Mike Marshall
2021-03-17 3:04 ` Mike Marshall
2021-03-24 11:10 ` David Howells
2021-03-27 2:55 ` Mike Marshall
2021-03-27 3:50 ` Matthew Wilcox
2021-03-27 8:31 ` David Howells
2021-03-27 13:56 ` Matthew Wilcox
2021-03-27 15:40 ` Mike Marshall
2021-03-27 15:56 ` Matthew Wilcox
2021-03-28 3:04 ` Mike Marshall
2021-03-29 1:51 ` Mike Marshall
2021-03-29 9:37 ` David Howells
2021-03-29 23:25 ` Mike Marshall
[not found] ` <3726695.1617284551@warthog.procyon.org.uk >
2021-04-13 15:08 ` David Howells
2021-04-16 14:36 ` Mike Marshall
2021-04-16 15:14 ` Matthew Wilcox [this message]
2021-04-25 1:51 ` Mike Marshall
2021-04-16 15:41 ` David Howells
2021-04-25 1:43 ` Mike Marshall
2021-04-25 7:49 ` David Howells
2021-04-26 14:53 ` Mike Marshall
2021-04-26 19:01 ` Mike Marshall
2021-04-26 20:01 ` David Howells
2021-04-26 8:37 ` David Howells
2021-04-01 13:42 ` David Howells
2021-04-08 20:39 ` Mike Marshall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210416151405.GK2531743@casper.infradead.org \
--to=willy@infradead.org \
--cc=dhowells@redhat.com \
--cc=hubcap@omnibond.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).