From: Siddharth Vadapalli <s-vadapalli@ti.com>
To: Thomas Richard <thomas.richard@bootlin.com>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Andy Shevchenko" <andy@kernel.org>,
"Tony Lindgren" <tony@atomide.com>,
"Haojian Zhuang" <haojian.zhuang@linaro.org>,
"Vignesh R" <vigneshr@ti.com>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Janusz Krzysztofik" <jmkrzyszt@gmail.com>,
"Andi Shyti" <andi.shyti@kernel.org>,
"Peter Rosin" <peda@axentia.se>, "Vinod Koul" <vkoul@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org,
linux-pci@vger.kernel.org, gregory.clement@bootlin.com,
theo.lebrun@bootlin.com, thomas.petazzoni@bootlin.com,
u-kumar1@ti.com, s-vadapalli@ti.com
Subject: Re: [PATCH v4 18/18] PCI: j721e: Add suspend and resume support
Date: Wed, 13 Mar 2024 12:21:09 +0530 [thread overview]
Message-ID: <e4fc0b47-6a7f-4cc5-bb69-77655f775486@ti.com> (raw)
In-Reply-To: <20240102-j7200-pcie-s2r-v4-18-6f1f53390c85@bootlin.com>
On Mon, Mar 04, 2024 at 04:36:01PM +0100, Thomas Richard wrote:
> From: Théo Lebrun <theo.lebrun@bootlin.com>
>
> Add suspend and resume support. Only the rc mode is supported.
>
> During the suspend stage PERST# is asserted, then deasserted during the
> resume stage.
>
> Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
> Signed-off-by: Thomas Richard <thomas.richard@bootlin.com>
Reviewed-by: Siddharth Vadapalli <s-vadapalli@ti.com>
Regards,
Siddharth.
> ---
> drivers/pci/controller/cadence/pci-j721e.c | 86 ++++++++++++++++++++++++++++++
> 1 file changed, 86 insertions(+)
>
> diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/controller/cadence/pci-j721e.c
> index 9af4fd64c1f9..a1f1232e8ee5 100644
> --- a/drivers/pci/controller/cadence/pci-j721e.c
> +++ b/drivers/pci/controller/cadence/pci-j721e.c
> @@ -7,6 +7,8 @@
> */
>
> #include <linux/clk.h>
> +#include <linux/clk-provider.h>
> +#include <linux/container_of.h>
> #include <linux/delay.h>
> #include <linux/gpio/consumer.h>
> #include <linux/io.h>
> @@ -22,6 +24,8 @@
> #include "../../pci.h"
> #include "pcie-cadence.h"
>
> +#define cdns_pcie_to_rc(p) container_of(p, struct cdns_pcie_rc, pcie)
> +
> #define ENABLE_REG_SYS_2 0x108
> #define STATUS_REG_SYS_2 0x508
> #define STATUS_CLR_REG_SYS_2 0x708
> @@ -588,6 +592,87 @@ static void j721e_pcie_remove(struct platform_device *pdev)
> pm_runtime_disable(dev);
> }
>
> +static int j721e_pcie_suspend_noirq(struct device *dev)
> +{
> + struct j721e_pcie *pcie = dev_get_drvdata(dev);
> +
> + if (pcie->mode == PCI_MODE_RC) {
> + gpiod_set_value_cansleep(pcie->reset_gpio, 0);
> + clk_disable_unprepare(pcie->refclk);
> + }
> +
> + cdns_pcie_disable_phy(pcie->cdns_pcie);
> +
> + return 0;
> +}
> +
> +static int j721e_pcie_resume_noirq(struct device *dev)
> +{
> + struct j721e_pcie *pcie = dev_get_drvdata(dev);
> + struct cdns_pcie *cdns_pcie = pcie->cdns_pcie;
> + int ret;
> +
> + ret = j721e_pcie_ctrl_init(pcie);
> + if (ret < 0)
> + return ret;
> +
> + j721e_pcie_config_link_irq(pcie);
> +
> + /*
> + * This is not called explicitly in the probe, it is called by
> + * cdns_pcie_init_phy().
> + */
> + ret = cdns_pcie_enable_phy(pcie->cdns_pcie);
> + if (ret < 0)
> + return ret;
> +
> + if (pcie->mode == PCI_MODE_RC) {
> + struct cdns_pcie_rc *rc = cdns_pcie_to_rc(cdns_pcie);
> +
> + ret = clk_prepare_enable(pcie->refclk);
> + if (ret < 0)
> + return ret;
> +
> + /*
> + * "Power Sequencing and Reset Signal Timings" table in
> + * PCI EXPRESS CARD ELECTROMECHANICAL SPECIFICATION, REV. 3.0
> + * indicates PERST# should be deasserted after minimum of 100us
> + * once REFCLK is stable. The REFCLK to the connector in RC
> + * mode is selected while enabling the PHY. So deassert PERST#
> + * after 100 us.
> + */
> + if (pcie->reset_gpio) {
> + fsleep(100);
> + gpiod_set_value_cansleep(pcie->reset_gpio, 1);
> + }
> +
> + ret = cdns_pcie_host_link_setup(rc);
> + if (ret < 0) {
> + clk_disable_unprepare(pcie->refclk);
> + return ret;
> + }
> +
> + /*
> + * Reset internal status of BARs to force reinitialization in
> + * cdns_pcie_host_init().
> + */
> + for (enum cdns_pcie_rp_bar bar = RP_BAR0; bar <= RP_NO_BAR; bar++)
> + rc->avail_ib_bar[bar] = true;
> +
> + ret = cdns_pcie_host_init(rc);
> + if (ret) {
> + clk_disable_unprepare(pcie->refclk);
> + return ret;
> + }
> + }
> +
> + return 0;
> +}
> +
> +static DEFINE_NOIRQ_DEV_PM_OPS(j721e_pcie_pm_ops,
> + j721e_pcie_suspend_noirq,
> + j721e_pcie_resume_noirq);
> +
> static struct platform_driver j721e_pcie_driver = {
> .probe = j721e_pcie_probe,
> .remove_new = j721e_pcie_remove,
> @@ -595,6 +680,7 @@ static struct platform_driver j721e_pcie_driver = {
> .name = "j721e-pcie",
> .of_match_table = of_j721e_pcie_match,
> .suppress_bind_attrs = true,
> + .pm = pm_sleep_ptr(&j721e_pcie_pm_ops),
> },
> };
> builtin_platform_driver(j721e_pcie_driver);
>
> --
> 2.39.2
>
>
next prev parent reply other threads:[~2024-03-13 6:51 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 15:35 [PATCH v4 00/18] Add suspend to ram support for PCIe on J7200 Thomas Richard
2024-03-04 15:35 ` [PATCH v4 01/18] gpio: pca953x: move suspend()/resume() to suspend_noirq()/resume_noirq() Thomas Richard
2024-03-04 15:35 ` [PATCH v4 02/18] pinctrl: pinctrl-single: move suspend()/resume() callbacks to noirq Thomas Richard
2024-03-08 8:39 ` Tony Lindgren
2024-03-20 7:44 ` Dhruva Gole
2024-03-20 8:37 ` Thomas Richard
2024-03-28 21:07 ` Linus Walleij
2024-03-04 15:35 ` [PATCH v4 03/18] i2c: omap: wakeup the controller during suspend() callback Thomas Richard
2024-03-08 8:42 ` Tony Lindgren
2024-03-12 8:03 ` Wolfram Sang
2024-03-13 0:48 ` Andi Shyti
2024-03-13 6:21 ` Wolfram Sang
2024-03-13 0:37 ` Andi Shyti
2024-03-04 15:35 ` [PATCH v4 04/18] mux: add mux_chip_resume() function Thomas Richard
2024-03-04 15:35 ` [PATCH v4 05/18] mux: mmio: add resume support Thomas Richard
2024-03-04 15:35 ` [PATCH v4 06/18] phy: ti: phy-j721e-wiz: use dev_err_probe() instead of dev_err() Thomas Richard
2024-03-04 15:35 ` [PATCH v4 07/18] phy: ti: phy-j721e-wiz: split wiz_clock_init() function Thomas Richard
2024-04-05 16:42 ` Vinod Koul
2024-03-04 15:35 ` [PATCH v4 08/18] phy: ti: phy-j721e-wiz: add resume support Thomas Richard
2024-04-05 16:44 ` Vinod Koul
2024-04-05 17:14 ` Andy Shevchenko
2024-03-04 15:35 ` [PATCH v4 09/18] phy: cadence-torrent: extract calls to clk_get from cdns_torrent_clk Thomas Richard
2024-03-04 15:35 ` [PATCH v4 10/18] phy: cadence-torrent: register resets even if the phy is already configured Thomas Richard
2024-03-04 15:35 ` [PATCH v4 11/18] phy: cadence-torrent: add already_configured to struct cdns_torrent_phy Thomas Richard
2024-03-04 15:35 ` [PATCH v4 12/18] phy: cadence-torrent: remove noop_ops phy operations Thomas Richard
2024-03-04 15:35 ` [PATCH v4 13/18] phy: cadence-torrent: add suspend and resume support Thomas Richard
2024-03-04 15:35 ` [PATCH v4 14/18] PCI: cadence: Extract link setup sequence from cdns_pcie_host_setup() Thomas Richard
2024-03-04 15:35 ` [PATCH v4 15/18] PCI: cadence: Set cdns_pcie_host_init() global Thomas Richard
2024-03-04 15:35 ` [PATCH v4 16/18] PCI: j721e: Use dev_err_probe() in the probe() function Thomas Richard
2024-04-10 7:51 ` Francesco Dolcini
2024-03-04 15:36 ` [PATCH v4 17/18] PCI: j721e: Add reset GPIO to struct j721e_pcie Thomas Richard
2024-03-04 15:36 ` [PATCH v4 18/18] PCI: j721e: Add suspend and resume support Thomas Richard
2024-03-13 6:51 ` Siddharth Vadapalli [this message]
2024-03-28 22:07 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4fc0b47-6a7f-4cc5-bb69-77655f775486@ti.com \
--to=s-vadapalli@ti.com \
--cc=aaro.koskinen@iki.fi \
--cc=andi.shyti@kernel.org \
--cc=andy@kernel.org \
--cc=bhelgaas@google.com \
--cc=brgl@bgdev.pl \
--cc=gregory.clement@bootlin.com \
--cc=haojian.zhuang@linaro.org \
--cc=jmkrzyszt@gmail.com \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=peda@axentia.se \
--cc=robh@kernel.org \
--cc=theo.lebrun@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=thomas.richard@bootlin.com \
--cc=tony@atomide.com \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).