From: Chanh Nguyen <chanh@amperemail.onmicrosoft.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Chanh Nguyen <chanh@os.amperecomputing.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Justin Ledford <justinledford@google.com>,
devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Open Source Submission <patches@amperecomputing.com>
Cc: Phong Vo <phong@os.amperecomputing.com>,
Thang Nguyen <thang@os.amperecomputing.com>,
Quan Nguyen <quan@os.amperecomputing.com>
Subject: Re: [PATCH 1/3] dt-bindings: hwmon: Add maxim max31790 driver bindings
Date: Tue, 26 Mar 2024 17:26:16 +0700 [thread overview]
Message-ID: <4bf7984f-5f94-408d-8098-dead1987db62@amperemail.onmicrosoft.com> (raw)
In-Reply-To: <c3f296d2-63b0-493e-a2cd-5010dea84adb@linaro.org>
On 25/03/2024 15:32, Krzysztof Kozlowski wrote:
> On 22/03/2024 10:53, Chanh Nguyen wrote:
>>>>>
>>>>
>>>> Hi Krzysztof,
>>>> I have not yet understood your comment here. Please help give more
>>>> details for my missing! Thank Krzysztof!
>>>
>>> I expect many more properties of a fan controller. Resources (clocks,
>>> PWMs, supplies) and FAN specific properties.
>>>
>>
>> Hi Krzysztof,
>>
>> I'm creating a base binding document for the max31790 driver. I'm basing
>> it on the drivers/hwmon/max31790.c. Currently, the max31790.c driver has
>
> Binding should be based on device (e.g. its datasheet), not the driver.
>
Thank Krzysztof,
I'm reading the writing-bindings.rst and I got it for now. I'll make
complete binding in patch v2.
I am very pleased to hear your comments.
>> not yet implemented other properties, such as clocks, fan-supply, pwms,
>> etc. So I just introduced the "compatible" and "reg" properties.
>>
>> In the near future, if any other properties are necessary, I think we
>> will implement them in drivers/hwmon/max31790.c then update this binding
>> document.
>
> Please instead read:
> Documentation/devicetree/bindings/writing-bindings.rst
>
>>
>> I look at other binding documents, I also see something similar. They
>> just introduce the "compatible" and "reg" properties.
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/hwmon/adi,max31760.yaml
>
> Maybe these devices are similar, maybe not. This should not be excuse to
> come with really incomplete binding.
>
> ...
>
>> I think "fan-controller" is a good node name. Do you think so?
>>
>
> Yes.
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2024-03-26 10:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 11:13 [PATCH 0/3] Update the max31790 driver Chanh Nguyen
2024-03-11 11:13 ` [PATCH 1/3] dt-bindings: hwmon: Add maxim max31790 driver bindings Chanh Nguyen
2024-03-11 16:55 ` Krzysztof Kozlowski
2024-03-18 9:51 ` Chanh Nguyen
2024-03-18 10:00 ` Krzysztof Kozlowski
2024-03-22 9:53 ` Chanh Nguyen
2024-03-25 8:32 ` Krzysztof Kozlowski
2024-03-26 10:26 ` Chanh Nguyen [this message]
2024-03-11 11:13 ` [PATCH 2/3] hwmon: (max31790): Support config PWM output becomes TACH Chanh Nguyen
2024-03-11 11:13 ` [PATCH 3/3] dt-bindings: hwmon: max31790: Add pwmout-pin-as-tach-input property Chanh Nguyen
2024-03-11 16:56 ` Krzysztof Kozlowski
2024-03-18 9:48 ` Chanh Nguyen
2024-03-18 10:02 ` Krzysztof Kozlowski
2024-03-18 16:50 ` Chanh Nguyen
2024-03-11 17:34 ` Rob Herring
2024-03-11 17:52 ` Guenter Roeck
2024-03-18 9:54 ` Chanh Nguyen
2024-03-18 9:53 ` Chanh Nguyen
2024-03-26 10:33 ` Chanh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bf7984f-5f94-408d-8098-dead1987db62@amperemail.onmicrosoft.com \
--to=chanh@amperemail.onmicrosoft.com \
--cc=chanh@os.amperecomputing.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=justinledford@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=openbmc@lists.ozlabs.org \
--cc=patches@amperecomputing.com \
--cc=phong@os.amperecomputing.com \
--cc=quan@os.amperecomputing.com \
--cc=robh+dt@kernel.org \
--cc=thang@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).