From: Chanh Nguyen <chanh@amperemail.onmicrosoft.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Chanh Nguyen <chanh@os.amperecomputing.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Justin Ledford <justinledford@google.com>,
devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Open Source Submission <patches@amperecomputing.com>
Cc: Phong Vo <phong@os.amperecomputing.com>,
Thang Nguyen <thang@os.amperecomputing.com>,
Quan Nguyen <quan@os.amperecomputing.com>
Subject: Re: [PATCH 3/3] dt-bindings: hwmon: max31790: Add pwmout-pin-as-tach-input property
Date: Mon, 18 Mar 2024 23:50:37 +0700 [thread overview]
Message-ID: <e7ae980c-8408-46e3-909d-29b3d7e1e050@amperemail.onmicrosoft.com> (raw)
In-Reply-To: <7252305b-4c7c-4cec-8ef1-8bf96293b469@linaro.org>
On 18/03/2024 17:02, Krzysztof Kozlowski wrote:
> On 18/03/2024 10:48, Chanh Nguyen wrote:
>>
>>
>> On 11/03/2024 23:56, Krzysztof Kozlowski wrote:
>>> On 11/03/2024 12:13, Chanh Nguyen wrote:
>>>> Add pwmout-pin-as-tach-input property.
>>>
>>> Why is this split from original binding? This does not make much
>>> sense... Add complete hardware description.
>>>
>>
>> Ok Krzysztof, I will merg the "[PATCH 1/3] dt-bindings: hwmon: Add maxim
>> max31790 driver bindings" commit and "[PATCH 3/3] dt-bindings: hwmon:
>> max31790: Add pwmout-pin-as-tach-input property" commit.
>
> Later I checked your driver code and this explains a bit. However first
> patch should explain that instead. The split is fine, but just lack of
> rationale is confusing.
>
Thank Krzysztof. I'll try to explain in detail each patch in v2.
>
>>
>>>>
>>>> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
>>>> ---
>>>> Documentation/devicetree/bindings/hwmon/max31790.yaml | 11 +++++++++++
>>>> 1 file changed, 11 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/hwmon/max31790.yaml b/Documentation/devicetree/bindings/hwmon/max31790.yaml
>>>> index 5a93e6bdebda..447cac17053a 100644
>>>> --- a/Documentation/devicetree/bindings/hwmon/max31790.yaml
>>>> +++ b/Documentation/devicetree/bindings/hwmon/max31790.yaml
>>>> @@ -25,6 +25,16 @@ properties:
>>>> reg:
>>>> maxItems: 1
>>>>
>>>> + pwmout-pin-as-tach-input:
>>>> + description: |
>>>> + An array of six integers responds to six PWM channels for
>>>> + configuring the pwm to tach mode.
>>>> + When set to 0, the associated PWMOUT produces a PWM waveform for
>>>> + control of fan speed. When set to 1, PWMOUT becomes a TACH input
>>>
>>> No vendor prefix, so generic property... but where is it defined?
>>>
>>
>> Thank Krzysztof! It is not generic property, I'll add the vendor prefix.
>>
>> I'll update the "pwmout-pin-as-tach-input" to
>> "maxim,pwmout-pin-as-tach-input" at v2.
>
> Except that you should really look into common properties and use them.
> Or explain why do you need new property?
>
> Best regards,
> Krzysztof
>
I'm also discussing with Rob Herring that on patch 3/3, I checked in the
Documentation/devicetree/bindings/hwmon/fan-common.yaml. I found the
tach-ch property, but it seems to define the tach channel used for the
fan. It does not match my purpose. I want to configure the PWM-OUT pin
to become a TACH-IN pin. I wonder if I can use the tach-ch property for
my purpose.
next prev parent reply other threads:[~2024-03-18 16:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 11:13 [PATCH 0/3] Update the max31790 driver Chanh Nguyen
2024-03-11 11:13 ` [PATCH 1/3] dt-bindings: hwmon: Add maxim max31790 driver bindings Chanh Nguyen
2024-03-11 16:55 ` Krzysztof Kozlowski
2024-03-18 9:51 ` Chanh Nguyen
2024-03-18 10:00 ` Krzysztof Kozlowski
2024-03-22 9:53 ` Chanh Nguyen
2024-03-25 8:32 ` Krzysztof Kozlowski
2024-03-26 10:26 ` Chanh Nguyen
2024-03-11 11:13 ` [PATCH 2/3] hwmon: (max31790): Support config PWM output becomes TACH Chanh Nguyen
2024-03-11 11:13 ` [PATCH 3/3] dt-bindings: hwmon: max31790: Add pwmout-pin-as-tach-input property Chanh Nguyen
2024-03-11 16:56 ` Krzysztof Kozlowski
2024-03-18 9:48 ` Chanh Nguyen
2024-03-18 10:02 ` Krzysztof Kozlowski
2024-03-18 16:50 ` Chanh Nguyen [this message]
2024-03-11 17:34 ` Rob Herring
2024-03-11 17:52 ` Guenter Roeck
2024-03-18 9:54 ` Chanh Nguyen
2024-03-18 9:53 ` Chanh Nguyen
2024-03-26 10:33 ` Chanh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7ae980c-8408-46e3-909d-29b3d7e1e050@amperemail.onmicrosoft.com \
--to=chanh@amperemail.onmicrosoft.com \
--cc=chanh@os.amperecomputing.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=justinledford@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=openbmc@lists.ozlabs.org \
--cc=patches@amperecomputing.com \
--cc=phong@os.amperecomputing.com \
--cc=quan@os.amperecomputing.com \
--cc=robh+dt@kernel.org \
--cc=thang@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).