From: Guenter Roeck <linux@roeck-us.net>
To: Frank Crawford <frank@crawford.emu.id.au>
Cc: Jean Delvare <jdelvare@suse.com>, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v1 2/4] hwmon (it87): Do not enter configuration mode for some chip types
Date: Wed, 10 Apr 2024 08:12:16 -0700 [thread overview]
Message-ID: <a6eb2a95-d9a9-42f0-a50d-3034c694d977@roeck-us.net> (raw)
In-Reply-To: <20240401025620.205068-3-frank@crawford.emu.id.au>
On Mon, Apr 01, 2024 at 01:56:04PM +1100, Frank Crawford wrote:
> Update the configuration mode entry code to allow conditional entry, and
> apply to all calls.
>
This is just as wrong as the previous patch. Any such option
would have to be board specific, not chip specific.
Guenter
> Signed-off-by: Frank Crawford <frank@crawford.emu.id.au>
> ---
> drivers/hwmon/it87.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c
> index 6eeba3a01e3c..396c2d3afbf7 100644
> --- a/drivers/hwmon/it87.c
> +++ b/drivers/hwmon/it87.c
> @@ -117,7 +117,7 @@ static inline void superio_select(int ioreg, int ldn)
> outb(ldn, ioreg + 1);
> }
>
> -static inline int superio_enter(int ioreg)
> +static inline int superio_enter(int ioreg, bool noentry)
> {
> /*
> * Try to reserve ioreg and ioreg + 1 for exclusive access.
> @@ -125,7 +125,8 @@ static inline int superio_enter(int ioreg)
> if (!request_muxed_region(ioreg, 2, DRVNAME))
> return -EBUSY;
>
> - __superio_enter(ioreg);
> + if (!noentry)
> + __superio_enter(ioreg);
> return 0;
> }
>
> @@ -742,7 +743,7 @@ static int smbus_disable(struct it87_data *data)
> int err;
>
> if (data->smbus_bitmap) {
> - err = superio_enter(data->sioaddr);
> + err = superio_enter(data->sioaddr, has_conf_biosopen(data));
> if (err)
> return err;
> superio_select(data->sioaddr, PME);
> @@ -758,7 +759,7 @@ static int smbus_enable(struct it87_data *data)
> int err;
>
> if (data->smbus_bitmap) {
> - err = superio_enter(data->sioaddr);
> + err = superio_enter(data->sioaddr, has_conf_biosopen(data));
> if (err)
> return err;
>
> @@ -2674,7 +2675,7 @@ static int __init it87_find(int sioaddr, unsigned short *address,
> u16 chip_type;
> const struct it87_devices *config = NULL;
>
> - err = superio_enter(sioaddr);
> + err = superio_enter(sioaddr, false);
> if (err)
> return err;
>
> @@ -3520,7 +3521,7 @@ static void it87_resume_sio(struct platform_device *pdev)
> if (!data->need_in7_reroute)
> return;
>
> - err = superio_enter(data->sioaddr);
> + err = superio_enter(data->sioaddr, has_conf_biosopen(data));
> if (err) {
> dev_warn(&pdev->dev,
> "Unable to enter Super I/O to reroute in7 (%d)",
next prev parent reply other threads:[~2024-04-10 15:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 2:56 [PATCH v1 0/4] hwmon (it87): Correct handling for configuration mode Frank Crawford
2024-04-01 2:56 ` [PATCH v1 1/4] hwmon (it87): Rename NOEXIT to BIOSOPEN as more descriptive of requirement Frank Crawford
2024-04-10 15:10 ` Guenter Roeck
2024-04-11 11:03 ` Frank Crawford
2024-04-11 12:31 ` Guenter Roeck
2024-04-12 10:20 ` Frank Crawford
2024-04-01 2:56 ` [PATCH v1 2/4] hwmon (it87): Do not enter configuration mode for some chip types Frank Crawford
2024-04-10 15:12 ` Guenter Roeck [this message]
2024-04-01 2:56 ` [PATCH v1 3/4] hwmon (it87): Test for chipset before entering configuration mode Frank Crawford
2024-04-10 15:17 ` Guenter Roeck
2024-04-11 11:08 ` Frank Crawford
2024-04-11 12:20 ` Guenter Roeck
2024-04-12 10:11 ` Frank Crawford
2024-04-12 12:48 ` Guenter Roeck
2024-04-13 8:47 ` Frank Crawford
2024-04-01 2:56 ` [PATCH v1 4/4] hwmon (it87): Remove tests no longer required Frank Crawford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6eb2a95-d9a9-42f0-a50d-3034c694d977@roeck-us.net \
--to=linux@roeck-us.net \
--cc=frank@crawford.emu.id.au \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).