From: Frank Crawford <frank@crawford.emu.id.au>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Jean Delvare <jdelvare@suse.com>, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v1 3/4] hwmon (it87): Test for chipset before entering configuration mode
Date: Thu, 11 Apr 2024 21:08:19 +1000 [thread overview]
Message-ID: <bfe6323c154ae4080a38a85e3601c7fe980dc10b.camel@crawford.emu.id.au> (raw)
In-Reply-To: <0773b784-e552-4b31-b8c7-d68e058a2290@roeck-us.net>
On Wed, 2024-04-10 at 08:17 -0700, Guenter Roeck wrote:
> On Mon, Apr 01, 2024 at 01:56:05PM +1100, Frank Crawford wrote:
> > Major part of the change for the new method to avoid chipset
> > issues.
> >
> > Perform an intial test if the chip ID can be read without entering
> > configuration mode, if so, do not enter configuration mode and
> > continue
> > as is.
> >
> > If chip ID cannot be read, enter configuration mode, and continue
> > with
> > previous code.
> >
> > Also update exit code to take account of if we entered
> > configuration
> > mode or not.
> >
>
> You describe the changes, but you don't describe the problem you are
> trying to solve. Even if configuration mode was already entered, that
> is not a reason to keep it active. We don't _know_ what is going on
> outside the driver and can not make assumptions. For changes like
> this
> you really need to explain the problem you are trying to solve, and
> the
> reasoning behind the changes. Just assuming that a set of chips would
> have its SIO mode enabled by the BIOS is just wrong. We don't know
> what if anything the BIOS is doing.
In this regard, it is no different to the current code, which runs SIO
mode enable, but does not ever run the SIO mode disable code.
In fact this code is actually safer than the previous code in that it
acts similar to the chip not being enabled or disabled, which would
happen if no driver existed.
>
> Guenter
>
Regards
Frank
next prev parent reply other threads:[~2024-04-11 11:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 2:56 [PATCH v1 0/4] hwmon (it87): Correct handling for configuration mode Frank Crawford
2024-04-01 2:56 ` [PATCH v1 1/4] hwmon (it87): Rename NOEXIT to BIOSOPEN as more descriptive of requirement Frank Crawford
2024-04-10 15:10 ` Guenter Roeck
2024-04-11 11:03 ` Frank Crawford
2024-04-11 12:31 ` Guenter Roeck
2024-04-12 10:20 ` Frank Crawford
2024-04-01 2:56 ` [PATCH v1 2/4] hwmon (it87): Do not enter configuration mode for some chip types Frank Crawford
2024-04-10 15:12 ` Guenter Roeck
2024-04-01 2:56 ` [PATCH v1 3/4] hwmon (it87): Test for chipset before entering configuration mode Frank Crawford
2024-04-10 15:17 ` Guenter Roeck
2024-04-11 11:08 ` Frank Crawford [this message]
2024-04-11 12:20 ` Guenter Roeck
2024-04-12 10:11 ` Frank Crawford
2024-04-12 12:48 ` Guenter Roeck
2024-04-13 8:47 ` Frank Crawford
2024-04-01 2:56 ` [PATCH v1 4/4] hwmon (it87): Remove tests no longer required Frank Crawford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfe6323c154ae4080a38a85e3601c7fe980dc10b.camel@crawford.emu.id.au \
--to=frank@crawford.emu.id.au \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).