From: Eddie James <eajames@linux.ibm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>, linux-aspeed@lists.ozlabs.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsi@lists.ozlabs.org, linux-spi@vger.kernel.org,
linux-i2c@vger.kernel.org, lakshmiy@us.ibm.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, joel@jms.id.au,
andrew@codeconstruct.com.au
Subject: Re: [PATCH v3 08/14] dt-bindings: fsi: ast2600-fsi-master: Switch to yaml format
Date: Fri, 26 Apr 2024 10:13:52 -0500 [thread overview]
Message-ID: <24e7644e-f9ff-4a4b-8883-33b2f69b36cf@linux.ibm.com> (raw)
In-Reply-To: <5822e000-01d3-442c-bb52-04fab87cb3da@kernel.org>
On 4/26/24 01:25, Krzysztof Kozlowski wrote:
> On 25/04/2024 23:36, Eddie James wrote:
>> Switch to yaml for the AST2600 FSI master documentation.
>>
>> Signed-off-by: Eddie James <eajames@linux.ibm.com>
>> ---
>> .../fsi/aspeed,ast2600-fsi-master.yaml | 72 +++++++++++++++++++
>> .../bindings/fsi/fsi-master-aspeed.txt | 36 ----------
>> 2 files changed, 72 insertions(+), 36 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/fsi/aspeed,ast2600-fsi-master.yaml
>> delete mode 100644 Documentation/devicetree/bindings/fsi/fsi-master-aspeed.txt
>>
>> diff --git a/Documentation/devicetree/bindings/fsi/aspeed,ast2600-fsi-master.yaml b/Documentation/devicetree/bindings/fsi/aspeed,ast2600-fsi-master.yaml
>> new file mode 100644
>> index 000000000000..f053e3e1d259
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/fsi/aspeed,ast2600-fsi-master.yaml
>> @@ -0,0 +1,72 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/fsi/aspeed,ast2600-fsi-master.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Aspeed FSI master
>> +
>> +maintainers:
>> + - Eddie James <eajames@linux.ibm.com>
>> +
>> +description:
>> + The AST2600 and later contain two identical FSI masters. They share a
>> + clock and have a separate interrupt line and output pins.
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - "aspeed,ast2600-fsi-master"
>> + - "aspeed,ast2700-fsi-master"
> This wasn't tested. No quotes. Do you see any other example like this?
Strangely this passes make dt_binding_check for me... And Rob's bot
didn't seem to catch it either. Just an oversight, I'll fix it.
>
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + clocks:
>> + maxItems: 1
>> +
>> + cfam-reset-gpios:
>> + maxItems: 1
>> + description:
>> + Output GPIO pin for CFAM reset
>> +
>> + fsi-routing-gpios:
>> + maxItems: 1
>> + description:
>> + Output GPIO pin for setting the FSI mux (internal or cabled)
>> +
>> + fsi-mux-gpios:
>> + maxItems: 1
>> + description:
>> + Input GPIO pin for detecting the desired FSI mux state
>> +
>> + interrupts:
>> + maxItems: 1
>> +
>> +allOf:
>> + - $ref: fsi-controller.yaml#
> This goes after required:
Ack.
>
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - clocks
>> + - interrupts
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/clock/ast2600-clock.h>
>> + #include <dt-bindings/gpio/aspeed-gpio.h>
>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>> + fsi-master@1e79b000 {
>> + compatible = "aspeed,ast2600-fsi-master";
>> + reg = <0x1e79b000 0x94>;
>> + interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_fsi1_default>;
>> + clocks = <&syscon ASPEED_CLK_GATE_FSICLK>;
>> + fsi-routing-gpios = <&gpio0 ASPEED_GPIO(Q, 7) GPIO_ACTIVE_HIGH>;
>> + fsi-mux-gpios = <&gpio0 ASPEED_GPIO(B, 0) GPIO_ACTIVE_HIGH>;
>> + cfam-reset-gpios = <&gpio0 ASPEED_GPIO(Q, 0) GPIO_ACTIVE_LOW>;
> No children?
Ack, I'll add one.
>
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2024-04-26 15:14 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 21:36 [PATCH v3 00/14] ARM: dts: aspeed: Add IBM P11 BMC Boards Eddie James
2024-04-25 21:36 ` [PATCH v3 01/14] dt-bindings: spi: Document the IBM Power SPI controller Eddie James
2024-04-25 23:39 ` Rob Herring
2024-04-26 6:15 ` Krzysztof Kozlowski
2024-04-26 14:49 ` Eddie James
2024-04-28 16:39 ` Krzysztof Kozlowski
2024-04-29 14:38 ` Eddie James
2024-04-29 18:17 ` Krzysztof Kozlowski
2024-04-25 21:36 ` [PATCH v3 02/14] dt-bindings: fsi: fsi2spi: Document SPI controller child nodes Eddie James
2024-04-25 21:36 ` [PATCH v3 03/14] dt-bindings: fsi: Document the FSI2PIB engine Eddie James
2024-04-26 6:17 ` Krzysztof Kozlowski
2024-04-26 6:18 ` Krzysztof Kozlowski
2024-04-26 15:00 ` Eddie James
2024-04-28 16:41 ` Krzysztof Kozlowski
2024-04-29 14:42 ` Eddie James
2024-04-25 21:36 ` [PATCH v3 04/14] dt-bindings: fsi: p9-occ: Switch to yaml format Eddie James
2024-04-26 6:19 ` Krzysztof Kozlowski
2024-04-26 15:05 ` Eddie James
2024-04-25 21:36 ` [PATCH v3 05/14] dt-bindings: fsi: Document the IBM SBEFIFO engine Eddie James
2024-04-26 6:20 ` Krzysztof Kozlowski
2024-04-26 15:09 ` Eddie James
2024-04-25 21:36 ` [PATCH v3 06/14] dt-bindings: fsi: Document the FSI controller common properties Eddie James
2024-04-25 23:40 ` Rob Herring
2024-04-26 6:23 ` Krzysztof Kozlowski
2024-04-26 15:11 ` Eddie James
2024-04-25 21:36 ` [PATCH v3 07/14] dt-bindings: fsi: ibm,i2cr-fsi-master: Reference common FSI controller Eddie James
2024-04-25 21:36 ` [PATCH v3 08/14] dt-bindings: fsi: ast2600-fsi-master: Switch to yaml format Eddie James
2024-04-26 6:25 ` Krzysztof Kozlowski
2024-04-26 15:13 ` Eddie James [this message]
2024-04-26 18:43 ` Rob Herring
2024-04-25 21:36 ` [PATCH v3 09/14] dt-bindings: fsi: Document the FSI Hub Controller Eddie James
2024-04-26 6:26 ` Krzysztof Kozlowski
2024-04-26 15:19 ` Eddie James
2024-04-28 16:43 ` Krzysztof Kozlowski
2024-04-25 21:36 ` [PATCH v3 10/14] dt-bindings: i2c: i2c-fsi: Switch to yaml format Eddie James
2024-04-26 0:21 ` kernel test robot
2024-04-26 6:29 ` Krzysztof Kozlowski
2024-04-26 15:23 ` Eddie James
2024-04-25 21:36 ` [PATCH v3 11/14] dt-bindings: arm: aspeed: add IBM P11 BMC boards Eddie James
2024-04-25 21:36 ` [PATCH v3 12/14] ARM: dts: aspeed: Add IBM P11 FSI devices Eddie James
2024-04-26 6:31 ` Krzysztof Kozlowski
2024-04-26 13:18 ` Eddie James
2024-04-28 16:39 ` Krzysztof Kozlowski
2024-04-25 21:37 ` [PATCH v3 13/14] ARM: dts: aspeed: Add IBM P11 Blueridge BMC system Eddie James
2024-04-26 6:35 ` Krzysztof Kozlowski
2024-04-26 13:22 ` Eddie James
2024-04-25 21:37 ` [PATCH v3 14/14] ARM: dts: aspeed: Add IBM P11 Fuji " Eddie James
2024-04-26 6:36 ` Krzysztof Kozlowski
2024-04-26 14:22 ` [PATCH v3 00/14] ARM: dts: aspeed: Add IBM P11 BMC Boards Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24e7644e-f9ff-4a4b-8883-33b2f69b36cf@linux.ibm.com \
--to=eajames@linux.ibm.com \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lakshmiy@us.ibm.com \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-fsi@lists.ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).