From: Krzysztof Kozlowski <krzk@kernel.org>
To: Eddie James <eajames@linux.ibm.com>, linux-aspeed@lists.ozlabs.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsi@lists.ozlabs.org, linux-spi@vger.kernel.org,
linux-i2c@vger.kernel.org, lakshmiy@us.ibm.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, joel@jms.id.au,
andrew@codeconstruct.com.au
Subject: Re: [PATCH v3 01/14] dt-bindings: spi: Document the IBM Power SPI controller
Date: Mon, 29 Apr 2024 20:17:02 +0200 [thread overview]
Message-ID: <f817d567-1b36-4c1a-aa2c-81615ac8fe76@kernel.org> (raw)
In-Reply-To: <b2bdae97-7cd5-4961-9cd4-1142a862d55f@linux.ibm.com>
On 29/04/2024 16:38, Eddie James wrote:
>
> On 4/28/24 11:39, Krzysztof Kozlowski wrote:
>> On 26/04/2024 16:49, Eddie James wrote:
>>> On 4/26/24 01:15, Krzysztof Kozlowski wrote:
>>>> On 25/04/2024 23:36, Eddie James wrote:
>>>>> The IBM Power chips have a basic SPI controller. Document it.
>>>> Please use subject prefixes matching the subsystem. You can get them for
>>>> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
>>>> your patch is touching.
>>>
>>> Isn't spi the right subsystem here?
>> And what prefix shall be for SPI bindings? Did you run the command or
>> just replying to disagree with me?
>
>
> The correct prefix is either dt-bindings: spi or spi: dt-bindings. I
> used the former. Would you prefer I use the latter? I followed your
The correct is the latter, although I see now Mark stopped stripping
dt-bindings in such case. Log is still suggesting that (git log
--oneline -- Documentation/devicetree/bindings/spi/ | grep "^[0-9a-f]\+
spi:" | wc -l gives 370 vs 130), although I understand now different
approach.
It's also mentioned here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-29 18:17 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 21:36 [PATCH v3 00/14] ARM: dts: aspeed: Add IBM P11 BMC Boards Eddie James
2024-04-25 21:36 ` [PATCH v3 01/14] dt-bindings: spi: Document the IBM Power SPI controller Eddie James
2024-04-25 23:39 ` Rob Herring
2024-04-26 6:15 ` Krzysztof Kozlowski
2024-04-26 14:49 ` Eddie James
2024-04-28 16:39 ` Krzysztof Kozlowski
2024-04-29 14:38 ` Eddie James
2024-04-29 18:17 ` Krzysztof Kozlowski [this message]
2024-04-25 21:36 ` [PATCH v3 02/14] dt-bindings: fsi: fsi2spi: Document SPI controller child nodes Eddie James
2024-04-25 21:36 ` [PATCH v3 03/14] dt-bindings: fsi: Document the FSI2PIB engine Eddie James
2024-04-26 6:17 ` Krzysztof Kozlowski
2024-04-26 6:18 ` Krzysztof Kozlowski
2024-04-26 15:00 ` Eddie James
2024-04-28 16:41 ` Krzysztof Kozlowski
2024-04-29 14:42 ` Eddie James
2024-04-25 21:36 ` [PATCH v3 04/14] dt-bindings: fsi: p9-occ: Switch to yaml format Eddie James
2024-04-26 6:19 ` Krzysztof Kozlowski
2024-04-26 15:05 ` Eddie James
2024-04-25 21:36 ` [PATCH v3 05/14] dt-bindings: fsi: Document the IBM SBEFIFO engine Eddie James
2024-04-26 6:20 ` Krzysztof Kozlowski
2024-04-26 15:09 ` Eddie James
2024-04-25 21:36 ` [PATCH v3 06/14] dt-bindings: fsi: Document the FSI controller common properties Eddie James
2024-04-25 23:40 ` Rob Herring
2024-04-26 6:23 ` Krzysztof Kozlowski
2024-04-26 15:11 ` Eddie James
2024-04-25 21:36 ` [PATCH v3 07/14] dt-bindings: fsi: ibm,i2cr-fsi-master: Reference common FSI controller Eddie James
2024-04-25 21:36 ` [PATCH v3 08/14] dt-bindings: fsi: ast2600-fsi-master: Switch to yaml format Eddie James
2024-04-26 6:25 ` Krzysztof Kozlowski
2024-04-26 15:13 ` Eddie James
2024-04-26 18:43 ` Rob Herring
2024-04-25 21:36 ` [PATCH v3 09/14] dt-bindings: fsi: Document the FSI Hub Controller Eddie James
2024-04-26 6:26 ` Krzysztof Kozlowski
2024-04-26 15:19 ` Eddie James
2024-04-28 16:43 ` Krzysztof Kozlowski
2024-04-25 21:36 ` [PATCH v3 10/14] dt-bindings: i2c: i2c-fsi: Switch to yaml format Eddie James
2024-04-26 0:21 ` kernel test robot
2024-04-26 6:29 ` Krzysztof Kozlowski
2024-04-26 15:23 ` Eddie James
2024-04-25 21:36 ` [PATCH v3 11/14] dt-bindings: arm: aspeed: add IBM P11 BMC boards Eddie James
2024-04-25 21:36 ` [PATCH v3 12/14] ARM: dts: aspeed: Add IBM P11 FSI devices Eddie James
2024-04-26 6:31 ` Krzysztof Kozlowski
2024-04-26 13:18 ` Eddie James
2024-04-28 16:39 ` Krzysztof Kozlowski
2024-04-25 21:37 ` [PATCH v3 13/14] ARM: dts: aspeed: Add IBM P11 Blueridge BMC system Eddie James
2024-04-26 6:35 ` Krzysztof Kozlowski
2024-04-26 13:22 ` Eddie James
2024-04-25 21:37 ` [PATCH v3 14/14] ARM: dts: aspeed: Add IBM P11 Fuji " Eddie James
2024-04-26 6:36 ` Krzysztof Kozlowski
2024-04-26 14:22 ` [PATCH v3 00/14] ARM: dts: aspeed: Add IBM P11 BMC Boards Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f817d567-1b36-4c1a-aa2c-81615ac8fe76@kernel.org \
--to=krzk@kernel.org \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=lakshmiy@us.ibm.com \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-fsi@lists.ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).