From: Jakub Kicinski <kuba@kernel.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, vladimir.oltean@nxp.com, shuah@kernel.org,
petrm@nvidia.com, bpoirier@nvidia.com,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next] selftests: net: local_termination: annotate the expected failures
Date: Thu, 9 May 2024 20:47:28 -0700 [thread overview]
Message-ID: <20240509204728.5326bf6a@kernel.org> (raw)
In-Reply-To: <Zj2RbpO6tu7Sq8za@Laptop-X1>
On Fri, 10 May 2024 11:15:58 +0800 Hangbin Liu wrote:
> I may missed something, I saw there is already a log_test_xfail() in lib.sh
>
> log_test_skip()
> {
> RET=$ksft_skip retmsg= log_test "$@"
> }
>
> log_test_xfail()
> {
> RET=$ksft_xfail retmsg= log_test "$@"
> }
>
> log_info()
> {
> ...
> }
>
> Added by a923af1ceee7 ("selftests: forwarding: Convert log_test() to recognize RET values")
Good catch, sorry. Must have had net checked out when I wrote it :(
next prev parent reply other threads:[~2024-05-10 3:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 23:55 [PATCH net-next] selftests: net: local_termination: annotate the expected failures Jakub Kicinski
2024-05-10 3:15 ` Hangbin Liu
2024-05-10 3:47 ` Jakub Kicinski [this message]
2024-05-10 10:58 ` Vladimir Oltean
2024-05-13 13:25 ` Petr Machata
2024-05-15 0:43 ` Jakub Kicinski
2024-05-15 9:02 ` Petr Machata
2024-05-15 23:21 ` Jakub Kicinski
2024-05-16 8:42 ` Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240509204728.5326bf6a@kernel.org \
--to=kuba@kernel.org \
--cc=bpoirier@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=shuah@kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).