From: Hangbin Liu <liuhangbin@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, vladimir.oltean@nxp.com, shuah@kernel.org,
petrm@nvidia.com, bpoirier@nvidia.com,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next] selftests: net: local_termination: annotate the expected failures
Date: Fri, 10 May 2024 11:15:58 +0800 [thread overview]
Message-ID: <Zj2RbpO6tu7Sq8za@Laptop-X1> (raw)
In-Reply-To: <20240509235553.5740-1-kuba@kernel.org>
Hi Jakub,
On Thu, May 09, 2024 at 04:55:53PM -0700, Jakub Kicinski wrote:
> Vladimir said when adding this test:
>
> The bridge driver fares particularly badly [...] mainly because
> it does not implement IFF_UNICAST_FLT.
>
> See commit 90b9566aa5cd ("selftests: forwarding: add a test for
> local_termination.sh").
>
> We don't want to hide the known gaps, but having a test which
> always fails prevents us from catching regressions. Report
> the cases we know may fail as XFAIL.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: vladimir.oltean@nxp.com
> CC: shuah@kernel.org
> CC: petrm@nvidia.com
> CC: liuhangbin@gmail.com
> CC: bpoirier@nvidia.com
> CC: linux-kselftest@vger.kernel.org
> ---
> tools/testing/selftests/net/forwarding/lib.sh | 9 ++++++++
> .../net/forwarding/local_termination.sh | 21 ++++++++++++++-----
> 2 files changed, 25 insertions(+), 5 deletions(-)
>
> diff --git a/tools/testing/selftests/net/forwarding/lib.sh b/tools/testing/selftests/net/forwarding/lib.sh
> index 3353a1745946..4fe28ab5d8b9 100644
> --- a/tools/testing/selftests/net/forwarding/lib.sh
> +++ b/tools/testing/selftests/net/forwarding/lib.sh
> @@ -605,6 +605,15 @@ log_test_xfail()
> RET=$ksft_xfail retmsg= log_test "$@"
> }
>
> +log_test_xfail()
> +{
> + local test_name=$1
> + local opt_str=$2
> +
> + printf "TEST: %-60s [XFAIL]\n" "$test_name $opt_str"
> + return 0
> +}
> +
I may missed something, I saw there is already a log_test_xfail() in lib.sh
log_test_skip()
{
RET=$ksft_skip retmsg= log_test "$@"
}
log_test_xfail()
{
RET=$ksft_xfail retmsg= log_test "$@"
}
log_info()
{
...
}
Added by a923af1ceee7 ("selftests: forwarding: Convert log_test() to recognize RET values")
Thanks
Hangbin
next prev parent reply other threads:[~2024-05-10 3:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 23:55 [PATCH net-next] selftests: net: local_termination: annotate the expected failures Jakub Kicinski
2024-05-10 3:15 ` Hangbin Liu [this message]
2024-05-10 3:47 ` Jakub Kicinski
2024-05-10 10:58 ` Vladimir Oltean
2024-05-13 13:25 ` Petr Machata
2024-05-15 0:43 ` Jakub Kicinski
2024-05-15 9:02 ` Petr Machata
2024-05-15 23:21 ` Jakub Kicinski
2024-05-16 8:42 ` Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zj2RbpO6tu7Sq8za@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=bpoirier@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=shuah@kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).