From: Martin Wilck <martin.wilck@suse.com>
To: Christophe Varoqui <christophe.varoqui@opensvc.com>,
Benjamin Marzinski <bmarzins@redhat.com>
Cc: dm-devel@lists.linux.dev, linux-lvm@lists.linux.dev,
Zdenek Kabelac <zkabelac@redhat.com>,
Peter Rajnoha <prajnoha@redhat.com>
Subject: [PATCH v2 0/7] udev rule and CI improvements
Date: Sat, 10 Feb 2024 00:27:28 +0100 [thread overview]
Message-ID: <20240209232735.9791-1-mwilck@suse.com> (raw)
Changes wrt v1:
2/7: This patch becomes trivial, DM_UDEV_DISABLE_OTHER_RULES_FLAG
is not imported any more, and my previous statement that DM_NOPATH
might be set in an earlier rule was wrong; the test whether
it's already set is dropped.
3/7: looks different now because of the change in 2/6
4/7: there was a flaw in the previous version, .MPATH_SAVE_DISABLE_OTHER_RULES_FLAG
must always be set. z0-dm-mpath-late.rules was broken as well.
5/7: looks different now because of the change in 2/6
6/7: new, another glitch that I found while working on this code
7/7: was 6/6.
Except for 1/7, I dropped Ben's "Reviewed-by:" trailer.
Changes wrt "v0" ("multipath-tools: udev rules and service improvements"
posted on Feb 5th)
1/6: fix logic as pointed out by Ben Marzinski
2/6: Keep importing MPATH_DEVICE_READY as suggested by Ben Marzinski.
Don't import DM_UDEV_DISABLE_OTHER_RULES_FLAG any more.
# v1 Cover letter:
Patch 1-3 of this series are actually a v3 of my previous series
"multipath-tools: udev rules and service improvements" posted on Feb 5th.
Patch 4-6 are new. 4/6 implements new logic for setting
DM_UDEV_DISABLE_OTHER_RULES_FLAG_OLD, as discussed in the thread about 1/6
of the v1 series. 5/6 fixes a variant of the race condition that 3/6
addresses. Meanwhile I got positive test feedback about these patches; the
partner isn't observing any more errors with these patches applied. Thus
while certain types of race conditions (reload happening between
DM_SUSPENDED test in 10-dm.rules and blkid or pvscan calls in later rules)
are still possible, they seem to be rare enough to be handled in a separate
patch set.
6/6 is an unrelated new patch which is necessary to make CI for arm/v7
environments work.
Martin Wilck (7):
11-dm-mpath.rules: use import logic like 13-dm-disk.rules
11-dm-mpath.rules: don't import DM_UDEV_DISABLE_OTHER_RULES_FLAG
11-dm-mpath.rules: handle reloads during coldplug events
11-dm-mpath.rules: don't save DM_UDEV_DISABLE_OTHER_RULES_FLAG_OLD
11-dm-mpath.rules: clear DM_DISABLE_OTHER_RULES_FLAG for coldplug
events
11-dm-mpath.rules: Don't force activation while device is suspended
multipath-tools: Makefile.inc: set _FILE_OFFSET_BITS=64
Makefile.inc | 1 +
multipath/11-dm-mpath.rules.in | 67 +++++++++++++++++++++++++-------
multipath/Makefile | 2 +
multipath/z0-dm-mpath-late.rules | 4 ++
tests/Makefile | 5 ++-
tests/alias.c | 4 +-
tests/directio.c | 7 ++--
tests/dmevents.c | 8 ++--
tests/sysfs.c | 57 ++++++++++++++-------------
tests/test-lib.c | 9 +++--
tests/wrap64.h | 48 +++++++++++++++++++++++
11 files changed, 157 insertions(+), 55 deletions(-)
create mode 100644 multipath/z0-dm-mpath-late.rules
create mode 100644 tests/wrap64.h
--
2.43.0
next reply other threads:[~2024-02-09 23:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 23:27 Martin Wilck [this message]
2024-02-09 23:27 ` [PATCH v2 1/7] 11-dm-mpath.rules: use import logic like 13-dm-disk.rules Martin Wilck
2024-02-09 23:27 ` [PATCH v2 2/7] 11-dm-mpath.rules: don't import DM_UDEV_DISABLE_OTHER_RULES_FLAG Martin Wilck
2024-02-10 1:38 ` Benjamin Marzinski
2024-02-09 23:27 ` [PATCH v2 3/7] 11-dm-mpath.rules: handle reloads during coldplug events Martin Wilck
2024-02-10 1:58 ` Benjamin Marzinski
2024-02-09 23:27 ` [PATCH v2 4/7] 11-dm-mpath.rules: don't save DM_UDEV_DISABLE_OTHER_RULES_FLAG_OLD Martin Wilck
2024-02-10 2:17 ` Benjamin Marzinski
2024-02-10 16:44 ` Martin Wilck
2024-02-09 23:27 ` [PATCH v2 5/7] 11-dm-mpath.rules: clear DM_DISABLE_OTHER_RULES_FLAG for coldplug events Martin Wilck
2024-02-10 2:19 ` Benjamin Marzinski
2024-02-09 23:27 ` [PATCH v2 6/7] 11-dm-mpath.rules: Don't force activation while device is suspended Martin Wilck
2024-02-10 2:38 ` Benjamin Marzinski
2024-02-14 20:32 ` Martin Wilck
2024-02-09 23:27 ` [PATCH v2 7/7] multipath-tools: Makefile.inc: set _FILE_OFFSET_BITS=64 Martin Wilck
2024-02-10 3:30 ` Benjamin Marzinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240209232735.9791-1-mwilck@suse.com \
--to=martin.wilck@suse.com \
--cc=bmarzins@redhat.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@lists.linux.dev \
--cc=linux-lvm@lists.linux.dev \
--cc=prajnoha@redhat.com \
--cc=zkabelac@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).