From: Martin Wilck <martin.wilck@suse.com>
To: Benjamin Marzinski <bmarzins@redhat.com>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>,
dm-devel@lists.linux.dev, linux-lvm@lists.linux.dev,
Zdenek Kabelac <zkabelac@redhat.com>,
Peter Rajnoha <prajnoha@redhat.com>
Subject: Re: [PATCH v2 6/7] 11-dm-mpath.rules: Don't force activation while device is suspended
Date: Wed, 14 Feb 2024 21:32:35 +0100 [thread overview]
Message-ID: <918f2d1af0ab68c73e463f6ef30a4d70dade12a2.camel@suse.com> (raw)
In-Reply-To: <ZcbhtFJkq2syENL4@bmarzins-01.fast.eng.rdu2.dc.redhat.com>
On Fri, 2024-02-09 at 21:38 -0500, Benjamin Marzinski wrote:
> On Sat, Feb 10, 2024 at 12:27:34AM +0100, Martin Wilck wrote:
> > If paths become available while the device is suspended, don't
> > activate. Another uevent will arrive when the device is resumed.
> >
> > Signed-off-by: Martin Wilck <mwilck@suse.com>
> Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
> > ---
> > multipath/11-dm-mpath.rules.in | 12 +++++++++---
> > 1 file changed, 9 insertions(+), 3 deletions(-)
> >
> > diff --git a/multipath/11-dm-mpath.rules.in b/multipath/11-dm-
> > mpath.rules.in
> > index 8e8741a..4141833 100644
> > --- a/multipath/11-dm-mpath.rules.in
> > +++ b/multipath/11-dm-mpath.rules.in
> > @@ -92,10 +92,16 @@ ENV{MPATH_DEVICE_READY}=="0",
> > ENV{DM_NOSCAN}="1"
> > ENV{MPATH_DEVICE_READY}=="0", \
> > ENV{.MPATH_SAVE_DISABLE_OTHER_RULES_FLAG}="$env{DM_UDEV_DI
> > SABLE_OTHER_RULES_FLAG}", \
> > ENV{DM_UDEV_DISABLE_OTHER_RULES_FLAG}="1"
> > +
> > # If the device comes back online, set DM_ACTIVATION so that
> > -# upper layers do a rescan.
> > -ENV{MPATH_DEVICE_READY}!="0", ENV{.MPATH_DEVICE_READY_OLD}=="0", \
> > - ENV{DM_ACTIVATION}="1", ENV{MPATH_UNCHANGED}="0"
> > +# upper layers do a rescan. If the device is currently suspended,
> > +# we have to postpone the activation until the next event.
> > +ENV{MPATH_DEVICE_READY}=="0", GOTO="dont_activate"
> > +ENV{.MPATH_DEVICE_READY_OLD}!="0", GOTO="dont_activate"
> > +ENV{DM_SUSPENDED}==1, ENV{MPATH_DEVICE_READY}="0",
... and it turns out I made a stupid missing-quotes mistake here.
I'll re-post the series, to avoid further confusion.
Martin
next prev parent reply other threads:[~2024-02-14 20:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 23:27 [PATCH v2 0/7] udev rule and CI improvements Martin Wilck
2024-02-09 23:27 ` [PATCH v2 1/7] 11-dm-mpath.rules: use import logic like 13-dm-disk.rules Martin Wilck
2024-02-09 23:27 ` [PATCH v2 2/7] 11-dm-mpath.rules: don't import DM_UDEV_DISABLE_OTHER_RULES_FLAG Martin Wilck
2024-02-10 1:38 ` Benjamin Marzinski
2024-02-09 23:27 ` [PATCH v2 3/7] 11-dm-mpath.rules: handle reloads during coldplug events Martin Wilck
2024-02-10 1:58 ` Benjamin Marzinski
2024-02-09 23:27 ` [PATCH v2 4/7] 11-dm-mpath.rules: don't save DM_UDEV_DISABLE_OTHER_RULES_FLAG_OLD Martin Wilck
2024-02-10 2:17 ` Benjamin Marzinski
2024-02-10 16:44 ` Martin Wilck
2024-02-09 23:27 ` [PATCH v2 5/7] 11-dm-mpath.rules: clear DM_DISABLE_OTHER_RULES_FLAG for coldplug events Martin Wilck
2024-02-10 2:19 ` Benjamin Marzinski
2024-02-09 23:27 ` [PATCH v2 6/7] 11-dm-mpath.rules: Don't force activation while device is suspended Martin Wilck
2024-02-10 2:38 ` Benjamin Marzinski
2024-02-14 20:32 ` Martin Wilck [this message]
2024-02-09 23:27 ` [PATCH v2 7/7] multipath-tools: Makefile.inc: set _FILE_OFFSET_BITS=64 Martin Wilck
2024-02-10 3:30 ` Benjamin Marzinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=918f2d1af0ab68c73e463f6ef30a4d70dade12a2.camel@suse.com \
--to=martin.wilck@suse.com \
--cc=bmarzins@redhat.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@lists.linux.dev \
--cc=linux-lvm@lists.linux.dev \
--cc=prajnoha@redhat.com \
--cc=zkabelac@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).