From: Ryan Roberts <ryan.roberts@arm.com>
To: Will Deacon <will@kernel.org>
Cc: kernel test robot <lkp@intel.com>,
oe-kbuild-all@lists.linux.dev,
Linux Memory Management List <linux-mm@kvack.org>,
Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: [linux-next:master 10159/12060] arch/arm64/include/asm/pgtable.h:1102:16: error: implicit declaration of function 'pud_valid'; did you mean 'pmd_valid'?
Date: Thu, 9 May 2024 13:59:09 +0100 [thread overview]
Message-ID: <a6db13cf-227e-4588-a212-7c21055c7942@arm.com> (raw)
In-Reply-To: <20240508171211.GB23294@willie-the-truck>
On 08/05/2024 18:12, Will Deacon wrote:
> Hey Ryan,
>
> On Wed, May 08, 2024 at 04:38:01PM +0100, Ryan Roberts wrote:
>> On 08/05/2024 15:24, kernel test robot wrote:
>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
>>> head: e7b4ef8fffaca247809337bb78daceb406659f2d
>>> commit: f0f5863a0fb0fb48a5881c3f6acca1958899dd76 [10159/12060] arm64/mm: Remove PTE_PROT_NONE bit
>>> config: arm64-randconfig-r013-20230528 (https://download.01.org/0day-ci/archive/20240508/202405082221.43rfWxz5-lkp@intel.com/config)
>>> compiler: aarch64-linux-gcc (GCC) 13.2.0
>>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240508/202405082221.43rfWxz5-lkp@intel.com/reproduce)
>>>
>>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>>> the same patch/commit), kindly add following tags
>>> | Reported-by: kernel test robot <lkp@intel.com>
>>> | Closes: https://lore.kernel.org/oe-kbuild-all/202405082221.43rfWxz5-lkp@intel.com/
>>>
>>> All errors (new ones prefixed by >>):
>>>
>>> In file included from include/linux/pgtable.h:6,
>>> from arch/arm64/include/asm/io.h:12,
>>> from include/linux/io.h:13,
>>> from include/linux/irq.h:20,
>>> from include/asm-generic/hardirq.h:17,
>>> from arch/arm64/include/asm/hardirq.h:17,
>>> from include/linux/hardirq.h:11,
>>> from include/linux/interrupt.h:11,
>>> from include/linux/trace_recursion.h:5,
>>> from include/linux/ftrace.h:10,
>>> from arch/arm64/kernel/asm-offsets.c:12:
>>> arch/arm64/include/asm/pgtable.h: In function 'pud_user_accessible_page':
>>>>> arch/arm64/include/asm/pgtable.h:1102:16: error: implicit declaration of function 'pud_valid'; did you mean 'pmd_valid'? [-Werror=implicit-function-declaration]
>>> 1102 | return pud_valid(pud) && !pud_table(pud) && (pud_user(pud) || pud_user_exec(pud));
>>> | ^~~~~~~~~
>>> | pmd_valid
>>
>> Hi Will,
>>
>> Looks like this is due to pud_valid() not being defined for
>> CONFIG_PGTABLE_LEVELS <= 2. Seems to me that this is the cleanest solution. But
>> pgtable folding breaks my brain so perhaps there is a better way?
>
> I think your approach is the right idea. pgtable-nopmd.h defines
> pud_present() as 'return 1', but I think pud_valid() can be false given
> that it's only used directly by the arch code.
>
>> What's the process here? Can you just merge this into the broken patch, or do I
>> need to re-post the series, or post a fix patch formally?
>
> for-next/mm is stable, so please just submit proper patches on top of
> that (and you can add a Fixes: tag as well).
OK no problem - I've posted the patch. Sorry about this!
>
> Cheers,
>
> Will
prev parent reply other threads:[~2024-05-09 12:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 14:24 [linux-next:master 10159/12060] arch/arm64/include/asm/pgtable.h:1102:16: error: implicit declaration of function 'pud_valid'; did you mean 'pmd_valid'? kernel test robot
2024-05-08 15:38 ` Ryan Roberts
2024-05-08 17:12 ` Will Deacon
2024-05-09 12:59 ` Ryan Roberts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6db13cf-227e-4588-a212-7c21055c7942@arm.com \
--to=ryan.roberts@arm.com \
--cc=catalin.marinas@arm.com \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).