From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Frank Li <Frank.li@nxp.com>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
imx@lists.linux.dev, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 5/5] PCI: dwc: Add common send PME_Turn_Off message method
Date: Sun, 14 Apr 2024 16:02:56 +0530 [thread overview]
Message-ID: <20240414103256.GB2294@thinkpad> (raw)
In-Reply-To: <Zhmi0XEUFMIO9OLx@lizhi-Precision-Tower-5810>
On Fri, Apr 12, 2024 at 05:08:33PM -0400, Frank Li wrote:
> On Fri, Apr 12, 2024 at 10:35:48PM +0530, Manivannan Sadhasivam wrote:
> > On Mon, Apr 08, 2024 at 11:11:11AM -0400, Frank Li wrote:
> > > On Sat, Apr 06, 2024 at 09:31:31AM +0530, Manivannan Sadhasivam wrote:
> > > > On Fri, Apr 05, 2024 at 10:31:16AM -0400, Frank Li wrote:
> > > > > On Fri, Apr 05, 2024 at 11:54:26AM +0530, Manivannan Sadhasivam wrote:
> > > > > > On Tue, Mar 19, 2024 at 12:07:15PM -0400, Frank Li wrote:
> > > > > >
> > > > > > PCI: dwc: Add generic MSG TLP support for sending PME_Turn_Off during system suspend
> > > > > >
> > > > > > > Reserve space at end of first IORESOURCE_MEM window as message TLP MMIO
> > > > > > > window. This space's size is 'region_align'.
> > > > > > >
> > > > > > > Set outbound ATU map memory write to send PCI message. So one MMIO write
> > > > > > > can trigger a PCI message, such as PME_Turn_Off.
> > > > > > >
> > > > > > > Add common dwc_pme_turn_off() function.
> > > > > > >
> > > > > > > Call dwc_pme_turn_off() to send out PME_Turn_Off message in general
> > > > > > > dw_pcie_suspend_noirq() if there are not platform callback pme_turn_off()
> > > > > > > exist.
> > > > > > >
> > > > > >
> > > > > > How about:
> > > > > >
> > > > > > "Instead of relying on the vendor specific implementations to send the
> > > > > > PME_Turn_Off message, let's introduce a generic way of sending the message using
> > > > > > the MSG TLP.
> > > > > >
> > > > > > This is achieved by reserving a region for MSG TLP of size 'pci->region_align',
> > > > > > at the end of the first IORESOURCE_MEM window of the host bridge. And then
> > > > > > sending the PME_Turn_Off message during system suspend with the help of iATU.
> > > > > >
> > > > > > It should be noted that this generic implementation is optional for the glue
> > > > > > drivers and can be overridden by a custom 'pme_turn_off' callback."
> > > > > >
> > > > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > > > > > ---
> > > > > > > drivers/pci/controller/dwc/pcie-designware-host.c | 94 ++++++++++++++++++++++-
> > > > > > > drivers/pci/controller/dwc/pcie-designware.h | 3 +
> > > > > > > 2 files changed, 93 insertions(+), 4 deletions(-)
> > > > > > >
> > > > > > > diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c
> > > > > > > index 267687ab33cbc..d5723fce7a894 100644
> > > > > > > --- a/drivers/pci/controller/dwc/pcie-designware-host.c
> > > > > > > +++ b/drivers/pci/controller/dwc/pcie-designware-host.c
> > > > > > > @@ -393,6 +393,31 @@ static int dw_pcie_msi_host_init(struct dw_pcie_rp *pp)
> > > > > > > return 0;
> > > > > > > }
> > > > > > >
> > > > > > > +static void dw_pcie_host_request_msg_tlp_res(struct dw_pcie_rp *pp)
> > > > > > > +{
> > > > > > > + struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
> > > > > > > + struct resource_entry *win;
> > > > > > > + struct resource *res;
> > > > > > > +
> > > > > > > + win = resource_list_first_type(&pp->bridge->windows, IORESOURCE_MEM);
> > > > > > > + if (win) {
> > > > > > > + res = devm_kzalloc(pci->dev, sizeof(*res), GFP_KERNEL);
> > > > > > > + if (!res)
> > > > > > > + return;
> > > > > > > +
> > > > > > > + /* Reserve last region_align block as message TLP space */
> > > > > > > + res->start = win->res->end - pci->region_align + 1;
> > > > > > > + res->end = win->res->end;
> > > > > >
> > > > > > Don't you need to adjust the host bridge window size and end address?
> > > > >
> > > > > Needn't. request_resource will reserve it from bridge window. Like malloc,
> > > > > if you malloc to get a region of memory, which will never get by malloc
> > > > > again utill you call free.
> > > > >
> > > >
> > > > Hmm, will that modify the window->res->end address and size?
> > >
> > > No. This windows already reported to pci system before this function. It is
> > > not good to modify window-res-end. It just add child resource like below.
> > >
> > > windows is root resource, which will create may child when call
> > > request_resource.
> > > bridge -> windows
> > > child1 -> msg
> > > child2 -> pci ep1
> > > child3 -> pci_ep2.
> > > ...
> > >
> > > Although you see whole bridge window, 'msg' already used and put under root
> > > resource, new pci devices will never use 'msg' resource.
> > >
> > > If change windows->res->end here, I worry about it may broken resource
> > > tree.
> > >
> >
> > Hmm, I think your argument is fair. I was worrying that if someone try to
> > map separately by referencing win->res->end, then they will see access
> > violation.
>
> It should be wrong if use it without request resource.
>
> >
> > But why can't you just allocate the resource using 'alloc_resource()' API
> > instead of always allocating at the end?
>
> Alloc will start from windows (for example: 0x8000_0000).
> 0x8000_0000 -> 0x8001_0000 will be allocated to 'msg'.
>
> If ep1 want to get 1MB windows, 0x8010_0000 will return. There is a big
> hole between 0x8001_0000 to 0x8010_0000.
>
> I just want to reduce impact to existed system. So PCIe memory layout will
> be kept the same w/o this patch.
>
> There are not big difference between allocate resource and reserve resource
> for 'msg'. Just little better friendly for exist system.
>
Ok. This sounds fine to me. Please add this information as a comment so that
everyone will be aware of the reasoning.
- Mani
> Frank
>
> >
> > - Mani
> >
> > > >
> > > > > >
> > > > > > > + res->name = "msg";
> > > > > > > + res->flags = win->res->flags | IORESOURCE_BUSY;
> > > > > > > +
> > > > > >
> > > > > > Shouldn't this resource be added back to the host bridge?
> > > > >
> > > > > No, this resource will reserver for msg only for whole bridge life cycle.
> > > > > Genenally alloc resource only happen at PCI devices probe. All pci space
> > > > > will be fixed after system probe.
> > > > >
> > > >
> > > > I don't think so. This resource still belongs to the host bridge, so we should
> > > > add it back.
> > >
> > > When add back? It was reserved at bridge probe. When bridge remove, all
> > > resource will released.
> > >
> > > >
> > > > - Mani
> > > >
> > > > --
> > > > மணிவண்ணன் சதாசிவம்
> >
> > --
> > மணிவண்ணன் சதாசிவம்
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2024-04-14 10:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 16:07 [PATCH v5 0/5] PCI: dwc: Add common pme_turn_off message by using outbound iATU Frank Li
2024-03-19 16:07 ` [PATCH v5 1/5] PCI: Add INTx Mechanism Messages macros Frank Li
2024-03-19 16:07 ` [PATCH v5 2/5] PCI: dwc: Consolidate args of dw_pcie_prog_outbound_atu() into a structure Frank Li
2024-03-19 16:07 ` [PATCH v5 3/5] PCI: dwc: Add outbound MSG TLPs support Frank Li
2024-03-19 16:07 ` [PATCH v5 4/5] PCI: Add PCIE_MSG_CODE_PME_TURN_OFF message macro Frank Li
2024-04-04 15:53 ` Manivannan Sadhasivam
2024-03-19 16:07 ` [PATCH v5 5/5] PCI: dwc: Add common send PME_Turn_Off message method Frank Li
2024-04-05 6:24 ` Manivannan Sadhasivam
2024-04-05 14:31 ` Frank Li
2024-04-06 4:01 ` Manivannan Sadhasivam
2024-04-08 15:11 ` Frank Li
2024-04-12 17:05 ` Manivannan Sadhasivam
2024-04-12 21:08 ` Frank Li
2024-04-14 10:32 ` Manivannan Sadhasivam [this message]
2024-04-02 16:15 ` [PATCH v5 0/5] PCI: dwc: Add common pme_turn_off message by using outbound iATU Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240414103256.GB2294@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=Frank.li@nxp.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gustavo.pimentel@synopsys.com \
--cc=imx@lists.linux.dev \
--cc=jingoohan1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).