From: Frank Li <Frank.li@nxp.com>
To: "Bjorn Helgaas" <bhelgaas@google.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
imx@lists.linux.dev
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Serge Semin <fancer.lancer@gmail.com>
Subject: Re: [PATCH v5 0/5] PCI: dwc: Add common pme_turn_off message by using outbound iATU
Date: Tue, 2 Apr 2024 12:15:56 -0400 [thread overview]
Message-ID: <ZgwvPB/LbPRshVCy@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20240319-pme_msg-v5-0-af9ffe57f432@nxp.com>
On Tue, Mar 19, 2024 at 12:07:10PM -0400, Frank Li wrote:
> Involve an new and common mathod to send pme_turn_off() message. Previously
> pme_turn_off() implement by platform related special register to trigge
> it.
>
> But Yoshihiro give good idea by using iATU to send out message. Previously
> Yoshihiro provide patches to raise INTx message by dummy write to outbound
> iATU.
>
> Use similar mathod to send out pme_turn_off message.
>
> Previous two patches is picked from Yoshihiro' big patch serialise.
> PCI: dwc: Change arguments of dw_pcie_prog_outbound_atu()
> PCI: Add INTx Mechanism Messages macros
>
> PCI: Add PME_TURN_OFF message macro
> dt-bindings: PCI: dwc: Add 'msg" register region, Add "msg" region to use
> to map PCI msg.
>
> PCI: dwc: Add common pme_turn_off message method
> Using common pme_turn_off() message if platform have not define their.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Changes in v5:
> - Default disable allocate TLP message memory windows. If driver need use
> this feature, need set use_atu_msg = true before call dw_host_init().
Mani, lorenzo and bjorn
Any comments about these patches? I already set this feature default as
false. It is common for all dwc platform.
After this merge, imx6 and layerscape many customer PME code can be
removed.
Frank
>
> - Link to v4: https://lore.kernel.org/r/20240213-pme_msg-v4-0-e2acd4d7a292@nxp.com
>
> Changes in v4:
> - Remove dt-binding patch. Needn't change any dts file and binding doc.
> Reserve a region at end of first IORESOURCE_MEM window by call
> request_resource(). So PCIe stack will not use this reserve region to any
> PCIe devices.
> I tested it by reserve at begin of IORESOURCE_MEM window. PCIe stack
> will skip it as expection.
>
> Fixed a issue, forget set iATU index when sent PME_turn_off.
>
> - Link to v3: https://lore.kernel.org/r/20240202-pme_msg-v3-0-ff2af57a02ad@nxp.com
>
> Changes in v3:
> - fix 'MSG"
> - Add pcie spec ref in head file
> - using function name dw_pci_pme_turn_off()
> - Using PCIE_ prefix macro
> - Link to v2: https://lore.kernel.org/r/20240201-pme_msg-v2-0-6767052fe6a4@nxp.com
>
> Changes in v2:
> - Add my sign off at PCI: dwc: Add outbound MSG TLPs support
> - Add Bjorn review tag at Add INTx Mechanism Messages macros
> - using PME_Turn_Off match PCIe spec
> - ref to pcie spec v6.1
> - using section number.
>
> - Link to v1: https://lore.kernel.org/r/20240130-pme_msg-v1-0-d52b0add5c7c@nxp.com
>
> ---
> Frank Li (2):
> PCI: Add PCIE_MSG_CODE_PME_TURN_OFF message macro
> PCI: dwc: Add common send PME_Turn_Off message method
>
> Yoshihiro Shimoda (3):
> PCI: Add INTx Mechanism Messages macros
> PCI: dwc: Consolidate args of dw_pcie_prog_outbound_atu() into a structure
> PCI: dwc: Add outbound MSG TLPs support
>
> drivers/pci/controller/dwc/pcie-designware-ep.c | 21 ++--
> drivers/pci/controller/dwc/pcie-designware-host.c | 146 +++++++++++++++++++---
> drivers/pci/controller/dwc/pcie-designware.c | 54 ++++----
> drivers/pci/controller/dwc/pcie-designware.h | 22 +++-
> drivers/pci/pci.h | 20 +++
> 5 files changed, 199 insertions(+), 64 deletions(-)
> ---
> base-commit: e08fc59eee9991afa467d406d684d46d543299a9
> change-id: 20240130-pme_msg-dd2d81ee9886
>
> Best regards,
> ---
> Frank Li <Frank.Li@nxp.com>
>
prev parent reply other threads:[~2024-04-02 16:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 16:07 [PATCH v5 0/5] PCI: dwc: Add common pme_turn_off message by using outbound iATU Frank Li
2024-03-19 16:07 ` [PATCH v5 1/5] PCI: Add INTx Mechanism Messages macros Frank Li
2024-03-19 16:07 ` [PATCH v5 2/5] PCI: dwc: Consolidate args of dw_pcie_prog_outbound_atu() into a structure Frank Li
2024-03-19 16:07 ` [PATCH v5 3/5] PCI: dwc: Add outbound MSG TLPs support Frank Li
2024-03-19 16:07 ` [PATCH v5 4/5] PCI: Add PCIE_MSG_CODE_PME_TURN_OFF message macro Frank Li
2024-04-04 15:53 ` Manivannan Sadhasivam
2024-03-19 16:07 ` [PATCH v5 5/5] PCI: dwc: Add common send PME_Turn_Off message method Frank Li
2024-04-05 6:24 ` Manivannan Sadhasivam
2024-04-05 14:31 ` Frank Li
2024-04-06 4:01 ` Manivannan Sadhasivam
2024-04-08 15:11 ` Frank Li
2024-04-12 17:05 ` Manivannan Sadhasivam
2024-04-12 21:08 ` Frank Li
2024-04-14 10:32 ` Manivannan Sadhasivam
2024-04-02 16:15 ` Frank Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgwvPB/LbPRshVCy@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=imx@lists.linux.dev \
--cc=jingoohan1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).