From: Shashank Babu Chinta Venkata <quic_schintav@quicinc.com>
To: <agross@kernel.org>, <andersson@kernel.org>,
<konrad.dybcio@linaro.org>, <mani@kernel.org>
Cc: quic_msarkar@quicinc.com, quic_kraravin@quicinc.com,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Serge Semin" <fancer.lancer@gmail.com>,
"Conor Dooley" <conor.dooley@microchip.com>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: [PATCH v3 0/3] Add 16GT/s equalization and margining settings
Date: Thu, 18 Apr 2024 17:09:33 -0700 [thread overview]
Message-ID: <20240419001013.28788-1-quic_schintav@quicinc.com> (raw)
Add 16GT/s specific equalization and rx lane margining settings. These
settings are inline with respective PHY settings for 16GT/s
operation.
In addition, current QCOM EP and RC drivers do not share common
codebase which would result in code duplication. Hence, adding
common files for code reusability among RC and EP drivers.
v2 -> v3:
- Replaced FIELD_GET/FIELD_PREP macros for bit operations.
- Renamed cmn to common.
- Avoided unnecessary argument validations.
- Addressed review comments from Konrad and Mani.
v1 -> v2:
- Capitilized commit message to be inline with history
- Dropped stubs from header file.
- Moved Designware specific register offsets and masks to
pcie-designware.h header file.
- Applied settings based on bus data rate rather than link generation.
- Addressed review comments from Bjorn and Frank.
Shashank Babu Chinta Venkata (3):
PCI: qcom: Refactor common code
PCI: qcom: Add equalization settings for 16GT/s
PCI: qcom: Add rx margining settings for 16GT/s
drivers/pci/controller/dwc/Kconfig | 5 +
drivers/pci/controller/dwc/Makefile | 1 +
drivers/pci/controller/dwc/pcie-designware.h | 30 ++++
drivers/pci/controller/dwc/pcie-qcom-common.c | 129 ++++++++++++++++++
drivers/pci/controller/dwc/pcie-qcom-common.h | 14 ++
drivers/pci/controller/dwc/pcie-qcom-ep.c | 44 ++----
drivers/pci/controller/dwc/pcie-qcom.c | 72 ++--------
7 files changed, 201 insertions(+), 94 deletions(-)
create mode 100644 drivers/pci/controller/dwc/pcie-qcom-common.c
create mode 100644 drivers/pci/controller/dwc/pcie-qcom-common.h
--
2.43.2
next reply other threads:[~2024-04-19 0:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 0:09 Shashank Babu Chinta Venkata [this message]
2024-04-19 0:09 ` [PATCH v3 1/3] PCI: qcom: Refactor common code Shashank Babu Chinta Venkata
2024-04-22 14:58 ` Manivannan Sadhasivam
2024-04-19 0:09 ` [PATCH v3 2/3] PCI: qcom: Add equalization settings for 16GT/s Shashank Babu Chinta Venkata
2024-04-22 15:16 ` Manivannan Sadhasivam
2024-04-22 22:59 ` Konrad Dybcio
2024-04-19 0:09 ` [PATCH v3 3/3] PCI: qcom: Add rx margining " Shashank Babu Chinta Venkata
2024-04-22 15:20 ` Manivannan Sadhasivam
2024-04-22 22:58 ` Konrad Dybcio
2024-04-30 20:37 ` Shashank Babu Chinta Venkata
2024-05-01 23:13 ` Konrad Dybcio
2024-04-19 7:36 ` [PATCH v3 0/3] Add 16GT/s equalization and margining settings Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240419001013.28788-1-quic_schintav@quicinc.com \
--to=quic_schintav@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor.dooley@microchip.com \
--cc=fancer.lancer@gmail.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=quic_kraravin@quicinc.com \
--cc=quic_msarkar@quicinc.com \
--cc=robh@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).