From: Lukas Wunner <lukas@wunner.de>
To: Nam Cao <namcao@linutronix.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Yinghai Lu <yinghai@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rajesh Shah <rajesh.shah@intel.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 2/4] PCI: pciehp: bail out if pci_hp_add_bridge() fails
Date: Sat, 4 May 2024 10:54:15 +0200 [thread overview]
Message-ID: <ZjX3t1NerOlGBhzw@wunner.de> (raw)
In-Reply-To: <401e4044e05d52e4243ca7faa65d5ec8b19526b8.1714762038.git.namcao@linutronix.de>
On Fri, May 03, 2024 at 09:23:20PM +0200, Nam Cao wrote:
> If there is no bus number available for the downstream bus of the
> hot-plugged bridge, pci_hp_add_bridge() will fail. The driver proceeds
> regardless, and the kernel crashes.
>
> Abort if pci_hp_add_bridge() fails.
[...]
> --- a/drivers/pci/hotplug/pciehp_pci.c
> +++ b/drivers/pci/hotplug/pciehp_pci.c
> @@ -58,8 +58,13 @@ int pciehp_configure_device(struct controller *ctrl)
> goto out;
> }
>
> - for_each_pci_bridge(dev, parent)
> - pci_hp_add_bridge(dev);
> + for_each_pci_bridge(dev, parent) {
> + if (pci_hp_add_bridge(dev)) {
> + pci_stop_and_remove_bus_device(dev);
> + ret = -EINVAL;
> + goto out;
> + }
> + }
Is the pci_stop_and_remove_bus_device() really necessary here?
Why not just leave the bridge as is, without any child devices?
Thanks,
Lukas
next prev parent reply other threads:[~2024-05-04 8:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 19:23 [PATCH 0/4] check returned value of pci_hp_add_bridge() Nam Cao
2024-05-03 19:23 ` [PATCH 1/4] PCI: shpchp: bail out if pci_hp_add_bridge() fails Nam Cao
2024-05-03 19:23 ` [PATCH 2/4] PCI: pciehp: " Nam Cao
2024-05-03 21:23 ` Bjorn Helgaas
2024-05-03 21:41 ` Nam Cao
2024-05-04 8:54 ` Lukas Wunner [this message]
2024-05-04 9:35 ` Nam Cao
2024-05-04 9:51 ` Lukas Wunner
2024-05-04 10:56 ` Nam Cao
2024-05-04 15:02 ` Lukas Wunner
2024-05-04 15:48 ` Nam Cao
2024-05-03 19:23 ` [PATCH 3/4] PCI: hotplug: document unchecked return value of pci_hp_add_bridge() Nam Cao
2024-05-03 19:23 ` [PATCH 4/4] PCI: hotplug: remove TODO notes for sgi_hotplug Nam Cao
2024-05-03 21:29 ` [PATCH 0/4] check returned value of pci_hp_add_bridge() Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjX3t1NerOlGBhzw@wunner.de \
--to=lukas@wunner.de \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=namcao@linutronix.de \
--cc=rajesh.shah@intel.com \
--cc=stable@vger.kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).