From: Claudiu <claudiu.beznea@tuxon.dev>
To: gregkh@linuxfoundation.org, jirislaby@kernel.org,
geert+renesas@glider.be, ulf.hansson@linaro.org
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
linux-pm@vger.kernel.org, claudiu.beznea@tuxon.dev
Subject: [PATCH] serial: sh-sci: Call device_set_wakeup_path() for serial console
Date: Mon, 22 Apr 2024 14:11:23 +0300 [thread overview]
Message-ID: <20240422111123.1622967-1-claudiu.beznea.uj@bp.renesas.com> (raw)
From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
In case the SCI is used as a UART console, no_console_suspend is
available in bootargs and SCI is part of a software-controlled power
domain we need to call device_set_wakeup_path(). This lets the power
domain core code knows that this domain should not be powered off
durring system suspend. Otherwise, the SCI power domain is turned off,
nothing is printed while suspending and the suspend/resume process is
blocked. This was detected on the RZ/G3S SoC while adding support
for power domains.
Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
---
drivers/tty/serial/sh-sci.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
index 97031db26ae4..57a7f18e16e4 100644
--- a/drivers/tty/serial/sh-sci.c
+++ b/drivers/tty/serial/sh-sci.c
@@ -3441,8 +3441,12 @@ static __maybe_unused int sci_suspend(struct device *dev)
{
struct sci_port *sport = dev_get_drvdata(dev);
- if (sport)
+ if (sport) {
+ if (uart_console(&sport->port) && !console_suspend_enabled)
+ device_set_wakeup_path(dev);
+
uart_suspend_port(&sci_uart_driver, &sport->port);
+ }
return 0;
}
--
2.39.2
next reply other threads:[~2024-04-22 11:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 11:11 Claudiu [this message]
2024-04-23 7:27 ` [PATCH] serial: sh-sci: Call device_set_wakeup_path() for serial console Geert Uytterhoeven
2024-04-23 7:35 ` Peng Fan
2024-04-23 7:45 ` Geert Uytterhoeven
2024-04-23 12:10 ` claudiu beznea
2024-04-23 15:05 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240422111123.1622967-1-claudiu.beznea.uj@bp.renesas.com \
--to=claudiu.beznea@tuxon.dev \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).