From: Geert Uytterhoeven <geert@linux-m68k.org>
To: claudiu beznea <claudiu.beznea@tuxon.dev>
Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org,
ulf.hansson@linaro.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, linux-pm@vger.kernel.org,
Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH] serial: sh-sci: Call device_set_wakeup_path() for serial console
Date: Tue, 23 Apr 2024 17:05:27 +0200 [thread overview]
Message-ID: <CAMuHMdVoK_qC8JPdRUQQZvNNLzuufWidxjee2HW7KrDGiNJCMQ@mail.gmail.com> (raw)
In-Reply-To: <3d8925a8-32ee-467a-aca7-d4a04f26821f@tuxon.dev>
Hi Claudiu,
On Tue, Apr 23, 2024 at 2:47 PM claudiu beznea <claudiu.beznea@tuxon.dev> wrote:
> On 23.04.2024 10:27, Geert Uytterhoeven wrote:
> > On Mon, Apr 22, 2024 at 1:11 PM Claudiu <claudiu.beznea@tuxon.dev> wrote:
> >> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> >>
> >> In case the SCI is used as a UART console, no_console_suspend is
> >> available in bootargs and SCI is part of a software-controlled power
> >> domain we need to call device_set_wakeup_path(). This lets the power
> >> domain core code knows that this domain should not be powered off
> >
> > know
> >
> >> durring system suspend. Otherwise, the SCI power domain is turned off,
> >
> > during
> >
> >> nothing is printed while suspending and the suspend/resume process is
> >> blocked. This was detected on the RZ/G3S SoC while adding support
> >> for power domains.
> >>
> >> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> > If this works, we can remove the console_suspend_enabled handling
> > from drivers/pmdomain/renesas/rmobile-sysc.c, and revert commit
> > 309864dcf92b76fc ("genpd: imx: scu-pd: do not power off console if
> > no_console_suspend").
>
> OK, first I'll go with this patch and after things settles down with it
> I'll propose changes for rmobile-sysc and imx. Is this ok for you?
I have already made these changes to rmobile-sysc locally to test
your patch ;-)
It works fine on R-Mobile APE6, so
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
prev parent reply other threads:[~2024-04-23 15:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 11:11 [PATCH] serial: sh-sci: Call device_set_wakeup_path() for serial console Claudiu
2024-04-23 7:27 ` Geert Uytterhoeven
2024-04-23 7:35 ` Peng Fan
2024-04-23 7:45 ` Geert Uytterhoeven
2024-04-23 12:10 ` claudiu beznea
2024-04-23 15:05 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdVoK_qC8JPdRUQQZvNNLzuufWidxjee2HW7KrDGiNJCMQ@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).