From: Lee Jones <lee@kernel.org>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Tzung-Bi Shih <tzungbi@kernel.org>,
linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev,
Mario Limonciello <mario.limonciello@amd.com>,
"Dustin L. Howett" <dustin@howett.net>,
Sebastian Reichel <sre@kernel.org>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/2] platform/chrome: cros_ec_framework_laptop: introduce driver
Date: Tue, 7 May 2024 09:25:14 +0100 [thread overview]
Message-ID: <20240507082514.GT1227636@google.com> (raw)
In-Reply-To: <20240505-cros_ec-framework-v1-1-402662d6276b@weissschuh.net>
On Sun, 05 May 2024, Thomas Weißschuh wrote:
> Framework Laptops are using embedded controller firmware based on the
> ChromeOS EC project.
> In addition to the standard upstream commands, some vendor-specific
> ones are implemented.
>
> Add a driver for those custom EC commands.
>
> At first, provide an empty driver that only takes care of scaffolding and
> device binding.
> Further patches will add functionality to the driver.
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> MAINTAINERS | 5 ++
> drivers/mfd/cros_ec_dev.c | 13 ++++++
I do not see any build-time deps here.
Please split this change out.
> drivers/platform/chrome/Kconfig | 11 +++++
> drivers/platform/chrome/Makefile | 1 +
> drivers/platform/chrome/cros_ec_framework_laptop.c | 53 ++++++++++++++++++++++
> 5 files changed, 83 insertions(+)
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-05-07 8:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-05 20:56 [PATCH 0/2] platform/chrome: cros_ec_framework_laptop: new driver Thomas Weißschuh
2024-05-05 20:56 ` [PATCH 1/2] platform/chrome: cros_ec_framework_laptop: introduce driver Thomas Weißschuh
2024-05-06 13:10 ` Limonciello, Mario
2024-05-06 17:48 ` Thomas Weißschuh
2024-05-07 8:25 ` Lee Jones [this message]
2024-05-05 20:56 ` [PATCH 2/2] platform/chrome: cros_ec_framework_laptop: implement battery charge thresholds Thomas Weißschuh
2024-05-06 6:09 ` [PATCH 0/2] platform/chrome: cros_ec_framework_laptop: new driver Thomas Weißschuh
2024-05-06 13:09 ` Limonciello, Mario
2024-05-06 17:43 ` Thomas Weißschuh
2024-05-06 18:29 ` Dustin Howett
2024-05-07 6:11 ` Thomas Weißschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240507082514.GT1227636@google.com \
--to=lee@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dustin@howett.net \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=mario.limonciello@amd.com \
--cc=sre@kernel.org \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).