From: "Thomas Weißschuh" <linux@weissschuh.net>
To: Lee Jones <lee@kernel.org>, Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Tzung-Bi Shih <tzungbi@kernel.org>
Cc: linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev,
Mario Limonciello <mario.limonciello@amd.com>,
"Dustin L. Howett" <dustin@howett.net>,
Sebastian Reichel <sre@kernel.org>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 0/2] platform/chrome: cros_ec_framework_laptop: new driver
Date: Mon, 6 May 2024 08:09:56 +0200 [thread overview]
Message-ID: <613369f9-42c5-4a59-b83f-45bd1773ffe4@t-8ch.de> (raw)
In-Reply-To: <20240505-cros_ec-framework-v1-0-402662d6276b@weissschuh.net>
On 2024-05-05 22:56:33+0000, Thomas Weißschuh wrote:
> Framework Laptops are using embedded controller firmware based on the
> ChromeOS EC project.
> In addition to the standard upstream commands some vendor-specific
> commands are implemented.
>
> Add a driver that implements battery charge thresholds using these
> custom commands.
It turns out that standard ChromesOS EC defines EC_CMD_CHARGE_CONTROL.
The kernel headers however only define v1 of the protocol, which is very
limited.
But in the upstream firmware repo there is a v3 which is much better.
The Framework laptop only implements v2 which is also fine.
Given that v3 was only introduced late last year, it seems better to
stick to v2 anyways for now.
So please disregard Patch 2, I'll see on how to use this via a normal
cros_ec driver.
There are some other Framework-only features that will use Patch 1,
so feedback for that would still be good.
> Patch 1 adds the general scaffolding and device binding.
> Patch 2 implements the battery charge thresholds.
>
> This series is based on
> https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> Thomas Weißschuh (2):
> platform/chrome: cros_ec_framework_laptop: introduce driver
> platform/chrome: cros_ec_framework_laptop: implement battery charge thresholds
>
> MAINTAINERS | 5 +
> drivers/mfd/cros_ec_dev.c | 13 ++
> drivers/platform/chrome/Kconfig | 11 ++
> drivers/platform/chrome/Makefile | 1 +
> drivers/platform/chrome/cros_ec_framework_laptop.c | 173 +++++++++++++++++++++
> 5 files changed, 203 insertions(+)
> ---
> base-commit: 2fbe479c0024e1c6b992184a799055e19932aa48
> change-id: 20240505-cros_ec-framework-10e627c46a0a
>
> Best regards,
> --
> Thomas Weißschuh <linux@weissschuh.net>
>
next prev parent reply other threads:[~2024-05-06 6:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-05 20:56 [PATCH 0/2] platform/chrome: cros_ec_framework_laptop: new driver Thomas Weißschuh
2024-05-05 20:56 ` [PATCH 1/2] platform/chrome: cros_ec_framework_laptop: introduce driver Thomas Weißschuh
2024-05-06 13:10 ` Limonciello, Mario
2024-05-06 17:48 ` Thomas Weißschuh
2024-05-07 8:25 ` Lee Jones
2024-05-05 20:56 ` [PATCH 2/2] platform/chrome: cros_ec_framework_laptop: implement battery charge thresholds Thomas Weißschuh
2024-05-06 6:09 ` Thomas Weißschuh [this message]
2024-05-06 13:09 ` [PATCH 0/2] platform/chrome: cros_ec_framework_laptop: new driver Limonciello, Mario
2024-05-06 17:43 ` Thomas Weißschuh
2024-05-06 18:29 ` Dustin Howett
2024-05-07 6:11 ` Thomas Weißschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=613369f9-42c5-4a59-b83f-45bd1773ffe4@t-8ch.de \
--to=linux@weissschuh.net \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dustin@howett.net \
--cc=groeck@chromium.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=sre@kernel.org \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).