From: Guenter Roeck <linux@roeck-us.net>
To: Billy Tsai <billy_tsai@aspeedtech.com>
Cc: jdelvare@suse.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
joel@jms.id.au, andrew@codeconstruct.com.au, corbet@lwn.net,
u.kleine-koenig@pengutronix.de, p.zabel@pengutronix.de,
naresh.solanki@9elements.com, linux-hwmon@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-pwm@vger.kernel.org,
BMC-SW@aspeedtech.com, patrick@stwcx.xyz,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v14 1/3] dt-bindings: hwmon: fan: Add fan binding to schema
Date: Thu, 7 Mar 2024 10:46:47 -0800 [thread overview]
Message-ID: <11ad14bd-bf25-4c07-b704-46a744071ead@roeck-us.net> (raw)
In-Reply-To: <20240221104025.1306227-2-billy_tsai@aspeedtech.com>
On Wed, Feb 21, 2024 at 06:40:23PM +0800, Billy Tsai wrote:
> From: Naresh Solanki <naresh.solanki@9elements.com>
>
> Add common fan properties bindings to a schema.
>
> Bindings for fan controllers can reference the common schema for the
> fan
>
> child nodes:
>
> patternProperties:
> "^fan@[0-2]":
> type: object
> $ref: fan-common.yaml#
> unevaluatedProperties: false
>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
> Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
Applied to hwmon-next. There have been a couple of questions, specifically:
- min-rpm of 1000 seems low. Fans with higher minimum RPM
are known to exist.
- A default value of '2' was suggested for pulses-per-revolution.
Those questions can be addressed with subsequent patches if needed.
Guenter
next prev parent reply other threads:[~2024-03-07 18:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 10:40 [PATCH v14 0/3] Support pwm/tach driver for aspeed ast26xx Billy Tsai
2024-02-21 10:40 ` [PATCH v14 1/3] dt-bindings: hwmon: fan: Add fan binding to schema Billy Tsai
2024-03-07 18:46 ` Guenter Roeck [this message]
2024-02-21 10:40 ` [PATCH v14 2/3] dt-bindings: hwmon: Support Aspeed g6 PWM TACH Control Billy Tsai
2024-02-23 13:51 ` Rob Herring
2024-03-07 18:47 ` Guenter Roeck
2024-02-21 10:40 ` [PATCH v14 3/3] hwmon: (aspeed-g6-pwm-tacho): Support for ASPEED g6 PWM/Fan tach Billy Tsai
2024-02-21 13:14 ` Philipp Zabel
2024-03-07 18:51 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11ad14bd-bf25-4c07-b704-46a744071ead@roeck-us.net \
--to=linux@roeck-us.net \
--cc=BMC-SW@aspeedtech.com \
--cc=andrew@codeconstruct.com.au \
--cc=billy_tsai@aspeedtech.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=naresh.solanki@9elements.com \
--cc=p.zabel@pengutronix.de \
--cc=patrick@stwcx.xyz \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).