From: Guenter Roeck <linux@roeck-us.net>
To: Billy Tsai <billy_tsai@aspeedtech.com>
Cc: jdelvare@suse.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
joel@jms.id.au, andrew@codeconstruct.com.au, corbet@lwn.net,
u.kleine-koenig@pengutronix.de, p.zabel@pengutronix.de,
naresh.solanki@9elements.com, linux-hwmon@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-pwm@vger.kernel.org,
BMC-SW@aspeedtech.com, patrick@stwcx.xyz
Subject: Re: [PATCH v14 3/3] hwmon: (aspeed-g6-pwm-tacho): Support for ASPEED g6 PWM/Fan tach
Date: Thu, 7 Mar 2024 10:51:48 -0800 [thread overview]
Message-ID: <771b185f-98ee-475d-8075-86399b3dfe09@roeck-us.net> (raw)
In-Reply-To: <20240221104025.1306227-4-billy_tsai@aspeedtech.com>
On Wed, Feb 21, 2024 at 06:40:25PM +0800, Billy Tsai wrote:
> The driver support two functions: PWM and Tachometer. The PWM feature can
> handle up to 16 output ports, while the Tachometer can monitor to up to 16
> input ports as well. This driver implements them by exposing two kernel
> subsystems: PWM and HWMON. The PWM subsystem can be utilized alongside
> existing drivers for controlling elements such as fans (pwm-fan.c),
> beepers (pwm-beeper.c) and so on. Through the HWMON subsystem, the driver
> provides sysfs interfaces for fan.
>
> Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
Applied to hwmon-next. There was an outstanding suggestion:
> > +static int aspeed_pwm_tach_remove(struct platform_device *pdev)
> > +{
> > + struct aspeed_pwm_tach_data *priv = platform_get_drvdata(pdev);
> > +
> > + reset_control_assert(priv->reset);
>
> This is already done by aspeed_pwm_tach_reset_assert(), looks like
> aspeed_pwm_tach_remove() can be removed. With that, priv->reset can
> become a local variable in aspeed_pwm_tach_probe().
I'll be happy to apply a follow-up patch making this change.
Thanks,
Guenter
prev parent reply other threads:[~2024-03-07 18:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 10:40 [PATCH v14 0/3] Support pwm/tach driver for aspeed ast26xx Billy Tsai
2024-02-21 10:40 ` [PATCH v14 1/3] dt-bindings: hwmon: fan: Add fan binding to schema Billy Tsai
2024-03-07 18:46 ` Guenter Roeck
2024-02-21 10:40 ` [PATCH v14 2/3] dt-bindings: hwmon: Support Aspeed g6 PWM TACH Control Billy Tsai
2024-02-23 13:51 ` Rob Herring
2024-03-07 18:47 ` Guenter Roeck
2024-02-21 10:40 ` [PATCH v14 3/3] hwmon: (aspeed-g6-pwm-tacho): Support for ASPEED g6 PWM/Fan tach Billy Tsai
2024-02-21 13:14 ` Philipp Zabel
2024-03-07 18:51 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=771b185f-98ee-475d-8075-86399b3dfe09@roeck-us.net \
--to=linux@roeck-us.net \
--cc=BMC-SW@aspeedtech.com \
--cc=andrew@codeconstruct.com.au \
--cc=billy_tsai@aspeedtech.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=naresh.solanki@9elements.com \
--cc=p.zabel@pengutronix.de \
--cc=patrick@stwcx.xyz \
--cc=robh+dt@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).