From: Rob Herring <robh@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: "Wenhua Lin" <Wenhua.Lin@unisoc.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Orson Zhai" <orsonzhai@gmail.com>,
"Baolin Wang" <baolin.wang@linux.alibaba.com>,
"Chunyan Zhang" <zhang.lyra@gmail.com>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"wenhua lin" <wenhua.lin1994@gmail.com>,
"Xiongpeng Wu" <xiongpeng.wu@unisoc.com>,
"zhaochen su" <zhaochen.su29@gmail.com>,
"Zhaochen Su" <Zhaochen.Su@unisoc.com>,
"Xiaolong Wang" <Xiaolong.Wang@unisoc.com>
Subject: Re: [PATCH V2 4/6] dt-bindings: pwm: sprd: Convert to YAML
Date: Tue, 30 Jan 2024 16:17:55 -0600 [thread overview]
Message-ID: <20240130221755.GA2514791-robh@kernel.org> (raw)
In-Reply-To: <20240125-sleeve-defeat-61f74942e2d9@spud>
On Thu, Jan 25, 2024 at 05:31:48PM +0000, Conor Dooley wrote:
> Hey,
>
> On Thu, Jan 25, 2024 at 10:55:31AM +0800, Wenhua Lin wrote:
> > Convert Spreadtrum PWM controller bindings to DT schema.
> >
> > Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com>
> > ---
> > .../devicetree/bindings/pwm/pwm-sprd.txt | 40 --------
> > .../devicetree/bindings/pwm/pwm-sprd.yaml | 93 +++++++++++++++++++
> > 2 files changed, 93 insertions(+), 40 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/pwm/pwm-sprd.txt
> > create mode 100644 Documentation/devicetree/bindings/pwm/pwm-sprd.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/pwm/pwm-sprd.txt b/Documentation/devicetree/bindings/pwm/pwm-sprd.txt
> > deleted file mode 100644
> > index 87b206fd0618..000000000000
> > --- a/Documentation/devicetree/bindings/pwm/pwm-sprd.txt
> > +++ /dev/null
> > @@ -1,40 +0,0 @@
> > -Spreadtrum PWM controller
> > -
> > -Spreadtrum SoCs PWM controller provides 4 PWM channels.
> > -
> > -Required properties:
> > -- compatible : Should be "sprd,ums512-pwm".
> > -- reg: Physical base address and length of the controller's registers.
> > -- clocks: The phandle and specifier referencing the controller's clocks.
> > -- clock-names: Should contain following entries:
> > - "pwmn": used to derive the functional clock for PWM channel n (n range: 0 ~ 3).
> > - "enablen": for PWM channel n enable clock (n range: 0 ~ 3).
> > -- #pwm-cells: Should be 2. See pwm.yaml in this directory for a description of
> > - the cells format.
> > -
> > -Optional properties:
> > -- assigned-clocks: Reference to the PWM clock entries.
> > -- assigned-clock-parents: The phandle of the parent clock of PWM clock.
> > -
> > -Example:
> > - pwms: pwm@32260000 {
> > - compatible = "sprd,ums512-pwm";
> > - reg = <0 0x32260000 0 0x10000>;
> > - clock-names = "pwm0", "enable0",
> > - "pwm1", "enable1",
> > - "pwm2", "enable2",
> > - "pwm3", "enable3";
> > - clocks = <&aon_clk CLK_PWM0>, <&aonapb_gate CLK_PWM0_EB>,
> > - <&aon_clk CLK_PWM1>, <&aonapb_gate CLK_PWM1_EB>,
> > - <&aon_clk CLK_PWM2>, <&aonapb_gate CLK_PWM2_EB>,
> > - <&aon_clk CLK_PWM3>, <&aonapb_gate CLK_PWM3_EB>;
> > - assigned-clocks = <&aon_clk CLK_PWM0>,
> > - <&aon_clk CLK_PWM1>,
> > - <&aon_clk CLK_PWM2>,
> > - <&aon_clk CLK_PWM3>;
> > - assigned-clock-parents = <&ext_26m>,
> > - <&ext_26m>,
> > - <&ext_26m>,
> > - <&ext_26m>;
> > - #pwm-cells = <2>;
> > - };
> > diff --git a/Documentation/devicetree/bindings/pwm/pwm-sprd.yaml b/Documentation/devicetree/bindings/pwm/pwm-sprd.yaml
> > new file mode 100644
> > index 000000000000..81c5fd688c3c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/pwm/pwm-sprd.yaml
> > @@ -0,0 +1,93 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +# Copyright 2023 Unisoc Inc.
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/pwm/pwm-sprd.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Spreadtrum PWM controller
> > +
> > +maintainers:
> > + - Orson Zhai <orsonzhai@gmail.com>
> > + - Baolin Wang <baolin.wang7@gmail.com>
> > + - Chunyan Zhang <zhang.lyra@gmail.com>
> > +
> > +description: |
>
> The | here is not need, you have no formatting to preserve.
>
> > + Spreadtrum SoCs PWM controller provides 4 PWM channels.
> > +
> > +allOf:
> > + - $ref: pwm.yaml#
> > +
> > +properties:
> > + compatible:
> > + items:
> > + - enum:
> > + - sprd,ums512-pwm
>
> this is just
>
> compatible:
> const: sprd,ums512-pwm
>
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + clocks:
> > + minItems: 8
> > + maxItems: 8
> > +
> > + clock-names:
> > + items:
> > + - const: pwm0
> > + - const: enable0
> > + - const: pwm1
> > + - const: enable1
> > + - const: pwm2
> > + - const: enable2
> > + - const: pwm3
> > + - const: enable3
>
> > + description: |
> > + Should contain following entries:
> > + "pwmn": used to derive the functional clock for PWM channel n (n range: 0 ~ 3).
> > + "enablen": for PWM channel n enable clock (n range: 0 ~ 3).
>
> I would drop this description from here, and create an items list under
> clocks, describing each clock. You can then drop the "minItems: 8" &
> "maxItems: 8" from there.
>
> > +
> > + assigned-clocks:
> > + minItems: 4
> > + maxItems: 4
> > +
> > + assigned-clock-parents:
> > + minItems: 4
> > + maxItems: 4
Also, drop assigned-clock* here and from the example. It's outside the
scope of bindings.
Rob
next prev parent reply other threads:[~2024-01-30 22:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 2:55 [PATCH V2 0/6] pwm: sprd: Modification of UNISOC Platform PWM Driver Wenhua Lin
2024-01-25 2:55 ` [PATCH V2 1/6] pwm: sprd: Add support for UMS9620 Wenhua Lin
2024-01-26 7:24 ` Uwe Kleine-König
2024-01-25 2:55 ` [PATCH V2 2/6] pwm: sprd: Improve the pwm backlight control function Wenhua Lin
2024-01-25 7:20 ` Chunyan Zhang
2024-01-25 21:13 ` Uwe Kleine-König
2024-01-25 2:55 ` [PATCH V2 3/6] pwm: sprd: Optimize the calculation method of duty Wenhua Lin
2024-01-26 7:30 ` Uwe Kleine-König
2024-01-25 2:55 ` [PATCH V2 4/6] dt-bindings: pwm: sprd: Convert to YAML Wenhua Lin
2024-01-25 17:31 ` Conor Dooley
2024-01-30 22:17 ` Rob Herring [this message]
2024-01-25 2:55 ` [PATCH V2 5/6] pwm: sprd: Add sprd,ums9620-pwm compatible Wenhua Lin
2024-01-25 21:08 ` Uwe Kleine-König
2024-01-25 2:55 ` [PATCH V2 6/6] dt-bindings: pwm: sprd: Add sprd,mod attribute Wenhua Lin
2024-01-25 17:24 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240130221755.GA2514791-robh@kernel.org \
--to=robh@kernel.org \
--cc=Wenhua.Lin@unisoc.com \
--cc=Xiaolong.Wang@unisoc.com \
--cc=Zhaochen.Su@unisoc.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wenhua.lin1994@gmail.com \
--cc=xiongpeng.wu@unisoc.com \
--cc=zhang.lyra@gmail.com \
--cc=zhaochen.su29@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).