From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Wenhua Lin <Wenhua.Lin@unisoc.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
wenhua lin <wenhua.lin1994@gmail.com>,
Xiongpeng Wu <xiongpeng.wu@unisoc.com>,
zhaochen su <zhaochen.su29@gmail.com>,
Zhaochen Su <Zhaochen.Su@unisoc.com>,
Xiaolong Wang <Xiaolong.Wang@unisoc.com>
Subject: Re: [PATCH V2 1/6] pwm: sprd: Add support for UMS9620
Date: Fri, 26 Jan 2024 08:24:00 +0100 [thread overview]
Message-ID: <jco3xlugbnpfpl7xq7dagpvrp57wlqjvjff7mhuc2yynohu2xc@zht3pus4vfrz> (raw)
In-Reply-To: <20240125025533.10315-2-Wenhua.Lin@unisoc.com>
[-- Attachment #1: Type: text/plain, Size: 818 bytes --]
Hello,
On Thu, Jan 25, 2024 at 10:55:28AM +0800, Wenhua Lin wrote:
> The PMW unit on the current Unisoc's SoCs has 4 channels but has different
> address offsets. On UMS512, they are 0x0, 0x20, 0x40, 0x60 respectively,
> while are 0x0, 0x4000, 0x8000, 0xC000 on UMS9620.
I just sent feedback to (implicit) v1 of this patch and only realized
now there is a v2 already. My feedback given there also applies to this
patch. So I'm marking also this patch as "changes requested" in
patchwork, please look at
https://lore.kernel.org/linux-pwm/bvnhi4qeczrmlmaog6drlztg4x6ubozjzu57sukpejme7xecqc@724g62vjgxrq/T/#u
for the details.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-01-26 7:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 2:55 [PATCH V2 0/6] pwm: sprd: Modification of UNISOC Platform PWM Driver Wenhua Lin
2024-01-25 2:55 ` [PATCH V2 1/6] pwm: sprd: Add support for UMS9620 Wenhua Lin
2024-01-26 7:24 ` Uwe Kleine-König [this message]
2024-01-25 2:55 ` [PATCH V2 2/6] pwm: sprd: Improve the pwm backlight control function Wenhua Lin
2024-01-25 7:20 ` Chunyan Zhang
2024-01-25 21:13 ` Uwe Kleine-König
2024-01-25 2:55 ` [PATCH V2 3/6] pwm: sprd: Optimize the calculation method of duty Wenhua Lin
2024-01-26 7:30 ` Uwe Kleine-König
2024-01-25 2:55 ` [PATCH V2 4/6] dt-bindings: pwm: sprd: Convert to YAML Wenhua Lin
2024-01-25 17:31 ` Conor Dooley
2024-01-30 22:17 ` Rob Herring
2024-01-25 2:55 ` [PATCH V2 5/6] pwm: sprd: Add sprd,ums9620-pwm compatible Wenhua Lin
2024-01-25 21:08 ` Uwe Kleine-König
2024-01-25 2:55 ` [PATCH V2 6/6] dt-bindings: pwm: sprd: Add sprd,mod attribute Wenhua Lin
2024-01-25 17:24 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jco3xlugbnpfpl7xq7dagpvrp57wlqjvjff7mhuc2yynohu2xc@zht3pus4vfrz \
--to=u.kleine-koenig@pengutronix.de \
--cc=Wenhua.Lin@unisoc.com \
--cc=Xiaolong.Wang@unisoc.com \
--cc=Zhaochen.Su@unisoc.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=robh+dt@kernel.org \
--cc=wenhua.lin1994@gmail.com \
--cc=xiongpeng.wu@unisoc.com \
--cc=zhang.lyra@gmail.com \
--cc=zhaochen.su29@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).