* [PATCH 0/8] sched: Remove unused TASK_SIZE_OF
@ 2021-12-21 17:00 guoren
2021-12-21 17:00 ` [PATCH 1/8] " guoren
` (7 more replies)
0 siblings, 8 replies; 14+ messages in thread
From: guoren @ 2021-12-21 17:00 UTC (permalink / raw)
To: guoren, will, tglx, benh, arnd, mingo, peterz, juri.lelli
Cc: linux-kernel, linux-riscv, linux-s390, sparclinux, linuxppc-dev,
inux-parisc, linux-mips, linux-arm-kernel, x86, Guo Ren
From: Guo Ren <guoren@linux.alibaba.com>
This macro isn't used in Linux, now. Delete in include/linux/sched.h
and arch's include/asm. This would confuse people who are
implementing the COMPAT feature for architecture.
Guo Ren (8):
sched: Remove unused TASK_SIZE_OF
sched: x86: Remove unused TASK_SIZE_OF
sched: sparc: Remove unused TASK_SIZE_OF
sched: powerpc: Remove unused TASK_SIZE_OF
sched: s390: Remove unused TASK_SIZE_OF
sched: parisc: Remove unused TASK_SIZE_OF
sched: arm64: Remove unused TASK_SIZE_OF
sched: mips: Remove unused TASK_SIZE_OF
arch/arm64/include/asm/processor.h | 2 --
arch/mips/include/asm/processor.h | 3 ---
arch/parisc/include/asm/processor.h | 3 +--
arch/powerpc/include/asm/task_size_64.h | 6 ++----
arch/s390/include/asm/processor.h | 3 +--
arch/sparc/include/asm/processor_64.h | 3 ---
arch/x86/include/asm/page_64_types.h | 2 --
include/linux/sched.h | 4 ----
8 files changed, 4 insertions(+), 22 deletions(-)
--
2.25.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 1/8] sched: Remove unused TASK_SIZE_OF
2021-12-21 17:00 [PATCH 0/8] sched: Remove unused TASK_SIZE_OF guoren
@ 2021-12-21 17:00 ` guoren
2021-12-21 17:28 ` Arnd Bergmann
2021-12-21 17:00 ` [PATCH 2/8] sched: x86: " guoren
` (6 subsequent siblings)
7 siblings, 1 reply; 14+ messages in thread
From: guoren @ 2021-12-21 17:00 UTC (permalink / raw)
To: guoren, will, tglx, benh, arnd, mingo, peterz, juri.lelli
Cc: linux-kernel, linux-riscv, linux-s390, sparclinux, linuxppc-dev,
inux-parisc, linux-mips, linux-arm-kernel, x86, Guo Ren
From: Guo Ren <guoren@linux.alibaba.com>
This macro isn't used in Linux, now. Delete in include/linux/sched.h
and arch's include/asm. This would confuse people who are
implementing the COMPAT feature for architecture.
Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
---
include/linux/sched.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/include/linux/sched.h b/include/linux/sched.h
index 78c351e35fec..8e5689d06ac8 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -2166,10 +2166,6 @@ static inline bool vcpu_is_preempted(int cpu)
extern long sched_setaffinity(pid_t pid, const struct cpumask *new_mask);
extern long sched_getaffinity(pid_t pid, struct cpumask *mask);
-#ifndef TASK_SIZE_OF
-#define TASK_SIZE_OF(tsk) TASK_SIZE
-#endif
-
#ifdef CONFIG_SMP
/* Returns effective CPU energy utilization, as seen by the scheduler */
unsigned long sched_cpu_util(int cpu, unsigned long max);
--
2.25.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 2/8] sched: x86: Remove unused TASK_SIZE_OF
2021-12-21 17:00 [PATCH 0/8] sched: Remove unused TASK_SIZE_OF guoren
2021-12-21 17:00 ` [PATCH 1/8] " guoren
@ 2021-12-21 17:00 ` guoren
2021-12-21 17:00 ` [PATCH 3/8] sched: sparc: " guoren
` (5 subsequent siblings)
7 siblings, 0 replies; 14+ messages in thread
From: guoren @ 2021-12-21 17:00 UTC (permalink / raw)
To: guoren, will, tglx, benh, arnd, mingo, peterz, juri.lelli
Cc: linux-kernel, linux-riscv, linux-s390, sparclinux, linuxppc-dev,
inux-parisc, linux-mips, linux-arm-kernel, x86, Guo Ren
From: Guo Ren <guoren@linux.alibaba.com>
This macro isn't used in Linux, now. Delete in
include/linux/sched.h and arch's include/asm.
Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
---
arch/x86/include/asm/page_64_types.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/x86/include/asm/page_64_types.h b/arch/x86/include/asm/page_64_types.h
index e9e2c3ba5923..6191cf417c31 100644
--- a/arch/x86/include/asm/page_64_types.h
+++ b/arch/x86/include/asm/page_64_types.h
@@ -74,8 +74,6 @@
IA32_PAGE_OFFSET : DEFAULT_MAP_WINDOW)
#define TASK_SIZE (test_thread_flag(TIF_ADDR32) ? \
IA32_PAGE_OFFSET : TASK_SIZE_MAX)
-#define TASK_SIZE_OF(child) ((test_tsk_thread_flag(child, TIF_ADDR32)) ? \
- IA32_PAGE_OFFSET : TASK_SIZE_MAX)
#define STACK_TOP TASK_SIZE_LOW
#define STACK_TOP_MAX TASK_SIZE_MAX
--
2.25.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 3/8] sched: sparc: Remove unused TASK_SIZE_OF
2021-12-21 17:00 [PATCH 0/8] sched: Remove unused TASK_SIZE_OF guoren
2021-12-21 17:00 ` [PATCH 1/8] " guoren
2021-12-21 17:00 ` [PATCH 2/8] sched: x86: " guoren
@ 2021-12-21 17:00 ` guoren
2021-12-21 17:00 ` [PATCH 4/8] sched: powerpc: " guoren
` (4 subsequent siblings)
7 siblings, 0 replies; 14+ messages in thread
From: guoren @ 2021-12-21 17:00 UTC (permalink / raw)
To: guoren, will, tglx, benh, arnd, mingo, peterz, juri.lelli
Cc: linux-kernel, linux-riscv, linux-s390, sparclinux, linuxppc-dev,
inux-parisc, linux-mips, linux-arm-kernel, x86, Guo Ren
From: Guo Ren <guoren@linux.alibaba.com>
This macro isn't used in Linux, now. Delete in
include/linux/sched.h and arch's include/asm.
Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
---
arch/sparc/include/asm/processor_64.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/sparc/include/asm/processor_64.h b/arch/sparc/include/asm/processor_64.h
index ae851e8fce4c..628349fc4cdd 100644
--- a/arch/sparc/include/asm/processor_64.h
+++ b/arch/sparc/include/asm/processor_64.h
@@ -27,9 +27,6 @@
#define VPTE_SIZE (1 << (VA_BITS - PAGE_SHIFT + 3))
#endif
-#define TASK_SIZE_OF(tsk) \
- (test_tsk_thread_flag(tsk,TIF_32BIT) ? \
- (1UL << 32UL) : ((unsigned long)-VPTE_SIZE))
#define TASK_SIZE \
(test_thread_flag(TIF_32BIT) ? \
(1UL << 32UL) : ((unsigned long)-VPTE_SIZE))
--
2.25.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 4/8] sched: powerpc: Remove unused TASK_SIZE_OF
2021-12-21 17:00 [PATCH 0/8] sched: Remove unused TASK_SIZE_OF guoren
` (2 preceding siblings ...)
2021-12-21 17:00 ` [PATCH 3/8] sched: sparc: " guoren
@ 2021-12-21 17:00 ` guoren
2021-12-21 18:43 ` Christophe Leroy
2021-12-21 17:00 ` [PATCH 5/8] sched: s390: " guoren
` (3 subsequent siblings)
7 siblings, 1 reply; 14+ messages in thread
From: guoren @ 2021-12-21 17:00 UTC (permalink / raw)
To: guoren, will, tglx, benh, arnd, mingo, peterz, juri.lelli
Cc: linux-kernel, linux-riscv, linux-s390, sparclinux, linuxppc-dev,
inux-parisc, linux-mips, linux-arm-kernel, x86, Guo Ren
From: Guo Ren <guoren@linux.alibaba.com>
This macro isn't used in Linux sched, now. Delete in
include/linux/sched.h and arch's include/asm.
Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
---
arch/powerpc/include/asm/task_size_64.h | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/include/asm/task_size_64.h b/arch/powerpc/include/asm/task_size_64.h
index c993482237ed..7e2eca4fac4d 100644
--- a/arch/powerpc/include/asm/task_size_64.h
+++ b/arch/powerpc/include/asm/task_size_64.h
@@ -44,12 +44,10 @@
*/
#define TASK_SIZE_USER32 (0x0000000100000000UL - (1 * PAGE_SIZE))
-#define TASK_SIZE_OF(tsk) \
- (test_tsk_thread_flag(tsk, TIF_32BIT) ? TASK_SIZE_USER32 : \
+#define TASK_SIZE \
+ (test_tsk_thread_flag(current, TIF_32BIT) ? TASK_SIZE_USER32 : \
TASK_SIZE_USER64)
-#define TASK_SIZE TASK_SIZE_OF(current)
-
#define TASK_UNMAPPED_BASE_USER32 (PAGE_ALIGN(TASK_SIZE_USER32 / 4))
#define TASK_UNMAPPED_BASE_USER64 (PAGE_ALIGN(DEFAULT_MAP_WINDOW_USER64 / 4))
--
2.25.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 5/8] sched: s390: Remove unused TASK_SIZE_OF
2021-12-21 17:00 [PATCH 0/8] sched: Remove unused TASK_SIZE_OF guoren
` (3 preceding siblings ...)
2021-12-21 17:00 ` [PATCH 4/8] sched: powerpc: " guoren
@ 2021-12-21 17:00 ` guoren
2021-12-21 17:00 ` [PATCH 6/8] sched: parisc: " guoren
` (2 subsequent siblings)
7 siblings, 0 replies; 14+ messages in thread
From: guoren @ 2021-12-21 17:00 UTC (permalink / raw)
To: guoren, will, tglx, benh, arnd, mingo, peterz, juri.lelli
Cc: linux-kernel, linux-riscv, linux-s390, sparclinux, linuxppc-dev,
inux-parisc, linux-mips, linux-arm-kernel, x86, Guo Ren
From: Guo Ren <guoren@linux.alibaba.com>
This macro isn't used in Linux sched, now. Delete in
include/linux/sched.h and arch's include/asm.
Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
---
arch/s390/include/asm/processor.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/s390/include/asm/processor.h b/arch/s390/include/asm/processor.h
index f54c152bf2bf..605bc57a5ffc 100644
--- a/arch/s390/include/asm/processor.h
+++ b/arch/s390/include/asm/processor.h
@@ -88,11 +88,10 @@ extern void __bpon(void);
* User space process size: 2GB for 31 bit, 4TB or 8PT for 64 bit.
*/
-#define TASK_SIZE_OF(tsk) (test_tsk_thread_flag(tsk, TIF_31BIT) ? \
+#define TASK_SIZE (test_tsk_thread_flag(current, TIF_31BIT) ? \
_REGION3_SIZE : TASK_SIZE_MAX)
#define TASK_UNMAPPED_BASE (test_thread_flag(TIF_31BIT) ? \
(_REGION3_SIZE >> 1) : (_REGION2_SIZE >> 1))
-#define TASK_SIZE TASK_SIZE_OF(current)
#define TASK_SIZE_MAX (-PAGE_SIZE)
#define STACK_TOP (test_thread_flag(TIF_31BIT) ? \
--
2.25.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 6/8] sched: parisc: Remove unused TASK_SIZE_OF
2021-12-21 17:00 [PATCH 0/8] sched: Remove unused TASK_SIZE_OF guoren
` (4 preceding siblings ...)
2021-12-21 17:00 ` [PATCH 5/8] sched: s390: " guoren
@ 2021-12-21 17:00 ` guoren
2021-12-21 17:00 ` [PATCH 7/8] sched: arm64: " guoren
2021-12-21 17:00 ` [PATCH 8/8] sched: mips: " guoren
7 siblings, 0 replies; 14+ messages in thread
From: guoren @ 2021-12-21 17:00 UTC (permalink / raw)
To: guoren, will, tglx, benh, arnd, mingo, peterz, juri.lelli
Cc: linux-kernel, linux-riscv, linux-s390, sparclinux, linuxppc-dev,
inux-parisc, linux-mips, linux-arm-kernel, x86, Guo Ren
From: Guo Ren <guoren@linux.alibaba.com>
This macro isn't used in Linux sched, now. Delete in
include/linux/sched.h and arch's include/asm.
Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
---
arch/parisc/include/asm/processor.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/parisc/include/asm/processor.h b/arch/parisc/include/asm/processor.h
index b669f4b9040b..d9c8dc76ee6a 100644
--- a/arch/parisc/include/asm/processor.h
+++ b/arch/parisc/include/asm/processor.h
@@ -23,8 +23,7 @@
#define HAVE_ARCH_PICK_MMAP_LAYOUT
-#define TASK_SIZE_OF(tsk) ((tsk)->thread.task_size)
-#define TASK_SIZE TASK_SIZE_OF(current)
+#define TASK_SIZE (current->thread.task_size)
#define TASK_UNMAPPED_BASE (current->thread.map_base)
#define DEFAULT_TASK_SIZE32 (0xFFF00000UL)
--
2.25.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 7/8] sched: arm64: Remove unused TASK_SIZE_OF
2021-12-21 17:00 [PATCH 0/8] sched: Remove unused TASK_SIZE_OF guoren
` (5 preceding siblings ...)
2021-12-21 17:00 ` [PATCH 6/8] sched: parisc: " guoren
@ 2021-12-21 17:00 ` guoren
2021-12-21 17:00 ` [PATCH 8/8] sched: mips: " guoren
7 siblings, 0 replies; 14+ messages in thread
From: guoren @ 2021-12-21 17:00 UTC (permalink / raw)
To: guoren, will, tglx, benh, arnd, mingo, peterz, juri.lelli
Cc: linux-kernel, linux-riscv, linux-s390, sparclinux, linuxppc-dev,
inux-parisc, linux-mips, linux-arm-kernel, x86, Guo Ren
From: Guo Ren <guoren@linux.alibaba.com>
This macro isn't used in Linux sched, now. Delete in
include/linux/sched.h and arch's include/asm.
Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
---
arch/arm64/include/asm/processor.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/include/asm/processor.h b/arch/arm64/include/asm/processor.h
index 6f41b65f9962..d24dfb49237d 100644
--- a/arch/arm64/include/asm/processor.h
+++ b/arch/arm64/include/asm/processor.h
@@ -65,8 +65,6 @@
#endif /* CONFIG_ARM64_64K_PAGES */
#define TASK_SIZE (test_thread_flag(TIF_32BIT) ? \
TASK_SIZE_32 : TASK_SIZE_64)
-#define TASK_SIZE_OF(tsk) (test_tsk_thread_flag(tsk, TIF_32BIT) ? \
- TASK_SIZE_32 : TASK_SIZE_64)
#define DEFAULT_MAP_WINDOW (test_thread_flag(TIF_32BIT) ? \
TASK_SIZE_32 : DEFAULT_MAP_WINDOW_64)
#else
--
2.25.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 8/8] sched: mips: Remove unused TASK_SIZE_OF
2021-12-21 17:00 [PATCH 0/8] sched: Remove unused TASK_SIZE_OF guoren
` (6 preceding siblings ...)
2021-12-21 17:00 ` [PATCH 7/8] sched: arm64: " guoren
@ 2021-12-21 17:00 ` guoren
7 siblings, 0 replies; 14+ messages in thread
From: guoren @ 2021-12-21 17:00 UTC (permalink / raw)
To: guoren, will, tglx, benh, arnd, mingo, peterz, juri.lelli
Cc: linux-kernel, linux-riscv, linux-s390, sparclinux, linuxppc-dev,
inux-parisc, linux-mips, linux-arm-kernel, x86, Guo Ren
From: Guo Ren <guoren@linux.alibaba.com>
This macro isn't used in Linux sched, now. Delete in
include/linux/sched.h and arch's include/asm.
Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
---
arch/mips/include/asm/processor.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/mips/include/asm/processor.h b/arch/mips/include/asm/processor.h
index 4bb24579d12e..8871fc5b0baa 100644
--- a/arch/mips/include/asm/processor.h
+++ b/arch/mips/include/asm/processor.h
@@ -61,9 +61,6 @@ extern int arch_dup_task_struct(struct task_struct *dst, struct task_struct *src
#define TASK_SIZE (test_thread_flag(TIF_32BIT_ADDR) ? TASK_SIZE32 : TASK_SIZE64)
#define STACK_TOP_MAX TASK_SIZE64
-#define TASK_SIZE_OF(tsk) \
- (test_tsk_thread_flag(tsk, TIF_32BIT_ADDR) ? TASK_SIZE32 : TASK_SIZE64)
-
#define TASK_IS_32BIT_ADDR test_thread_flag(TIF_32BIT_ADDR)
#endif
--
2.25.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 1/8] sched: Remove unused TASK_SIZE_OF
2021-12-21 17:00 ` [PATCH 1/8] " guoren
@ 2021-12-21 17:28 ` Arnd Bergmann
0 siblings, 0 replies; 14+ messages in thread
From: Arnd Bergmann @ 2021-12-21 17:28 UTC (permalink / raw)
To: Guo Ren
Cc: Will Deacon, Thomas Gleixner, Benjamin Herrenschmidt,
Arnd Bergmann, Ingo Molnar, Peter Zijlstra, Juri Lelli,
Linux Kernel Mailing List, linux-riscv, linux-s390, sparclinux,
linuxppc-dev, inux-parisc, open list:BROADCOM NVRAM DRIVER,
Linux ARM, the arch/x86 maintainers, Guo Ren
On Tue, Dec 21, 2021 at 6:00 PM <guoren@kernel.org> wrote:
>
> From: Guo Ren <guoren@linux.alibaba.com>
>
> This macro isn't used in Linux, now. Delete in include/linux/sched.h
> and arch's include/asm. This would confuse people who are
> implementing the COMPAT feature for architecture.
>
> Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
It would help to list how long it has been unused for. Looking through
the git history, I see commit a06db751c321 ("pagemap: check
permissions and capabilities at open time") removing the last user.
I would normally offer to take the entire series through the asm-generic
tree, as I do for this kind of cross-architecture work. I'll probably
not have time before the merge window to pick it up though, so it
may be better to go through the architecture trees, or possibly
linux-mm for anything that fails to get picked up.
For the series:
Review-by: Arnd Bergmann <arnd@arndb.de>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 4/8] sched: powerpc: Remove unused TASK_SIZE_OF
2021-12-21 17:00 ` [PATCH 4/8] sched: powerpc: " guoren
@ 2021-12-21 18:43 ` Christophe Leroy
2021-12-22 3:02 ` Guo Ren
0 siblings, 1 reply; 14+ messages in thread
From: Christophe Leroy @ 2021-12-21 18:43 UTC (permalink / raw)
To: guoren@kernel.org, will@kernel.org, tglx@linutronix.de,
benh@kernel.crashing.org, arnd@arndb.de, mingo@redhat.com,
peterz@infradead.org, juri.lelli@redhat.com
Cc: linux-s390@vger.kernel.org, Guo Ren, x86@kernel.org,
linux-kernel@vger.kernel.org, sparclinux@vger.kernel.or,
linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, inux-parisc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Le 21/12/2021 à 18:00, guoren@kernel.org a écrit :
> From: Guo Ren <guoren@linux.alibaba.com>
>
> This macro isn't used in Linux sched, now. Delete in
> include/linux/sched.h and arch's include/asm.
>
> Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
> ---
> arch/powerpc/include/asm/task_size_64.h | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/task_size_64.h b/arch/powerpc/include/asm/task_size_64.h
> index c993482237ed..7e2eca4fac4d 100644
> --- a/arch/powerpc/include/asm/task_size_64.h
> +++ b/arch/powerpc/include/asm/task_size_64.h
> @@ -44,12 +44,10 @@
> */
> #define TASK_SIZE_USER32 (0x0000000100000000UL - (1 * PAGE_SIZE))
>
> -#define TASK_SIZE_OF(tsk) \
> - (test_tsk_thread_flag(tsk, TIF_32BIT) ? TASK_SIZE_USER32 : \
> +#define TASK_SIZE \
> + (test_tsk_thread_flag(current, TIF_32BIT) ? TASK_SIZE_USER32 : \
> TASK_SIZE_USER64)
I think you should use test_thread_flag() instead.
Or even better: use is_32bit_task() and bring back this macro as a
single line, something like:
#define TASK_SIZE (is_32bit_task() ? TASK_SIZE_USER32 : TASK_SIZE_USER64)
>
> -#define TASK_SIZE TASK_SIZE_OF(current)
> -
> #define TASK_UNMAPPED_BASE_USER32 (PAGE_ALIGN(TASK_SIZE_USER32 / 4))
> #define TASK_UNMAPPED_BASE_USER64 (PAGE_ALIGN(DEFAULT_MAP_WINDOW_USER64 / 4))
>
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 4/8] sched: powerpc: Remove unused TASK_SIZE_OF
2021-12-21 18:43 ` Christophe Leroy
@ 2021-12-22 3:02 ` Guo Ren
2021-12-22 7:27 ` Christophe Leroy
0 siblings, 1 reply; 14+ messages in thread
From: Guo Ren @ 2021-12-22 3:02 UTC (permalink / raw)
To: Christophe Leroy
Cc: will@kernel.org, tglx@linutronix.de, benh@kernel.crashing.org,
arnd@arndb.de, mingo@redhat.com, peterz@infradead.org,
juri.lelli@redhat.com, linux-s390@vger.kernel.org, Guo Ren,
x86@kernel.org, linux-kernel@vger.kernel.org,
sparclinux@vger.kernel.or, linux-mips@vger.kernel.org,
linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,
inux-parisc@vger.kernel.org, linux-arm-kernel@lists.infradead.org
On Wed, Dec 22, 2021 at 2:43 AM Christophe Leroy
<christophe.leroy@csgroup.eu> wrote:
>
>
>
> Le 21/12/2021 à 18:00, guoren@kernel.org a écrit :
> > From: Guo Ren <guoren@linux.alibaba.com>
> >
> > This macro isn't used in Linux sched, now. Delete in
> > include/linux/sched.h and arch's include/asm.
> >
> > Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
> > ---
> > arch/powerpc/include/asm/task_size_64.h | 6 ++----
> > 1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/powerpc/include/asm/task_size_64.h b/arch/powerpc/include/asm/task_size_64.h
> > index c993482237ed..7e2eca4fac4d 100644
> > --- a/arch/powerpc/include/asm/task_size_64.h
> > +++ b/arch/powerpc/include/asm/task_size_64.h
> > @@ -44,12 +44,10 @@
> > */
> > #define TASK_SIZE_USER32 (0x0000000100000000UL - (1 * PAGE_SIZE))
> >
> > -#define TASK_SIZE_OF(tsk) \
> > - (test_tsk_thread_flag(tsk, TIF_32BIT) ? TASK_SIZE_USER32 : \
> > +#define TASK_SIZE \
> > + (test_tsk_thread_flag(current, TIF_32BIT) ? TASK_SIZE_USER32 : \
> > TASK_SIZE_USER64)
>
> I think you should use test_thread_flag() instead.
>
> Or even better: use is_32bit_task() and bring back this macro as a
> single line, something like:
>
> #define TASK_SIZE (is_32bit_task() ? TASK_SIZE_USER32 : TASK_SIZE_USER64)
Okay, looks better. I would fix it in the next version.
>
> >
> > -#define TASK_SIZE TASK_SIZE_OF(current)
> > -
> > #define TASK_UNMAPPED_BASE_USER32 (PAGE_ALIGN(TASK_SIZE_USER32 / 4))
> > #define TASK_UNMAPPED_BASE_USER64 (PAGE_ALIGN(DEFAULT_MAP_WINDOW_USER64 / 4))
> >
> >
--
Best Regards
Guo Ren
ML: https://lore.kernel.org/linux-csky/
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 4/8] sched: powerpc: Remove unused TASK_SIZE_OF
2021-12-22 3:02 ` Guo Ren
@ 2021-12-22 7:27 ` Christophe Leroy
2021-12-22 8:22 ` Guo Ren
0 siblings, 1 reply; 14+ messages in thread
From: Christophe Leroy @ 2021-12-22 7:27 UTC (permalink / raw)
To: Guo Ren
Cc: will@kernel.org, tglx@linutronix.de, benh@kernel.crashing.org,
arnd@arndb.de, mingo@redhat.com, peterz@infradead.org,
juri.lelli@redhat.com, linux-s390@vger.kernel.org, Guo Ren,
x86@kernel.org, linux-kernel@vger.kernel.org,
sparclinux@vger.kernel.or, linux-mips@vger.kernel.org,
linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,
inux-parisc@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Le 22/12/2021 à 04:02, Guo Ren a écrit :
> On Wed, Dec 22, 2021 at 2:43 AM Christophe Leroy
> <christophe.leroy@csgroup.eu> wrote:
>>
>>
>>
>> Le 21/12/2021 à 18:00, guoren@kernel.org a écrit :
>>> From: Guo Ren <guoren@linux.alibaba.com>
>>>
>>> This macro isn't used in Linux sched, now. Delete in
>>> include/linux/sched.h and arch's include/asm.
>>>
>>> Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
>>> ---
>>> arch/powerpc/include/asm/task_size_64.h | 6 ++----
>>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/arch/powerpc/include/asm/task_size_64.h b/arch/powerpc/include/asm/task_size_64.h
>>> index c993482237ed..7e2eca4fac4d 100644
>>> --- a/arch/powerpc/include/asm/task_size_64.h
>>> +++ b/arch/powerpc/include/asm/task_size_64.h
>>> @@ -44,12 +44,10 @@
>>> */
>>> #define TASK_SIZE_USER32 (0x0000000100000000UL - (1 * PAGE_SIZE))
>>>
>>> -#define TASK_SIZE_OF(tsk) \
>>> - (test_tsk_thread_flag(tsk, TIF_32BIT) ? TASK_SIZE_USER32 : \
>>> +#define TASK_SIZE \
>>> + (test_tsk_thread_flag(current, TIF_32BIT) ? TASK_SIZE_USER32 : \
>>> TASK_SIZE_USER64)
>>
>> I think you should use test_thread_flag() instead.
>>
>> Or even better: use is_32bit_task() and bring back this macro as a
>> single line, something like:
>>
>> #define TASK_SIZE (is_32bit_task() ? TASK_SIZE_USER32 : TASK_SIZE_USER64)
> Okay, looks better. I would fix it in the next version.
Note that is_32bit_task() exists on powerpc, parisc and sparc.
For other ones you can still use test_thread_flag() instead of
test_tsk_thread_flag(current)
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 4/8] sched: powerpc: Remove unused TASK_SIZE_OF
2021-12-22 7:27 ` Christophe Leroy
@ 2021-12-22 8:22 ` Guo Ren
0 siblings, 0 replies; 14+ messages in thread
From: Guo Ren @ 2021-12-22 8:22 UTC (permalink / raw)
To: Christophe Leroy
Cc: will@kernel.org, tglx@linutronix.de, benh@kernel.crashing.org,
arnd@arndb.de, mingo@redhat.com, peterz@infradead.org,
juri.lelli@redhat.com, linux-s390@vger.kernel.org, Guo Ren,
x86@kernel.org, linux-kernel@vger.kernel.org,
sparclinux@vger.kernel.or, linux-mips@vger.kernel.org,
linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,
inux-parisc@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Got it. Thx
On Wed, Dec 22, 2021 at 3:27 PM Christophe Leroy
<christophe.leroy@csgroup.eu> wrote:
>
>
>
> Le 22/12/2021 à 04:02, Guo Ren a écrit :
> > On Wed, Dec 22, 2021 at 2:43 AM Christophe Leroy
> > <christophe.leroy@csgroup.eu> wrote:
> >>
> >>
> >>
> >> Le 21/12/2021 à 18:00, guoren@kernel.org a écrit :
> >>> From: Guo Ren <guoren@linux.alibaba.com>
> >>>
> >>> This macro isn't used in Linux sched, now. Delete in
> >>> include/linux/sched.h and arch's include/asm.
> >>>
> >>> Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
> >>> ---
> >>> arch/powerpc/include/asm/task_size_64.h | 6 ++----
> >>> 1 file changed, 2 insertions(+), 4 deletions(-)
> >>>
> >>> diff --git a/arch/powerpc/include/asm/task_size_64.h b/arch/powerpc/include/asm/task_size_64.h
> >>> index c993482237ed..7e2eca4fac4d 100644
> >>> --- a/arch/powerpc/include/asm/task_size_64.h
> >>> +++ b/arch/powerpc/include/asm/task_size_64.h
> >>> @@ -44,12 +44,10 @@
> >>> */
> >>> #define TASK_SIZE_USER32 (0x0000000100000000UL - (1 * PAGE_SIZE))
> >>>
> >>> -#define TASK_SIZE_OF(tsk) \
> >>> - (test_tsk_thread_flag(tsk, TIF_32BIT) ? TASK_SIZE_USER32 : \
> >>> +#define TASK_SIZE \
> >>> + (test_tsk_thread_flag(current, TIF_32BIT) ? TASK_SIZE_USER32 : \
> >>> TASK_SIZE_USER64)
> >>
> >> I think you should use test_thread_flag() instead.
> >>
> >> Or even better: use is_32bit_task() and bring back this macro as a
> >> single line, something like:
> >>
> >> #define TASK_SIZE (is_32bit_task() ? TASK_SIZE_USER32 : TASK_SIZE_USER64)
> > Okay, looks better. I would fix it in the next version.
>
> Note that is_32bit_task() exists on powerpc, parisc and sparc.
>
> For other ones you can still use test_thread_flag() instead of
> test_tsk_thread_flag(current)
--
Best Regards
Guo Ren
ML: https://lore.kernel.org/linux-csky/
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2021-12-22 8:24 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-21 17:00 [PATCH 0/8] sched: Remove unused TASK_SIZE_OF guoren
2021-12-21 17:00 ` [PATCH 1/8] " guoren
2021-12-21 17:28 ` Arnd Bergmann
2021-12-21 17:00 ` [PATCH 2/8] sched: x86: " guoren
2021-12-21 17:00 ` [PATCH 3/8] sched: sparc: " guoren
2021-12-21 17:00 ` [PATCH 4/8] sched: powerpc: " guoren
2021-12-21 18:43 ` Christophe Leroy
2021-12-22 3:02 ` Guo Ren
2021-12-22 7:27 ` Christophe Leroy
2021-12-22 8:22 ` Guo Ren
2021-12-21 17:00 ` [PATCH 5/8] sched: s390: " guoren
2021-12-21 17:00 ` [PATCH 6/8] sched: parisc: " guoren
2021-12-21 17:00 ` [PATCH 7/8] sched: arm64: " guoren
2021-12-21 17:00 ` [PATCH 8/8] sched: mips: " guoren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).