From: John Kacur <jkacur@redhat.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Nam Cao <namcao@linutronix.de>,
Clark Williams <williams@redhat.com>,
linux-rt-users@vger.kernel.org
Subject: Re: [PATCH] rt-tests: hackbench: drop incorrect and unnecessary usage of optind
Date: Fri, 5 Apr 2024 17:24:53 -0400 (EDT) [thread overview]
Message-ID: <41c7ad34-bf2f-3034-b679-5f8eb4acfd8a@redhat.com> (raw)
In-Reply-To: <20240405085227.1GoglMTY@linutronix.de>
On Fri, 5 Apr 2024, Sebastian Andrzej Siewior wrote:
> On 2024-04-02 19:46:59 [+0200], Nam Cao wrote:
> > Variable "optind" is used as the last argument of getopt_long(). This
> > means it "is set to the index of the long option relative to longopts"
> > (from man page). NULL check is then performed on argv[optind], which is
> > not valid, because in this case, optind is not an index to argv[].
> >
> > There is another "optind" which is a global variable, which actually
> > holds the index to argv[]. This is likely the actual intention here. By
> > locally define another "optind", the "real optind" is shadowed in this
> > scope.
> >
> > Furthermore, the original optind "is the index of the next element to
> > be processed in argv" (from man page), not the index to the current
> > element. So doing NULL-check on argv[optind] with the "original optind"
> > is also not valid.
> >
> > There is no reason to do this NULL-check, since argv[optind] is not even
> > read. Only optarg is read, which is never a NULL pointer in this case.
> >
> > Delete this incorrect and unnecessary "optind".
> >
> > Signed-off-by: Nam Cao <namcao@linutronix.de>
>
> Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>
> Sebastian
>
>
Added your Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
to the patch, thanks
next prev parent reply other threads:[~2024-04-05 21:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 17:46 [PATCH] rt-tests: hackbench: drop incorrect and unnecessary usage of optind Nam Cao
2024-04-05 8:52 ` Sebastian Andrzej Siewior
2024-04-05 21:24 ` John Kacur [this message]
2024-04-05 21:22 ` John Kacur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41c7ad34-bf2f-3034-b679-5f8eb4acfd8a@redhat.com \
--to=jkacur@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=linux-rt-users@vger.kernel.org \
--cc=namcao@linutronix.de \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).