From: "Nghia Le" <nghialm78@gmail.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: linux-safety@lists.elisa.tech
Subject: Re: [linux-safety] [PATCH v2] ext4: remove useless resetting io_end_size in mpage_process_page()
Date: Tue, 26 Oct 2021 05:25:56 +0700 [thread overview]
Message-ID: <CADkY59uOUOjAZek6k_arWgnrYxD6SJqH=2Uy=3w5_tX9jQKUjQ@mail.gmail.com> (raw)
Message-ID: <20211025222556.bC2XwTOnnVmeV_TqhtHrRheeB7eoPmj58U40tikCD7g@z> (raw)
In-Reply-To: <CAKXUXMxC+pGWzkNvM0N+RfM04-45RAVqaBWc9oV9_zbpfrvnsA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2186 bytes --]
Hi Lukas,
Thanks a lot for your comments, I fixed typos and submitted patch to public
mailing list.
Best regards,
Nghia Le
On Mon, Oct 25, 2021 at 10:49 PM Lukas Bulwahn <lukas.bulwahn@gmail.com>
wrote:
> On Thu, Oct 21, 2021 at 7:43 PM Nghia Le <nghialm78@gmail.com> wrote:
> >
> > The command "make clang-analyzer" detects dead stores.
>
> maybe mention that it detects dead stores in mpage_process_page().
>
> >
> > Do not reset io_end_size to 0 in the current paths, as the function
> > exists on those paths wihout further using io_end_sized.
>
> just a few typo:
>
> s/exists/exits/
> s/wihout/without/
> s/io_end_sized/io_end_size/
>
> So far it looks good. Can you correct those minor points above and
> then we should be fine...
>
> Lukas
>
> >
> > Signed-off-by: Nghia Le <nghialm78@gmail.com>
> > ---
> > fs/ext4/inode.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> > index 0f06305167d5..03efed2ed1ea 100644
> > --- a/fs/ext4/inode.c
> > +++ b/fs/ext4/inode.c
> > @@ -2260,7 +2260,6 @@ static int mpage_process_page(struct mpage_da_data
> *mpd, struct page *page,
> > mpd->map.m_len = 0;
> > mpd->map.m_flags = 0;
> > io_end_vec->size += io_end_size;
> > - io_end_size = 0;
> >
> > err = mpage_process_page_bufs(mpd, head, bh,
> lblk);
> > if (err > 0)
> > @@ -2285,7 +2284,6 @@ static int mpage_process_page(struct mpage_da_data
> *mpd, struct page *page,
> > } while (lblk++, (bh = bh->b_this_page) != head);
> >
> > io_end_vec->size += io_end_size;
> > - io_end_size = 0;
> > *map_bh = false;
> > out:
> > *m_lblk = lblk;
> > --
> > 2.25.1
> >
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#257): https://lists.elisa.tech/g/linux-safety/message/257
Mute This Topic: https://lists.elisa.tech/mt/86495840/5278000
Group Owner: linux-safety+owner@lists.elisa.tech
Unsubscribe: https://lists.elisa.tech/g/linux-safety/unsub [linux-safety@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
[-- Attachment #2: Type: text/html, Size: 3855 bytes --]
next prev parent reply other threads:[~2021-10-25 22:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 17:42 [linux-safety] [PATCH v2] ext4: remove useless resetting io_end_size in mpage_process_page() Nghia Le
2021-10-21 17:42 ` Nghia Le
2021-10-25 15:49 ` Lukas Bulwahn
2021-10-25 15:49 ` [linux-safety] " Lukas Bulwahn
2021-10-25 22:25 ` Nghia Le [this message]
2021-10-25 22:25 ` Nghia Le
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADkY59uOUOjAZek6k_arWgnrYxD6SJqH=2Uy=3w5_tX9jQKUjQ@mail.gmail.com' \
--to=nghialm78@gmail.com \
--cc=linux-safety@lists.elisa.tech \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).