From: Robin van der Gracht <robin@protonic.nl>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: lee@kernel.org, daniel.thompson@linaro.org, jingoohan1@gmail.com,
deller@gmx.de, dri-devel@lists.freedesktop.org,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
Miguel Ojeda <ojeda@kernel.org>
Subject: Re: [PATCH 1/6] auxdisplay/ht16k33: Replace use of fb_blank with backlight helper
Date: Mon, 18 Mar 2024 10:06:31 +0100 [thread overview]
Message-ID: <20240318100631.253b2d8e@erd007.prtnl> (raw)
In-Reply-To: <20240313154857.12949-2-tzimmermann@suse.de>
Hi Thomas,
Thank you for submitting your patch, it looks fine to me.
Reviewed-by: Robin van der Gracht <robin@protonic.nl>
On Wed, 13 Mar 2024 16:45:00 +0100
Thomas Zimmermann <tzimmermann@suse.de> wrote:
> Replace the use of struct backlight_properties.fb_blank with a
> call to backlight_get_brightness(). The helper implement the same
> logic as the driver's function.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Robin van der Gracht <robin@protonic.nl>
> Cc: Miguel Ojeda <ojeda@kernel.org>
> ---
> drivers/auxdisplay/ht16k33.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/auxdisplay/ht16k33.c
> b/drivers/auxdisplay/ht16k33.c index a90430b7d07ba..83db829b97a5e
> 100644 --- a/drivers/auxdisplay/ht16k33.c
> +++ b/drivers/auxdisplay/ht16k33.c
> @@ -314,14 +314,9 @@ static int ht16k33_initialize(struct
> ht16k33_priv *priv)
> static int ht16k33_bl_update_status(struct backlight_device *bl)
> {
> - int brightness = bl->props.brightness;
> + int brightness = backlight_get_brightness(bl);
> struct ht16k33_priv *priv = bl_get_data(bl);
>
> - if (bl->props.power != FB_BLANK_UNBLANK ||
> - bl->props.fb_blank != FB_BLANK_UNBLANK ||
> - bl->props.state & BL_CORE_FBBLANK)
> - brightness = 0;
> -
> return ht16k33_brightness_set(priv, brightness);
> }
>
next prev parent reply other threads:[~2024-03-18 9:07 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 15:44 [PATCH 0/6] backlight: Remove struct backlight_properties.fb_blank Thomas Zimmermann
2024-03-13 15:45 ` [PATCH 1/6] auxdisplay/ht16k33: Replace use of fb_blank with backlight helper Thomas Zimmermann
2024-03-13 16:08 ` Miguel Ojeda
2024-03-13 17:11 ` Dan Carpenter
2024-03-13 17:44 ` Miguel Ojeda
2024-03-13 17:54 ` Sam Ravnborg
2024-03-14 18:44 ` Miguel Ojeda
2024-03-14 8:09 ` Thomas Zimmermann
2024-03-14 18:44 ` Miguel Ojeda
2024-03-13 17:34 ` Dan Carpenter
2024-03-13 18:01 ` Sam Ravnborg
2024-03-14 8:34 ` Geert Uytterhoeven
2024-03-18 9:06 ` Robin van der Gracht [this message]
2024-03-13 15:45 ` [PATCH 2/6] backlight/omap1-bl: Remove unused struct omap_backlight_config.set_power Thomas Zimmermann
2024-03-13 16:33 ` Lee Jones
2024-03-13 18:02 ` Sam Ravnborg
2024-03-18 11:45 ` Daniel Thompson
2024-03-13 15:45 ` [PATCH 3/6] backlight/omap1-bl: Replace FB_BLANK_ states with simple on/off Thomas Zimmermann
2024-03-13 18:00 ` Sam Ravnborg
2024-03-14 8:16 ` Thomas Zimmermann
2024-03-14 8:57 ` Sam Ravnborg
2024-03-14 9:53 ` Dan Carpenter
2024-03-18 12:06 ` Daniel Thompson
2024-03-13 15:45 ` [PATCH 4/6] fbdev/omap2/omapfb: Replace use of fb_blank with backlight helpers Thomas Zimmermann
2024-03-13 15:45 ` [PATCH 5/6] staging/fbtft: Remove reference to fb_blank Thomas Zimmermann
2024-03-13 17:33 ` Dan Carpenter
2024-03-13 15:45 ` [PATCH 6/6] backlight: Remove fb_blank from struct backlight_properties Thomas Zimmermann
2024-03-14 12:48 ` FLAVIO SULIGOI
2024-03-18 12:08 ` Daniel Thompson
2024-03-13 17:36 ` [PATCH 0/6] backlight: Remove struct backlight_properties.fb_blank Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240318100631.253b2d8e@erd007.prtnl \
--to=robin@protonic.nl \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=ojeda@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).