From: Daniel Thompson <daniel.thompson@linaro.org>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: lee@kernel.org, jingoohan1@gmail.com, deller@gmx.de,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-staging@lists.linux.dev, Flavio Suligoi <f.suligoi@asem.it>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>
Subject: Re: [PATCH 6/6] backlight: Remove fb_blank from struct backlight_properties
Date: Mon, 18 Mar 2024 12:08:58 +0000 [thread overview]
Message-ID: <20240318120858.GE16260@aspen.lan> (raw)
In-Reply-To: <20240313154857.12949-7-tzimmermann@suse.de>
On Wed, Mar 13, 2024 at 04:45:05PM +0100, Thomas Zimmermann wrote:
> Remove the field fb_blank from struct backlight_properties and remove
> all code that still sets or reads it. Backlight blank status is now
> tracked exclusively in struct backlight_properties.state.
>
> The core backlight code keeps the fb_blank and state fields in sync,
> but doesn't do anything else with fb_blank. Several drivers initialize
> fb_blank to FB_BLANK_UNBLANK to enable the backlight. This is already
> the default for the state field. So we can delete the fb_blank code
> from core and drivers and rely on the state field.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Flavio Suligoi <f.suligoi@asem.it>
> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: Claudiu Beznea <claudiu.beznea@tuxon.dev>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
next prev parent reply other threads:[~2024-03-18 12:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 15:44 [PATCH 0/6] backlight: Remove struct backlight_properties.fb_blank Thomas Zimmermann
2024-03-13 15:45 ` [PATCH 1/6] auxdisplay/ht16k33: Replace use of fb_blank with backlight helper Thomas Zimmermann
2024-03-13 16:08 ` Miguel Ojeda
2024-03-13 17:11 ` Dan Carpenter
2024-03-13 17:44 ` Miguel Ojeda
2024-03-13 17:54 ` Sam Ravnborg
2024-03-14 18:44 ` Miguel Ojeda
2024-03-14 8:09 ` Thomas Zimmermann
2024-03-14 18:44 ` Miguel Ojeda
2024-03-13 17:34 ` Dan Carpenter
2024-03-13 18:01 ` Sam Ravnborg
2024-03-14 8:34 ` Geert Uytterhoeven
2024-03-18 9:06 ` Robin van der Gracht
2024-03-13 15:45 ` [PATCH 2/6] backlight/omap1-bl: Remove unused struct omap_backlight_config.set_power Thomas Zimmermann
2024-03-13 16:33 ` Lee Jones
2024-03-13 18:02 ` Sam Ravnborg
2024-03-18 11:45 ` Daniel Thompson
2024-03-13 15:45 ` [PATCH 3/6] backlight/omap1-bl: Replace FB_BLANK_ states with simple on/off Thomas Zimmermann
2024-03-13 18:00 ` Sam Ravnborg
2024-03-14 8:16 ` Thomas Zimmermann
2024-03-14 8:57 ` Sam Ravnborg
2024-03-14 9:53 ` Dan Carpenter
2024-03-18 12:06 ` Daniel Thompson
2024-03-13 15:45 ` [PATCH 4/6] fbdev/omap2/omapfb: Replace use of fb_blank with backlight helpers Thomas Zimmermann
2024-03-13 15:45 ` [PATCH 5/6] staging/fbtft: Remove reference to fb_blank Thomas Zimmermann
2024-03-13 17:33 ` Dan Carpenter
2024-03-13 15:45 ` [PATCH 6/6] backlight: Remove fb_blank from struct backlight_properties Thomas Zimmermann
2024-03-14 12:48 ` FLAVIO SULIGOI
2024-03-18 12:08 ` Daniel Thompson [this message]
2024-03-13 17:36 ` [PATCH 0/6] backlight: Remove struct backlight_properties.fb_blank Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240318120858.GE16260@aspen.lan \
--to=daniel.thompson@linaro.org \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=f.suligoi@asem.it \
--cc=jingoohan1@gmail.com \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nicolas.ferre@microchip.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).