From: Jackson Chui <jacksonchui.qwerty@gmail.com>
To: Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Cc: Jackson Chui <jacksonchui.qwerty@gmail.com>
Subject: [PATCH] staging: greybus: Clear up precedence for gcam logging macros
Date: Wed, 3 Apr 2024 17:16:28 -0700 [thread overview]
Message-ID: <20240404001627.94858-1-jacksonchui.qwerty@gmail.com> (raw)
Reported by checkpatch:
CHECK: Macro argument 'gcam' may be better as '(gcam)' to avoid
precedence issues
Disambiguates '&' (address-of) operator and '->' operator precedence,
accounting for how '(gcam)->bundle->dev' is a 'struct device' and not a
'struct device*', which is required by the dev_{dbg,info,err} driver
model diagnostic macros. Issue found by checkpatch.
Signed-off-by: Jackson Chui <jacksonchui.qwerty@gmail.com>
---
drivers/staging/greybus/camera.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c
index a8173aa3a995..d82a2d2abdca 100644
--- a/drivers/staging/greybus/camera.c
+++ b/drivers/staging/greybus/camera.c
@@ -180,9 +180,9 @@ static const struct gb_camera_fmt_info *gb_camera_get_format_info(u16 gb_fmt)
#define GB_CAMERA_MAX_SETTINGS_SIZE 8192
-#define gcam_dbg(gcam, format...) dev_dbg(&gcam->bundle->dev, format)
-#define gcam_info(gcam, format...) dev_info(&gcam->bundle->dev, format)
-#define gcam_err(gcam, format...) dev_err(&gcam->bundle->dev, format)
+#define gcam_dbg(gcam, format...) dev_dbg(&((gcam)->bundle->dev), format)
+#define gcam_info(gcam, format...) dev_info(&((gcam)->bundle->dev), format)
+#define gcam_err(gcam, format...) dev_err(&((gcam)->bundle->dev), format)
static int gb_camera_operation_sync_flags(struct gb_connection *connection,
int type, unsigned int flags,
--
2.34.1
next reply other threads:[~2024-04-04 0:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 0:16 Jackson Chui [this message]
2024-04-04 22:05 ` [PATCH] staging: greybus: Clear up precedence for gcam logging macros Alex Elder
2024-04-05 21:22 ` Jackson Chui
2024-04-06 9:09 ` Dan Carpenter
2024-04-06 16:45 ` Alex Elder
2024-04-06 22:35 ` Jackson Chui
2024-04-08 6:35 ` Dan Carpenter
2024-04-07 6:13 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240404001627.94858-1-jacksonchui.qwerty@gmail.com \
--to=jacksonchui.qwerty@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).