From: Dan Carpenter <dan.carpenter@linaro.org>
To: Jackson Chui <jacksonchui.qwerty@gmail.com>
Cc: Alex Elder <elder@ieee.org>, Johan Hovold <johan@kernel.org>,
Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: Clear up precedence for gcam logging macros
Date: Mon, 8 Apr 2024 09:35:18 +0300 [thread overview]
Message-ID: <e037e303-47b3-4758-914c-980ebe88d450@moroto.mountain> (raw)
In-Reply-To: <ZhHOKkqVIdsuZ-4Q@mba15m2.local>
On Sat, Apr 06, 2024 at 06:35:22PM -0400, Jackson Chui wrote:
> > -Alex
>
> Dan, Alex I think both of you are spot on.
>
> I like the suggestion of adding 'gcam_dev()' as an accessor
> function and directly calling to 'dev_*'. I'm busy this weekend
> but will send out a new patch with this change next week.
Nah, don't bother with adding the gcam_dev() function. Like Alex says,
it's only 4 characters shorter. Just get rid of the macros and do:
dev_err(&gcam->bundle->dev,
"Unsupported unsolicited event: %u\n", op->type);
regards,
dan carpenter
next prev parent reply other threads:[~2024-04-08 6:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 0:16 [PATCH] staging: greybus: Clear up precedence for gcam logging macros Jackson Chui
2024-04-04 22:05 ` Alex Elder
2024-04-05 21:22 ` Jackson Chui
2024-04-06 9:09 ` Dan Carpenter
2024-04-06 16:45 ` Alex Elder
2024-04-06 22:35 ` Jackson Chui
2024-04-08 6:35 ` Dan Carpenter [this message]
2024-04-07 6:13 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e037e303-47b3-4758-914c-980ebe88d450@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=elder@ieee.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=jacksonchui.qwerty@gmail.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).