From: Alex Elder <elder@ieee.org>
To: "F.A.Sulaiman" <asha.16@itfac.mrt.ac.lk>,
johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org
Cc: greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] Staging: greybus: fix open parenthesis error in gbphy.c
Date: Wed, 19 May 2021 15:06:42 -0500 [thread overview]
Message-ID: <4af943f6-9baa-72a6-12b5-6b35179a7019@ieee.org> (raw)
In-Reply-To: <20210519181938.30813-1-asha.16@itfac.mrt.ac.lk>
On 5/19/21 1:19 PM, F.A.Sulaiman wrote:
> This patch fix "Alignment should match open parenthesis" checkpatch error.
>
> Signed-off-by: "F.A.Sulaiman" <asha.16@itfac.mrt.ac.lk>
I have mixed feelings about this one. This alignment rule
is fine, but I personally don't think it improves things.
Aside from that, there are a few more places in the Greybus
code that lead to exactly this warning. So I guess, if we're
going to have the code follow this alignment rule, why not
just fix all spots at once (i.e., in a patch series)?
Anyway, I'll offer this, but perhaps others can provide
their opinion.
Acked-by: Alex Elder <elder@linaro.org>
> ---
> drivers/staging/greybus/gbphy.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/gbphy.c b/drivers/staging/greybus/gbphy.c
> index 9fc5c47be9bd..13d319860da5 100644
> --- a/drivers/staging/greybus/gbphy.c
> +++ b/drivers/staging/greybus/gbphy.c
> @@ -27,7 +27,7 @@ struct gbphy_host {
> static DEFINE_IDA(gbphy_id);
>
> static ssize_t protocol_id_show(struct device *dev,
> - struct device_attribute *attr, char *buf)
> + struct device_attribute *attr, char *buf)
> {
> struct gbphy_device *gbphy_dev = to_gbphy_dev(dev);
>
> @@ -221,7 +221,7 @@ void gb_gbphy_deregister_driver(struct gbphy_driver *driver)
> EXPORT_SYMBOL_GPL(gb_gbphy_deregister_driver);
>
> static struct gbphy_device *gb_gbphy_create_dev(struct gb_bundle *bundle,
> - struct greybus_descriptor_cport *cport_desc)
> + struct greybus_descriptor_cport *cport_desc)
> {
> struct gbphy_device *gbphy_dev;
> int retval;
>
prev parent reply other threads:[~2021-05-19 20:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 18:19 [PATCH V2] Staging: greybus: fix open parenthesis error in gbphy.c F.A.Sulaiman
2021-05-19 20:06 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4af943f6-9baa-72a6-12b5-6b35179a7019@ieee.org \
--to=elder@ieee.org \
--cc=asha.16@itfac.mrt.ac.lk \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).